38174b3a35
go/build is one of the packages that contributes the most towards cmd/go's init cost, which adds up to any call to the tool. One piece of low-hanging fruit is knownOS and knownArch, maps which are filled via an init func from a space-separated list. Using GODEBUG=inittrace=1, we can get three samples: init go/build @0.36 ms, 0.024 ms clock, 6568 bytes, 74 allocs init go/build @0.33 ms, 0.025 ms clock, 6888 bytes, 76 allocs init go/build @0.36 ms, 0.025 ms clock, 6728 bytes, 75 allocs After using a static map instead, we see an improvement: init go/build @0.33 ms, 0.018 ms clock, 5096 bytes, 69 allocs init go/build @0.36 ms, 0.021 ms clock, 5096 bytes, 69 allocs init go/build @0.33 ms, 0.019 ms clock, 5096 bytes, 69 allocs The speedup isn't huge, but it helps, and also reduces allocs. One can also imagine that the compiler may get better with static, read-only maps in the future, whereas the init func will likely always have a linear cost and extra allocations. Change-Id: I430212bad03d25358d2cc7b1eab4536ad88d05a8 Reviewed-on: https://go-review.googlesource.com/c/go/+/390274 Run-TryBot: Daniel Martí <mvdan@mvdan.cc> Trust: Daniel Martí <mvdan@mvdan.cc> TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Ian Lance Taylor <iant@golang.org> |
||
---|---|---|
.github | ||
api | ||
doc | ||
lib/time | ||
misc | ||
src | ||
test | ||
.gitattributes | ||
.gitignore | ||
AUTHORS | ||
codereview.cfg | ||
CONTRIBUTING.md | ||
CONTRIBUTORS | ||
LICENSE | ||
PATENTS | ||
README.md | ||
SECURITY.md |
The Go Programming Language
Go is an open source programming language that makes it easy to build simple, reliable, and efficient software.
Gopher image by Renee French, licensed under Creative Commons 3.0 Attributions license.
Our canonical Git repository is located at https://go.googlesource.com/go. There is a mirror of the repository at https://github.com/golang/go.
Unless otherwise noted, the Go source files are distributed under the BSD-style license found in the LICENSE file.
Download and Install
Binary Distributions
Official binary distributions are available at https://golang.org/dl/.
After downloading a binary release, visit https://golang.org/doc/install for installation instructions.
Install From Source
If a binary distribution is not available for your combination of operating system and architecture, visit https://golang.org/doc/install/source for source installation instructions.
Contributing
Go is the work of thousands of contributors. We appreciate your help!
To contribute, please read the contribution guidelines at https://golang.org/doc/contribute.
Note that the Go project uses the issue tracker for bug reports and proposals only. See https://golang.org/wiki/Questions for a list of places to ask questions about the Go language.