3803c85880
CL 529219 made an existing race with accessing Builder.scriptDir from Builder.fmtcmd (and now also Builder.Showcmd) much more likely by dropping a theoretically unnecessary condition from the call from Builder.run to Builder.fmtcmd. For an example race report, see https://build.golang.org/log/c3cad62d0fc33a8381d2091661c685ea1fc525c4 The race is between (*Builder).cover2() -> (*Builder).run() -> (*Builder).fmtcmd() and various other call paths of the form (*Builder).build() -> (*gcToolchain).* (*Builder).Showcmd() -> (*Builder).fmtcmd() The race can be reproduced with go install -race cmd/go stress -p 1 go test -x -cover -a log Return this race to its existing likelihood by putting the condition back. This isn't a "correct" solution because the race could still happen if the "cover" tool invoked by Builder.cover2 emits output. But this will do for a temporary fix. Change-Id: Ifd811dea07f05e1422fd02b63cd958627727aa12 Reviewed-on: https://go-review.googlesource.com/c/go/+/536355 Auto-Submit: Austin Clements <austin@google.com> Reviewed-by: Bryan Mills <bcmills@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> |
||
|---|---|---|
| .github | ||
| api | ||
| doc | ||
| lib/time | ||
| misc | ||
| src | ||
| test | ||
| .gitattributes | ||
| .gitignore | ||
| codereview.cfg | ||
| CONTRIBUTING.md | ||
| go.env | ||
| LICENSE | ||
| PATENTS | ||
| README.md | ||
| SECURITY.md | ||
The Go Programming Language
Go is an open source programming language that makes it easy to build simple, reliable, and efficient software.
Gopher image by Renee French, licensed under Creative Commons 4.0 Attributions license.
Our canonical Git repository is located at https://go.googlesource.com/go. There is a mirror of the repository at https://github.com/golang/go.
Unless otherwise noted, the Go source files are distributed under the BSD-style license found in the LICENSE file.
Download and Install
Binary Distributions
Official binary distributions are available at https://go.dev/dl/.
After downloading a binary release, visit https://go.dev/doc/install for installation instructions.
Install From Source
If a binary distribution is not available for your combination of operating system and architecture, visit https://go.dev/doc/install/source for source installation instructions.
Contributing
Go is the work of thousands of contributors. We appreciate your help!
To contribute, please read the contribution guidelines at https://go.dev/doc/contribute.
Note that the Go project uses the issue tracker for bug reports and proposals only. See https://go.dev/wiki/Questions for a list of places to ask questions about the Go language.