qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-22 10:24:41 -07:00
Code Releases Activity
The Go programming language
16,183 Commits 58 Branches 402 Tags 522 MiB
Go 89.6%
Assembly 5.2%
HTML 4.8%
C 0.2%
Shell 0.1%
36d3bef8a3
Go to file
Brad Fitzpatrick 36d3bef8a3 database/sql: close driver Stmt before releasing Conn 
From the issue, which describes it as well as I could:

database/sql assumes that driver.Stmt.Close does not need the
connection.

see database/sql/sql.go:1308:

This puts the Rows' connection back into the idle pool, and
then calls the driver.Stmt.Close method of the Stmt it belongs
to.  In the postgresql driver implementation
(https://github.com/lib/pq), Stmt.Close communicates with the
server (on the connection that was just put back into the idle
pool).  Most of the time, this causes no problems, but if
another goroutine makes a query at the right (wrong?) time,
chaos results.

In any case, traffic is being sent on "free" connections
shortly after they are freed, leading to race conditions that
kill the driver code.

Fixes #5283

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/8633044
2013-04-15 14:06:41 -07:00
api api: update next.txt. 2013-04-03 10:41:28 -07:00
doc doc/reference.html: update list of sub-repositories. 2013-04-16 04:31:25 +08:00
include include/plan9/libc.h: fix Plan 9 build 2013-03-30 19:05:00 +08:00
lib lib/time: update time zone to IANA version 2013b 2013-04-02 16:49:45 -07:00
misc misc/dist/darwin: add execute bit to preinstall 2013-04-11 13:40:14 -07:00
src database/sql: close driver Stmt before releasing Conn 2013-04-15 14:06:41 -07:00
test test/stress: start of a runtime stress program 2013-04-15 11:50:14 -07:00
.hgignore build: update Makefile to track source code dependencies better 2012-03-13 03:31:11 +08:00
.hgtags untag go1.1beta1 2013-04-04 13:51:20 +11:00
AUTHORS A+C: Nicholas Presta (individual CLA) 2013-04-09 13:12:31 +10:00
CONTRIBUTORS A+C: Nicholas Presta (individual CLA) 2013-04-09 13:12:31 +10:00
favicon.ico godoc: update favicon 2012-10-11 17:02:36 +11:00
LICENSE doc: update licensing text one more time 2012-03-27 15:09:13 +11:00
PATENTS LICENSE: separate, change PATENTS text 2010-12-06 16:31:59 -05:00
README build: update, streamline documentation for new $GOBIN 2010-08-24 20:00:50 -04:00
robots.txt godoc: serve robots.txt raw 2011-02-19 05:46:20 +11:00

README 

This is the source code repository for the Go programming language.  

For documentation about how to install and use Go,
visit http://golang.org/ or load doc/install.html in your web browser.

After installing Go, you can view a nicely formatted
doc/install.html by running godoc --http=:6060
and then visiting http://localhost:6060/doc/install.html.

Unless otherwise noted, the Go source files are distributed
under the BSD-style license found in the LICENSE file.

--

Binary Distribution Notes

If you have just untarred a binary Go distribution, you need to set
the environment variable $GOROOT to the full path of the go
directory (the one containing this README).  You can omit the
variable if you unpack it into /usr/local/go, or if you rebuild
from sources by running all.bash (see doc/install.html).
You should also add the Go binary directory $GOROOT/bin
to your shell's path.

For example, if you extracted the tar file into $HOME/go, you might
put the following in your .profile:

    export GOROOT=$HOME/go
    export PATH=$PATH:$GOROOT/bin

See doc/install.html for more details.