mirror of
https://github.com/golang/go
synced 2024-11-05 15:16:11 -07:00
504bc3ed24
Prior to this CL, all runtime conversions from a concrete value to an interface went through one of two runtime calls: convT2E or convT2I. However, in practice, basic types are very common. Specializing convT2x for those basic types allows for a more efficient implementation for those types. For basic scalars and strings, allocation and copying can use the same methods as normal code. For pointer-free types, allocation can occur without zeroing, and copying can take place without GC calls. For slices, copying is cheaper and simpler. This CL adds twelve runtime routines: convT2E16, convT2I16 convT2E32, convT2I32 convT2E64, convT2I64 convT2Estring, convT2Istring convT2Eslice, convT2Islice convT2Enoptr, convT2Inoptr While compiling make.bash, 93% of all convT2x calls are now to one of these specialized convT2x call. Within specialized convT2x routines, it is cheap to check for a zero value, in a way that it is not in general. When we detect a zero value there, we return a pointer to zeroVal, rather than allocating. name old time/op new time/op delta ConvT2Ezero/zero/16-8 17.9ns ± 2% 3.0ns ± 3% -83.20% (p=0.000 n=56+56) ConvT2Ezero/zero/32-8 17.8ns ± 2% 3.0ns ± 3% -83.15% (p=0.000 n=59+60) ConvT2Ezero/zero/64-8 20.1ns ± 1% 3.0ns ± 2% -84.98% (p=0.000 n=57+57) ConvT2Ezero/zero/str-8 32.6ns ± 1% 3.0ns ± 4% -90.70% (p=0.000 n=59+60) ConvT2Ezero/zero/slice-8 36.7ns ± 2% 3.0ns ± 2% -91.78% (p=0.000 n=59+59) ConvT2Ezero/zero/big-8 91.9ns ± 2% 85.9ns ± 2% -6.52% (p=0.000 n=57+57) ConvT2Ezero/nonzero/16-8 17.7ns ± 2% 12.7ns ± 3% -28.38% (p=0.000 n=55+60) ConvT2Ezero/nonzero/32-8 17.8ns ± 1% 12.7ns ± 1% -28.44% (p=0.000 n=54+57) ConvT2Ezero/nonzero/64-8 20.0ns ± 1% 15.0ns ± 1% -24.90% (p=0.000 n=56+58) ConvT2Ezero/nonzero/str-8 32.6ns ± 1% 25.7ns ± 1% -21.17% (p=0.000 n=58+55) ConvT2Ezero/nonzero/slice-8 36.8ns ± 2% 30.4ns ± 1% -17.32% (p=0.000 n=60+52) ConvT2Ezero/nonzero/big-8 92.1ns ± 2% 85.9ns ± 2% -6.70% (p=0.000 n=57+59) Benchmarks on a real program (the compiler): name old time/op new time/op delta Template 227ms ± 5% 221ms ± 2% -2.48% (p=0.000 n=30+26) Unicode 102ms ± 5% 100ms ± 3% -1.30% (p=0.009 n=30+26) GoTypes 656ms ± 5% 659ms ± 4% ~ (p=0.208 n=30+30) Compiler 2.82s ± 2% 2.82s ± 1% ~ (p=0.614 n=29+27) Flate 128ms ± 2% 128ms ± 5% ~ (p=0.783 n=27+28) GoParser 158ms ± 3% 158ms ± 3% ~ (p=0.261 n=28+30) Reflect 408ms ± 7% 401ms ± 3% ~ (p=0.075 n=30+30) Tar 123ms ± 6% 121ms ± 8% ~ (p=0.287 n=29+30) XML 220ms ± 2% 220ms ± 4% ~ (p=0.805 n=29+29) name old user-ns/op new user-ns/op delta Template 281user-ms ± 4% 279user-ms ± 3% -0.87% (p=0.044 n=28+28) Unicode 142user-ms ± 4% 141user-ms ± 3% -1.04% (p=0.015 n=30+27) GoTypes 884user-ms ± 3% 886user-ms ± 2% ~ (p=0.532 n=30+30) Compiler 3.94user-s ± 3% 3.92user-s ± 1% ~ (p=0.185 n=30+28) Flate 165user-ms ± 2% 165user-ms ± 4% ~ (p=0.780 n=27+29) GoParser 209user-ms ± 2% 208user-ms ± 3% ~ (p=0.453 n=28+30) Reflect 533user-ms ± 6% 526user-ms ± 3% ~ (p=0.057 n=30+30) Tar 156user-ms ± 6% 154user-ms ± 6% ~ (p=0.133 n=29+30) XML 288user-ms ± 4% 288user-ms ± 4% ~ (p=0.633 n=30+30) name old alloc/op new alloc/op delta Template 41.0MB ± 0% 40.9MB ± 0% -0.11% (p=0.000 n=29+29) Unicode 32.6MB ± 0% 32.6MB ± 0% ~ (p=0.572 n=29+30) GoTypes 122MB ± 0% 122MB ± 0% -0.10% (p=0.000 n=30+30) Compiler 482MB ± 0% 481MB ± 0% -0.07% (p=0.000 n=30+29) Flate 26.6MB ± 0% 26.6MB ± 0% ~ (p=0.096 n=30+30) GoParser 32.7MB ± 0% 32.6MB ± 0% -0.06% (p=0.011 n=28+28) Reflect 84.2MB ± 0% 84.1MB ± 0% -0.17% (p=0.000 n=29+30) Tar 27.7MB ± 0% 27.7MB ± 0% -0.05% (p=0.032 n=27+28) XML 44.7MB ± 0% 44.7MB ± 0% ~ (p=0.131 n=28+30) name old allocs/op new allocs/op delta Template 373k ± 1% 370k ± 1% -0.76% (p=0.000 n=30+30) Unicode 325k ± 1% 325k ± 1% ~ (p=0.383 n=29+30) GoTypes 1.16M ± 0% 1.15M ± 0% -0.75% (p=0.000 n=29+30) Compiler 4.15M ± 0% 4.13M ± 0% -0.59% (p=0.000 n=30+29) Flate 238k ± 1% 237k ± 1% -0.62% (p=0.000 n=30+30) GoParser 304k ± 1% 302k ± 1% -0.64% (p=0.000 n=30+28) Reflect 1.00M ± 0% 0.99M ± 0% -1.10% (p=0.000 n=29+30) Tar 245k ± 1% 244k ± 1% -0.59% (p=0.000 n=27+29) XML 391k ± 1% 389k ± 1% -0.59% (p=0.000 n=29+30) Change-Id: Id7f456d690567c2b0a96b0d6d64de8784b6e305f Reviewed-on: https://go-review.googlesource.com/36476 Run-TryBot: Josh Bleecher Snyder <josharian@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Keith Randall <khr@golang.org>
689 lines
20 KiB
Go
689 lines
20 KiB
Go
// errorcheckwithauto -0 -l -live -wb=0 -d=ssa/insert_resched_checks/off
|
|
// +build !ppc64,!ppc64le
|
|
// ppc64 needs a better tighten pass to make f18 pass
|
|
// rescheduling checks need to be turned off because there are some live variables across the inserted check call
|
|
|
|
// Copyright 2014 The Go Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
// liveness tests with inlining disabled.
|
|
// see also live2.go.
|
|
|
|
package main
|
|
|
|
func printnl()
|
|
|
|
//go:noescape
|
|
func printpointer(**int)
|
|
|
|
//go:noescape
|
|
func printintpointer(*int)
|
|
|
|
//go:noescape
|
|
func printstringpointer(*string)
|
|
|
|
//go:noescape
|
|
func printstring(string)
|
|
|
|
//go:noescape
|
|
func printbytepointer(*byte)
|
|
|
|
func printint(int)
|
|
|
|
func f1() {
|
|
var x *int
|
|
printpointer(&x) // ERROR "live at call to printpointer: x$"
|
|
printpointer(&x) // ERROR "live at call to printpointer: x$"
|
|
}
|
|
|
|
func f2(b bool) {
|
|
if b {
|
|
printint(0) // nothing live here
|
|
return
|
|
}
|
|
var x *int
|
|
printpointer(&x) // ERROR "live at call to printpointer: x$"
|
|
printpointer(&x) // ERROR "live at call to printpointer: x$"
|
|
}
|
|
|
|
func f3(b1, b2 bool) {
|
|
// Here x and y are ambiguously live. In previous go versions they
|
|
// were marked as live throughout the function to avoid being
|
|
// poisoned in GODEBUG=gcdead=1 mode; this is now no longer the
|
|
// case.
|
|
|
|
printint(0)
|
|
if b1 == false {
|
|
printint(0)
|
|
return
|
|
}
|
|
|
|
if b2 {
|
|
var x *int
|
|
printpointer(&x) // ERROR "live at call to printpointer: x$"
|
|
printpointer(&x) // ERROR "live at call to printpointer: x$"
|
|
} else {
|
|
var y *int
|
|
printpointer(&y) // ERROR "live at call to printpointer: y$"
|
|
printpointer(&y) // ERROR "live at call to printpointer: y$"
|
|
}
|
|
printint(0) // ERROR "f3: x \(type \*int\) is ambiguously live$" "f3: y \(type \*int\) is ambiguously live$" "live at call to printint: x y$"
|
|
}
|
|
|
|
// The old algorithm treated x as live on all code that
|
|
// could flow to a return statement, so it included the
|
|
// function entry and code above the declaration of x
|
|
// but would not include an indirect use of x in an infinite loop.
|
|
// Check that these cases are handled correctly.
|
|
|
|
func f4(b1, b2 bool) { // x not live here
|
|
if b2 {
|
|
printint(0) // x not live here
|
|
return
|
|
}
|
|
var z **int
|
|
x := new(int)
|
|
*x = 42
|
|
z = &x
|
|
printint(**z) // ERROR "live at call to printint: x$"
|
|
if b2 {
|
|
printint(1) // x not live here
|
|
return
|
|
}
|
|
for {
|
|
printint(**z) // ERROR "live at call to printint: x$"
|
|
}
|
|
}
|
|
|
|
func f5(b1 bool) {
|
|
var z **int
|
|
if b1 {
|
|
x := new(int)
|
|
*x = 42
|
|
z = &x
|
|
} else {
|
|
y := new(int)
|
|
*y = 54
|
|
z = &y
|
|
}
|
|
printint(**z) // ERROR "f5: x \(type \*int\) is ambiguously live$" "f5: y \(type \*int\) is ambiguously live$" "live at call to printint: x y$"
|
|
}
|
|
|
|
// confusion about the _ result used to cause spurious "live at entry to f6: _".
|
|
|
|
func f6() (_, y string) {
|
|
y = "hello"
|
|
return
|
|
}
|
|
|
|
// confusion about addressed results used to cause "live at entry to f7: x".
|
|
|
|
func f7() (x string) {
|
|
_ = &x
|
|
x = "hello"
|
|
return
|
|
}
|
|
|
|
// ignoring block returns used to cause "live at entry to f8: x, y".
|
|
|
|
func f8() (x, y string) {
|
|
return g8()
|
|
}
|
|
|
|
func g8() (string, string)
|
|
|
|
// ignoring block assignments used to cause "live at entry to f9: x"
|
|
// issue 7205
|
|
|
|
var i9 interface{}
|
|
|
|
func f9() bool {
|
|
g8()
|
|
x := i9
|
|
y := interface{}(str()) // ERROR "live at call to convT2Estring: .autotmp_[0-9]+ x.data x.type$" "live at call to str: x.data x.type$"
|
|
i9 = y // make y escape so the line above has to call convT2E
|
|
return x != y
|
|
}
|
|
|
|
// liveness formerly confused by UNDEF followed by RET,
|
|
// leading to "live at entry to f10: ~r1" (unnamed result).
|
|
|
|
func f10() string {
|
|
panic(1)
|
|
}
|
|
|
|
// liveness formerly confused by select, thinking runtime.selectgo
|
|
// can return to next instruction; it always jumps elsewhere.
|
|
// note that you have to use at least two cases in the select
|
|
// to get a true select; smaller selects compile to optimized helper functions.
|
|
|
|
var c chan *int
|
|
var b bool
|
|
|
|
// this used to have a spurious "live at entry to f11a: ~r0"
|
|
func f11a() *int {
|
|
select { // ERROR "live at call to newselect: .autotmp_[0-9]+$" "live at call to selectgo: .autotmp_[0-9]+$"
|
|
case <-c: // ERROR "live at call to selectrecv: .autotmp_[0-9]+$"
|
|
return nil
|
|
case <-c: // ERROR "live at call to selectrecv: .autotmp_[0-9]+$"
|
|
return nil
|
|
}
|
|
}
|
|
|
|
func f11b() *int {
|
|
p := new(int)
|
|
if b {
|
|
// At this point p is dead: the code here cannot
|
|
// get to the bottom of the function.
|
|
// This used to have a spurious "live at call to printint: p".
|
|
printint(1) // nothing live here!
|
|
select { // ERROR "live at call to newselect: .autotmp_[0-9]+$" "live at call to selectgo: .autotmp_[0-9]+$"
|
|
case <-c: // ERROR "live at call to selectrecv: .autotmp_[0-9]+$"
|
|
return nil
|
|
case <-c: // ERROR "live at call to selectrecv: .autotmp_[0-9]+$"
|
|
return nil
|
|
}
|
|
}
|
|
println(*p)
|
|
return nil
|
|
}
|
|
|
|
var sink *int
|
|
|
|
func f11c() *int {
|
|
p := new(int)
|
|
sink = p // prevent stack allocation, otherwise p is rematerializeable
|
|
if b {
|
|
// Unlike previous, the cases in this select fall through,
|
|
// so we can get to the println, so p is not dead.
|
|
printint(1) // ERROR "live at call to printint: p$"
|
|
select { // ERROR "live at call to newselect: .autotmp_[0-9]+ p$" "live at call to selectgo: .autotmp_[0-9]+ p$"
|
|
case <-c: // ERROR "live at call to selectrecv: .autotmp_[0-9]+ p$"
|
|
case <-c: // ERROR "live at call to selectrecv: .autotmp_[0-9]+ p$"
|
|
}
|
|
}
|
|
println(*p)
|
|
return nil
|
|
}
|
|
|
|
// similarly, select{} does not fall through.
|
|
// this used to have a spurious "live at entry to f12: ~r0".
|
|
|
|
func f12() *int {
|
|
if b {
|
|
select {}
|
|
} else {
|
|
return nil
|
|
}
|
|
}
|
|
|
|
// incorrectly placed VARDEF annotations can cause missing liveness annotations.
|
|
// this used to be missing the fact that s is live during the call to g13 (because it is
|
|
// needed for the call to h13).
|
|
|
|
func f13() {
|
|
s := g14()
|
|
s = h13(s, g13(s)) // ERROR "live at call to g13: s.ptr$"
|
|
}
|
|
|
|
func g13(string) string
|
|
func h13(string, string) string
|
|
|
|
// more incorrectly placed VARDEF.
|
|
|
|
func f14() {
|
|
x := g14()
|
|
printstringpointer(&x) // ERROR "live at call to printstringpointer: x$"
|
|
}
|
|
|
|
func g14() string
|
|
|
|
func f15() {
|
|
var x string
|
|
_ = &x
|
|
x = g15() // ERROR "live at call to g15: x$"
|
|
printstring(x) // ERROR "live at call to printstring: x$"
|
|
}
|
|
|
|
func g15() string
|
|
|
|
// Checking that various temporaries do not persist or cause
|
|
// ambiguously live values that must be zeroed.
|
|
// The exact temporary names are inconsequential but we are
|
|
// trying to check that there is only one at any given site,
|
|
// and also that none show up in "ambiguously live" messages.
|
|
|
|
var m map[string]int
|
|
|
|
// str is used to ensure that a temp is required for runtime calls below.
|
|
func str() string
|
|
|
|
func f16() {
|
|
if b {
|
|
delete(m, str()) // ERROR "live at call to mapdelete: .autotmp_[0-9]+$"
|
|
}
|
|
delete(m, str()) // ERROR "live at call to mapdelete: .autotmp_[0-9]+$"
|
|
delete(m, str()) // ERROR "live at call to mapdelete: .autotmp_[0-9]+$"
|
|
}
|
|
|
|
var m2s map[string]*byte
|
|
var m2 map[[2]string]*byte
|
|
var x2 [2]string
|
|
var bp *byte
|
|
|
|
func f17a(p *byte) { // ERROR "live at entry to f17a: p$"
|
|
if b {
|
|
m2[x2] = p // ERROR "live at call to mapassign: p$"
|
|
}
|
|
m2[x2] = p // ERROR "live at call to mapassign: p$"
|
|
m2[x2] = p // ERROR "live at call to mapassign: p$"
|
|
}
|
|
|
|
func f17b(p *byte) { // ERROR "live at entry to f17b: p$"
|
|
// key temporary
|
|
if b {
|
|
m2s[str()] = p // ERROR "live at call to mapassign: p .autotmp_[0-9]+$" "live at call to str: p$"
|
|
}
|
|
m2s[str()] = p // ERROR "live at call to mapassign: p .autotmp_[0-9]+$" "live at call to str: p$"
|
|
m2s[str()] = p // ERROR "live at call to mapassign: p .autotmp_[0-9]+$" "live at call to str: p$"
|
|
}
|
|
|
|
func f17c() {
|
|
// key and value temporaries
|
|
if b {
|
|
m2s[str()] = f17d() // ERROR "live at call to f17d: .autotmp_[0-9]+$" "live at call to mapassign: .autotmp_[0-9]+ .autotmp_[0-9]+$"
|
|
}
|
|
m2s[str()] = f17d() // ERROR "live at call to f17d: .autotmp_[0-9]+$" "live at call to mapassign: .autotmp_[0-9]+ .autotmp_[0-9]+$"
|
|
m2s[str()] = f17d() // ERROR "live at call to f17d: .autotmp_[0-9]+$" "live at call to mapassign: .autotmp_[0-9]+ .autotmp_[0-9]+$"
|
|
}
|
|
|
|
func f17d() *byte
|
|
|
|
func g18() [2]string
|
|
|
|
func f18() {
|
|
// key temporary for mapaccess.
|
|
// temporary introduced by orderexpr.
|
|
var z *byte
|
|
if b {
|
|
z = m2[g18()] // ERROR "live at call to mapaccess1: .autotmp_[0-9]+$"
|
|
}
|
|
z = m2[g18()] // ERROR "live at call to mapaccess1: .autotmp_[0-9]+$"
|
|
z = m2[g18()] // ERROR "live at call to mapaccess1: .autotmp_[0-9]+$"
|
|
printbytepointer(z)
|
|
}
|
|
|
|
var ch chan *byte
|
|
|
|
// byteptr is used to ensure that a temp is required for runtime calls below.
|
|
func byteptr() *byte
|
|
|
|
func f19() {
|
|
// dest temporary for channel receive.
|
|
var z *byte
|
|
|
|
if b {
|
|
z = <-ch // ERROR "live at call to chanrecv1: .autotmp_[0-9]+$"
|
|
}
|
|
z = <-ch // ERROR "live at call to chanrecv1: .autotmp_[0-9]+$"
|
|
z = <-ch // ERROR "live at call to chanrecv1: .autotmp_[0-9]+$"
|
|
printbytepointer(z)
|
|
}
|
|
|
|
func f20() {
|
|
// src temporary for channel send
|
|
if b {
|
|
ch <- byteptr() // ERROR "live at call to chansend1: .autotmp_[0-9]+$"
|
|
}
|
|
ch <- byteptr() // ERROR "live at call to chansend1: .autotmp_[0-9]+$"
|
|
ch <- byteptr() // ERROR "live at call to chansend1: .autotmp_[0-9]+$"
|
|
}
|
|
|
|
func f21() {
|
|
// key temporary for mapaccess using array literal key.
|
|
var z *byte
|
|
if b {
|
|
z = m2[[2]string{"x", "y"}] // ERROR "live at call to mapaccess1: .autotmp_[0-9]+$"
|
|
}
|
|
z = m2[[2]string{"x", "y"}] // ERROR "live at call to mapaccess1: .autotmp_[0-9]+$"
|
|
z = m2[[2]string{"x", "y"}] // ERROR "live at call to mapaccess1: .autotmp_[0-9]+$"
|
|
printbytepointer(z)
|
|
}
|
|
|
|
func f23() {
|
|
// key temporary for two-result map access using array literal key.
|
|
var z *byte
|
|
var ok bool
|
|
if b {
|
|
z, ok = m2[[2]string{"x", "y"}] // ERROR "live at call to mapaccess2: .autotmp_[0-9]+$"
|
|
}
|
|
z, ok = m2[[2]string{"x", "y"}] // ERROR "live at call to mapaccess2: .autotmp_[0-9]+$"
|
|
z, ok = m2[[2]string{"x", "y"}] // ERROR "live at call to mapaccess2: .autotmp_[0-9]+$"
|
|
printbytepointer(z)
|
|
print(ok)
|
|
}
|
|
|
|
func f24() {
|
|
// key temporary for map access using array literal key.
|
|
// value temporary too.
|
|
if b {
|
|
m2[[2]string{"x", "y"}] = nil // ERROR "live at call to mapassign: .autotmp_[0-9]+$"
|
|
}
|
|
m2[[2]string{"x", "y"}] = nil // ERROR "live at call to mapassign: .autotmp_[0-9]+$"
|
|
m2[[2]string{"x", "y"}] = nil // ERROR "live at call to mapassign: .autotmp_[0-9]+$"
|
|
}
|
|
|
|
// defer should not cause spurious ambiguously live variables
|
|
|
|
func f25(b bool) {
|
|
defer g25()
|
|
if b {
|
|
return
|
|
}
|
|
var x string
|
|
_ = &x
|
|
x = g15() // ERROR "live at call to g15: x$"
|
|
printstring(x) // ERROR "live at call to printstring: x$"
|
|
} // ERROR "live at call to deferreturn: x$"
|
|
|
|
func g25()
|
|
|
|
// non-escaping ... slices passed to function call should die on return,
|
|
// so that the temporaries do not stack and do not cause ambiguously
|
|
// live variables.
|
|
|
|
func f26(b bool) {
|
|
if b {
|
|
print26((*int)(nil), (*int)(nil), (*int)(nil)) // ERROR "live at call to print26: .autotmp_[0-9]+$"
|
|
}
|
|
print26((*int)(nil), (*int)(nil), (*int)(nil)) // ERROR "live at call to print26: .autotmp_[0-9]+$"
|
|
print26((*int)(nil), (*int)(nil), (*int)(nil)) // ERROR "live at call to print26: .autotmp_[0-9]+$"
|
|
printnl()
|
|
}
|
|
|
|
//go:noescape
|
|
func print26(...interface{})
|
|
|
|
// non-escaping closures passed to function call should die on return
|
|
|
|
func f27(b bool) {
|
|
x := 0
|
|
if b {
|
|
call27(func() { x++ }) // ERROR "live at call to call27: .autotmp_[0-9]+$"
|
|
}
|
|
call27(func() { x++ }) // ERROR "live at call to call27: .autotmp_[0-9]+$"
|
|
call27(func() { x++ }) // ERROR "live at call to call27: .autotmp_[0-9]+$"
|
|
printnl()
|
|
}
|
|
|
|
// but defer does escape to later execution in the function
|
|
|
|
func f27defer(b bool) {
|
|
x := 0
|
|
if b {
|
|
defer call27(func() { x++ }) // ERROR "live at call to deferproc: .autotmp_[0-9]+$" "live at call to deferreturn: .autotmp_[0-9]+$"
|
|
}
|
|
defer call27(func() { x++ }) // ERROR "f27defer: .autotmp_[0-9]+ \(type struct { F uintptr; x \*int }\) is ambiguously live$" "live at call to deferproc: .autotmp_[0-9]+ .autotmp_[0-9]+$" "live at call to deferreturn: .autotmp_[0-9]+ .autotmp_[0-9]+$"
|
|
printnl() // ERROR "live at call to printnl: .autotmp_[0-9]+ .autotmp_[0-9]+$"
|
|
} // ERROR "live at call to deferreturn: .autotmp_[0-9]+ .autotmp_[0-9]+$"
|
|
|
|
// and newproc (go) escapes to the heap
|
|
|
|
func f27go(b bool) {
|
|
x := 0
|
|
if b {
|
|
go call27(func() { x++ }) // ERROR "live at call to newobject: &x$" "live at call to newproc: &x$"
|
|
}
|
|
go call27(func() { x++ }) // ERROR "live at call to newobject: &x$"
|
|
printnl()
|
|
}
|
|
|
|
//go:noescape
|
|
func call27(func())
|
|
|
|
// concatstring slice should die on return
|
|
|
|
var s1, s2, s3, s4, s5, s6, s7, s8, s9, s10 string
|
|
|
|
func f28(b bool) {
|
|
if b {
|
|
printstring(s1 + s2 + s3 + s4 + s5 + s6 + s7 + s8 + s9 + s10) // ERROR "live at call to concatstrings: .autotmp_[0-9]+$" "live at call to printstring: .autotmp_[0-9]+$"
|
|
}
|
|
printstring(s1 + s2 + s3 + s4 + s5 + s6 + s7 + s8 + s9 + s10) // ERROR "live at call to concatstrings: .autotmp_[0-9]+$" "live at call to printstring: .autotmp_[0-9]+$"
|
|
printstring(s1 + s2 + s3 + s4 + s5 + s6 + s7 + s8 + s9 + s10) // ERROR "live at call to concatstrings: .autotmp_[0-9]+$" "live at call to printstring: .autotmp_[0-9]+$"
|
|
}
|
|
|
|
// map iterator should die on end of range loop
|
|
|
|
func f29(b bool) {
|
|
if b {
|
|
for k := range m { // ERROR "live at call to mapiterinit: .autotmp_[0-9]+$" "live at call to mapiternext: .autotmp_[0-9]+$"
|
|
printstring(k) // ERROR "live at call to printstring: .autotmp_[0-9]+$"
|
|
}
|
|
}
|
|
for k := range m { // ERROR "live at call to mapiterinit: .autotmp_[0-9]+$" "live at call to mapiternext: .autotmp_[0-9]+$"
|
|
printstring(k) // ERROR "live at call to printstring: .autotmp_[0-9]+$"
|
|
}
|
|
for k := range m { // ERROR "live at call to mapiterinit: .autotmp_[0-9]+$" "live at call to mapiternext: .autotmp_[0-9]+$"
|
|
printstring(k) // ERROR "live at call to printstring: .autotmp_[0-9]+$"
|
|
}
|
|
}
|
|
|
|
// copy of array of pointers should die at end of range loop
|
|
|
|
var ptrarr [10]*int
|
|
|
|
func f30(b bool) {
|
|
// two live temps during print(p):
|
|
// the copy of ptrarr and the internal iterator pointer.
|
|
if b {
|
|
for _, p := range ptrarr {
|
|
printintpointer(p) // ERROR "live at call to printintpointer: .autotmp_[0-9]+ .autotmp_[0-9]+$"
|
|
}
|
|
}
|
|
for _, p := range ptrarr {
|
|
printintpointer(p) // ERROR "live at call to printintpointer: .autotmp_[0-9]+ .autotmp_[0-9]+$"
|
|
}
|
|
for _, p := range ptrarr {
|
|
printintpointer(p) // ERROR "live at call to printintpointer: .autotmp_[0-9]+ .autotmp_[0-9]+$"
|
|
}
|
|
}
|
|
|
|
// conversion to interface should not leave temporary behind
|
|
|
|
func f31(b1, b2, b3 bool) {
|
|
if b1 {
|
|
g31(str()) // ERROR "live at call to convT2Estring: .autotmp_[0-9]+$" "live at call to g31: .autotmp_[0-9]+$"
|
|
}
|
|
if b2 {
|
|
h31(str()) // ERROR "live at call to convT2Estring: .autotmp_[0-9]+ .autotmp_[0-9]+$" "live at call to h31: .autotmp_[0-9]+$" "live at call to newobject: .autotmp_[0-9]+$"
|
|
}
|
|
if b3 {
|
|
panic(str()) // ERROR "live at call to convT2Estring: .autotmp_[0-9]+$" "live at call to gopanic: .autotmp_[0-9]+$"
|
|
}
|
|
print(b3)
|
|
}
|
|
|
|
func g31(interface{})
|
|
func h31(...interface{})
|
|
|
|
// non-escaping partial functions passed to function call should die on return
|
|
|
|
type T32 int
|
|
|
|
func (t *T32) Inc() { // ERROR "live at entry to \(\*T32\).Inc: t$"
|
|
*t++
|
|
}
|
|
|
|
var t32 T32
|
|
|
|
func f32(b bool) {
|
|
if b {
|
|
call32(t32.Inc) // ERROR "live at call to call32: .autotmp_[0-9]+$"
|
|
}
|
|
call32(t32.Inc) // ERROR "live at call to call32: .autotmp_[0-9]+$"
|
|
call32(t32.Inc) // ERROR "live at call to call32: .autotmp_[0-9]+$"
|
|
}
|
|
|
|
//go:noescape
|
|
func call32(func())
|
|
|
|
// temporaries introduced during if conditions and && || expressions
|
|
// should die once the condition has been acted upon.
|
|
|
|
var m33 map[interface{}]int
|
|
|
|
func f33() {
|
|
if m33[byteptr()] == 0 { // ERROR "live at call to mapaccess1: .autotmp_[0-9]+$"
|
|
printnl()
|
|
return
|
|
} else {
|
|
printnl()
|
|
}
|
|
printnl()
|
|
}
|
|
|
|
func f34() {
|
|
if m33[byteptr()] == 0 { // ERROR "live at call to mapaccess1: .autotmp_[0-9]+$"
|
|
printnl()
|
|
return
|
|
}
|
|
printnl()
|
|
}
|
|
|
|
func f35() {
|
|
if m33[byteptr()] == 0 && m33[byteptr()] == 0 { // ERROR "live at call to mapaccess1: .autotmp_[0-9]+$"
|
|
printnl()
|
|
return
|
|
}
|
|
printnl()
|
|
}
|
|
|
|
func f36() {
|
|
if m33[byteptr()] == 0 || m33[byteptr()] == 0 { // ERROR "live at call to mapaccess1: .autotmp_[0-9]+$"
|
|
printnl()
|
|
return
|
|
}
|
|
printnl()
|
|
}
|
|
|
|
func f37() {
|
|
if (m33[byteptr()] == 0 || m33[byteptr()] == 0) && m33[byteptr()] == 0 { // ERROR "live at call to mapaccess1: .autotmp_[0-9]+$"
|
|
printnl()
|
|
return
|
|
}
|
|
printnl()
|
|
}
|
|
|
|
// select temps should disappear in the case bodies
|
|
|
|
var c38 chan string
|
|
|
|
func fc38() chan string
|
|
func fi38(int) *string
|
|
func fb38() *bool
|
|
|
|
func f38(b bool) {
|
|
// we don't care what temps are printed on the lines with output.
|
|
// we care that the println lines have no live variables
|
|
// and therefore no output.
|
|
if b {
|
|
select { // ERROR "live at call to newselect: .autotmp_[0-9]+ .autotmp_[0-9]+ .autotmp_[0-9]+ .autotmp_[0-9]+ .autotmp_[0-9]+ .autotmp_[0-9]+ .autotmp_[0-9]+ .autotmp_[0-9]+$" "live at call to selectgo: .autotmp_[0-9]+ .autotmp_[0-9]+ .autotmp_[0-9]+ .autotmp_[0-9]+ .autotmp_[0-9]+ .autotmp_[0-9]+ .autotmp_[0-9]+$"
|
|
case <-fc38(): // ERROR "live at call to selectrecv: .autotmp_[0-9]+ .autotmp_[0-9]+ .autotmp_[0-9]+ .autotmp_[0-9]+ .autotmp_[0-9]+ .autotmp_[0-9]+ .autotmp_[0-9]+$"
|
|
printnl()
|
|
case fc38() <- *fi38(1): // ERROR "live at call to fc38: .autotmp_[0-9]+$" "live at call to fi38: .autotmp_[0-9]+ .autotmp_[0-9]+$" "live at call to selectsend: .autotmp_[0-9]+ .autotmp_[0-9]+ .autotmp_[0-9]+ .autotmp_[0-9]+ .autotmp_[0-9]+ .autotmp_[0-9]+ .autotmp_[0-9]+$"
|
|
printnl()
|
|
case *fi38(2) = <-fc38(): // ERROR "live at call to fc38: .autotmp_[0-9]+ .autotmp_[0-9]+ .autotmp_[0-9]+$" "live at call to fi38: .autotmp_[0-9]+ .autotmp_[0-9]+ .autotmp_[0-9]+$" "live at call to selectrecv: .autotmp_[0-9]+ .autotmp_[0-9]+ .autotmp_[0-9]+ .autotmp_[0-9]+ .autotmp_[0-9]+ .autotmp_[0-9]+ .autotmp_[0-9]+$"
|
|
printnl()
|
|
case *fi38(3), *fb38() = <-fc38(): // ERROR "live at call to fb38: .autotmp_[0-9]+ .autotmp_[0-9]+ .autotmp_[0-9]+$" "live at call to fc38: .autotmp_[0-9]+ .autotmp_[0-9]+ .autotmp_[0-9]+ .autotmp_[0-9]+ .autotmp_[0-9]+$" "live at call to fi38: .autotmp_[0-9]+ .autotmp_[0-9]+ .autotmp_[0-9]+$" "live at call to selectrecv2: .autotmp_[0-9]+ .autotmp_[0-9]+ .autotmp_[0-9]+ .autotmp_[0-9]+ .autotmp_[0-9]+ .autotmp_[0-9]+ .autotmp_[0-9]+$"
|
|
printnl()
|
|
}
|
|
printnl()
|
|
}
|
|
printnl()
|
|
}
|
|
|
|
// issue 8097: mishandling of x = x during return.
|
|
|
|
func f39() (x []int) {
|
|
x = []int{1}
|
|
printnl() // ERROR "live at call to printnl: .autotmp_[0-9]+$"
|
|
return x
|
|
}
|
|
|
|
func f39a() (x []int) {
|
|
x = []int{1}
|
|
printnl() // ERROR "live at call to printnl: .autotmp_[0-9]+$"
|
|
return
|
|
}
|
|
|
|
func f39b() (x [10]*int) {
|
|
x = [10]*int{}
|
|
x[0] = new(int) // ERROR "live at call to newobject: x$"
|
|
printnl() // ERROR "live at call to printnl: x$"
|
|
return x
|
|
}
|
|
|
|
func f39c() (x [10]*int) {
|
|
x = [10]*int{}
|
|
x[0] = new(int) // ERROR "live at call to newobject: x$"
|
|
printnl() // ERROR "live at call to printnl: x$"
|
|
return
|
|
}
|
|
|
|
// issue 8142: lost 'addrtaken' bit on inlined variables.
|
|
// no inlining in this test, so just checking that non-inlined works.
|
|
|
|
type T40 struct {
|
|
m map[int]int
|
|
}
|
|
|
|
func newT40() *T40 {
|
|
ret := T40{}
|
|
ret.m = make(map[int]int) // ERROR "live at call to makemap: &ret$"
|
|
return &ret
|
|
}
|
|
|
|
func bad40() {
|
|
t := newT40()
|
|
_ = t
|
|
printnl()
|
|
}
|
|
|
|
func good40() {
|
|
ret := T40{}
|
|
ret.m = make(map[int]int) // ERROR "live at call to makemap: .autotmp_[0-9]+ ret$"
|
|
t := &ret
|
|
printnl() // ERROR "live at call to printnl: .autotmp_[0-9]+ ret$"
|
|
_ = t
|
|
}
|
|
|
|
func ddd1(x, y *int) { // ERROR "live at entry to ddd1: x y$"
|
|
ddd2(x, y) // ERROR "live at call to ddd2: .autotmp_[0-9]+$"
|
|
printnl()
|
|
// Note: no .?autotmp live at printnl. See issue 16996.
|
|
}
|
|
func ddd2(a ...*int) { // ERROR "live at entry to ddd2: a$"
|
|
sink = a[0]
|
|
}
|
|
|
|
// issue 16016: autogenerated wrapper should have arguments live
|
|
type T struct{}
|
|
|
|
func (*T) Foo(ptr *int) {}
|
|
|
|
type R struct{ *T } // ERRORAUTO "live at entry to \(\*R\)\.Foo: \.this ptr" "live at entry to R\.Foo: \.this ptr"
|
|
|
|
// issue 18860: output arguments must be live all the time if there is a defer.
|
|
// In particular, at printint r must be live.
|
|
func f41(p, q *int) (r *int) { // ERROR "live at entry to f41: p q$"
|
|
r = p
|
|
defer func() { // ERROR "live at call to deferproc: q r$" "live at call to deferreturn: r$"
|
|
recover()
|
|
}()
|
|
printint(0) // ERROR "live at call to printint: q r$"
|
|
r = q
|
|
return // ERROR "live at call to deferreturn: r$"
|
|
}
|