1
0
mirror of https://github.com/golang/go synced 2024-11-05 12:06:15 -07:00
go/test/interface
Keith Randall 688995d1e9 cmd/compile: do more type conversion inline
The code to do the conversion is smaller than the
call to the runtime.
The 1-result asserts need to call panic if they fail, but that
code is out of line.

The only conversions left in the runtime are those which
might allocate and those which might need to generate an itab.

Given the following types:
  type E interface{}
  type I interface { foo() }
  type I2 iterface { foo(); bar() }
  type Big [10]int
  func (b Big) foo() { ... }

This CL inlines the following conversions:

was assertE2T
  var e E = ...
  b := i.(Big)
was assertE2T2
  var e E = ...
  b, ok := i.(Big)
was assertI2T
  var i I = ...
  b := i.(Big)
was assertI2T2
  var i I = ...
  b, ok := i.(Big)
was assertI2E
  var i I = ...
  e := i.(E)
was assertI2E2
  var i I = ...
  e, ok := i.(E)

These are the remaining runtime calls:

convT2E:
  var b Big = ...
  var e E = b
convT2I:
  var b Big = ...
  var i I = b
convI2I:
  var i2 I2 = ...
  var i I = i2
assertE2I:
  var e E = ...
  i := e.(I)
assertE2I2:
  var e E = ...
  i, ok := e.(I)
assertI2I:
  var i I = ...
  i2 := i.(I2)
assertI2I2:
  var i I = ...
  i2, ok := i.(I2)

Fixes #17405
Fixes #8422

Change-Id: Ida2367bf8ce3cd2c6bb599a1814f1d275afabe21
Reviewed-on: https://go-review.googlesource.com/32313
Run-TryBot: Keith Randall <khr@golang.org>
Reviewed-by: David Chase <drchase@google.com>
2016-11-02 21:33:03 +00:00
..
embed1.dir test: convert tests to run.go whenever possible. 2012-10-10 22:35:27 +02:00
private.dir test: convert tests to run.go whenever possible. 2012-10-10 22:35:27 +02:00
recursive1.dir all: make copyright headers consistent with one space after period 2016-05-02 13:43:18 +00:00
assertinline.go cmd/compile: do more type conversion inline 2016-11-02 21:33:03 +00:00
bigdata.go
convert1.go
convert2.go
convert.go
embed1.go test: convert tests to run.go whenever possible. 2012-10-10 22:35:27 +02:00
embed2.go cmd/internal/gc: improve "type *X has no field or method M" message 2015-05-07 16:21:57 +00:00
embed.go
explicit.go cmd/gc: blank methods are not permitted in interface types 2014-10-15 09:55:13 -07:00
fail.go cmd/gc: blank methods are not permitted in interface types 2014-10-15 09:55:13 -07:00
fake.go
noeq.go all: make copyright headers consistent with one space after period 2016-05-02 13:43:18 +00:00
pointer.go
private.go test: convert tests to run.go whenever possible. 2012-10-10 22:35:27 +02:00
receiver1.go
receiver.go
recursive1.go all: make copyright headers consistent with one space after period 2016-05-02 13:43:18 +00:00
recursive.go
returntype.go
struct.go