mirror of
https://github.com/golang/go
synced 2024-11-25 12:27:57 -07:00
095e0f48a1
This change renames mustHeapAlloc to heapAllocReason, and changes it to return the reason why the argument must escape, so we don't have to re-deduce it in its callers just to print the escape reason. It also embeds isSmallMakeSlice body in heapAllocReason, since the former was only used by the latter, and deletes isSmallMakeSlice. An outdated TODO to remove smallintconst, which the TODO claimed was only used in one place, was also removed, since grepping shows we currently call smallintconst in 11 different places. Change-Id: I0bd11bf29b92c4126f5bb455877ff73217d5a155 Reviewed-on: https://go-review.googlesource.com/c/go/+/258678 Run-TryBot: Alberto Donizetti <alb.donizetti@gmail.com> TryBot-Result: Go Bot <gobot@golang.org> Trust: Alberto Donizetti <alb.donizetti@gmail.com> Trust: Cuong Manh Le <cuong.manhle.vn@gmail.com> Reviewed-by: Cuong Manh Le <cuong.manhle.vn@gmail.com> Reviewed-by: Matthew Dempsky <mdempsky@google.com>
18 lines
546 B
Go
18 lines
546 B
Go
//errorcheck -0 -m -m
|
|
|
|
// Copyright 2020 The Go Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
package p
|
|
|
|
func f() { // ERROR ""
|
|
n, m := 100, 200
|
|
_ = make([]byte, 1<<17) // ERROR "too large for stack" ""
|
|
_ = make([]byte, 100, 1<<17) // ERROR "too large for stack" ""
|
|
_ = make([]byte, n, 1<<17) // ERROR "too large for stack" ""
|
|
|
|
_ = make([]byte, n) // ERROR "non-constant size" ""
|
|
_ = make([]byte, 100, m) // ERROR "non-constant size" ""
|
|
}
|