3367475e83
To infer type arguments in an assignment of the form var target func(t1, t2, ...) = g where g is a generic function func g[P1, P2, ...](p1, p2, ...) the type checker used the synthetic function call g(t1, t2, ...) But because each argument (of type) t1, t2, ... is assigned to its corresponding parameter p1, p2, ..., type inference uses assignment rules ("inexact match") for unification. As a result, types such as mystring and string match even though they should not (they are not identical), yet function parameter types must be identical to match. This CL fixes this by constructing the synthetic call g'(func(t1, t2, ...)) where g' is the generic function func g'[P1, P2, ...](func(p1, p2, ...)) This mimics the function assignment directly by representing it as a single argument passing (of a function-typed argument). Function parameter types must now be identical to unify. As an added benefit, the implementation is simpler. As a consequence, when such an assignment is invalid because the function types cannot possibly match, we now correctly get an inference error. Without this change, in some cases unification would succeed, only to lead to an assignment error afterwards. While at it, update the date in the copyright notice of testdata/manual.go so we don't need to fix it each time we copy code from a test case in manual.go into a issueXXXXX.go file. Fixes #60688. Change-Id: I716247f426ef33d76c7849b0c33c59124e55b859 Reviewed-on: https://go-review.googlesource.com/c/go/+/501938 Reviewed-by: Robert Findley <rfindley@google.com> Reviewed-by: Robert Griesemer <gri@google.com> Run-TryBot: Robert Griesemer <gri@google.com> Auto-Submit: Robert Griesemer <gri@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> |
||
---|---|---|
.github | ||
api | ||
doc | ||
lib/time | ||
misc | ||
src | ||
test | ||
.gitattributes | ||
.gitignore | ||
codereview.cfg | ||
CONTRIBUTING.md | ||
go.env | ||
LICENSE | ||
PATENTS | ||
README.md | ||
SECURITY.md |
The Go Programming Language
Go is an open source programming language that makes it easy to build simple, reliable, and efficient software.
Gopher image by Renee French, licensed under Creative Commons 4.0 Attributions license.
Our canonical Git repository is located at https://go.googlesource.com/go. There is a mirror of the repository at https://github.com/golang/go.
Unless otherwise noted, the Go source files are distributed under the BSD-style license found in the LICENSE file.
Download and Install
Binary Distributions
Official binary distributions are available at https://go.dev/dl/.
After downloading a binary release, visit https://go.dev/doc/install for installation instructions.
Install From Source
If a binary distribution is not available for your combination of operating system and architecture, visit https://go.dev/doc/install/source for source installation instructions.
Contributing
Go is the work of thousands of contributors. We appreciate your help!
To contribute, please read the contribution guidelines at https://go.dev/doc/contribute.
Note that the Go project uses the issue tracker for bug reports and proposals only. See https://go.dev/wiki/Questions for a list of places to ask questions about the Go language.