3304b2235a
When regabiargs is enabled, a function's incoming ABI should be determined solely by the function's own definition ABI (which is usually ABIInternal, but can be ABI0 for ABI wrappers). For example, the current code miscompiles ABI0 -> ABIInternal wrappers when the experiment is enabled because it treats the wrapper itself as being called as ABIInternal. This causes it to assume the incoming arguments are already in registers, so usually the wrapper doesn't do anything with the arguments because it thinks they're already in the right place. With this fix, these wrappers now correctly load the arguments from the stack and put them in registers. For #40724. Change-Id: Iec784e88ebc55d9e95e830ed7533aa336f3b1ca2 Reviewed-on: https://go-review.googlesource.com/c/go/+/306409 Trust: Austin Clements <austin@google.com> Run-TryBot: Austin Clements <austin@google.com> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Than McIntosh <thanm@google.com> Reviewed-by: Cherry Zhang <cherryyz@google.com> |
||
---|---|---|
.github | ||
api | ||
doc | ||
lib/time | ||
misc | ||
src | ||
test | ||
.gitattributes | ||
.gitignore | ||
AUTHORS | ||
codereview.cfg | ||
CONTRIBUTING.md | ||
CONTRIBUTORS | ||
LICENSE | ||
PATENTS | ||
README.md | ||
SECURITY.md |
The Go Programming Language
Go is an open source programming language that makes it easy to build simple, reliable, and efficient software.
Gopher image by Renee French, licensed under Creative Commons 3.0 Attributions license.
Our canonical Git repository is located at https://go.googlesource.com/go. There is a mirror of the repository at https://github.com/golang/go.
Unless otherwise noted, the Go source files are distributed under the BSD-style license found in the LICENSE file.
Download and Install
Binary Distributions
Official binary distributions are available at https://golang.org/dl/.
After downloading a binary release, visit https://golang.org/doc/install for installation instructions.
Install From Source
If a binary distribution is not available for your combination of operating system and architecture, visit https://golang.org/doc/install/source for source installation instructions.
Contributing
Go is the work of thousands of contributors. We appreciate your help!
To contribute, please read the contribution guidelines at https://golang.org/doc/contribute.html.
Note that the Go project uses the issue tracker for bug reports and proposals only. See https://golang.org/wiki/Questions for a list of places to ask questions about the Go language.