mirror of
https://github.com/golang/go
synced 2024-11-18 19:04:40 -07:00
2f43c6d1a2
Change span to hide its fields and have validating accessors This catches the cases where either the offset or the position is being used when it was not set. It also normalizes the forms as the API now controls them, and allows us to simplify some of the logic. The converters are now allowed to return an error, which lets us cleanly propagate bad cases. The lsp was then converted to the new format, and also had some error checking of its own added on the top. All this allowed me to find and fix a few issues, most notably a case where the wrong column mapper was being used during the conversion of definition results. Change-Id: Iebdf8901e8269b28aaef60caf76574baa25c46d4 Reviewed-on: https://go-review.googlesource.com/c/tools/+/167858 Run-TryBot: Ian Cottrell <iancottrell@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>
184 lines
4.9 KiB
Go
184 lines
4.9 KiB
Go
// Copyright 2019 The Go Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
package cmd
|
|
|
|
import (
|
|
"bytes"
|
|
"context"
|
|
"encoding/json"
|
|
"flag"
|
|
"fmt"
|
|
"go/types"
|
|
"os"
|
|
|
|
guru "golang.org/x/tools/cmd/guru/serial"
|
|
"golang.org/x/tools/internal/lsp/cache"
|
|
"golang.org/x/tools/internal/lsp/source"
|
|
"golang.org/x/tools/internal/span"
|
|
"golang.org/x/tools/internal/tool"
|
|
)
|
|
|
|
// A Definition is the result of a 'definition' query.
|
|
type Definition struct {
|
|
Span span.Span `json:"span"` // span of the definition
|
|
Description string `json:"description"` // description of the denoted object
|
|
}
|
|
|
|
// This constant is printed in the help, and then used in a test to verify the
|
|
// help is still valid.
|
|
// It should be the byte offset in this file of the "Set" in "flag.FlagSet" from
|
|
// the DetailedHelp method below.
|
|
const exampleOffset = 1311
|
|
|
|
// definition implements the definition noun for the query command.
|
|
type definition struct {
|
|
query *query
|
|
}
|
|
|
|
func (d *definition) Name() string { return "definition" }
|
|
func (d *definition) Usage() string { return "<position>" }
|
|
func (d *definition) ShortHelp() string { return "show declaration of selected identifier" }
|
|
func (d *definition) DetailedHelp(f *flag.FlagSet) {
|
|
fmt.Fprintf(f.Output(), `
|
|
Example: show the definition of the identifier at syntax at offset %[1]v in this file (flag.FlagSet):
|
|
|
|
$ gopls definition internal/lsp/cmd/definition.go:#%[1]v
|
|
|
|
gopls definition flags are:
|
|
`, exampleOffset)
|
|
f.PrintDefaults()
|
|
}
|
|
|
|
// Run performs the definition query as specified by args and prints the
|
|
// results to stdout.
|
|
func (d *definition) Run(ctx context.Context, args ...string) error {
|
|
if len(args) != 1 {
|
|
return tool.CommandLineErrorf("definition expects 1 argument")
|
|
}
|
|
view := cache.NewView(&d.query.app.Config)
|
|
from := span.Parse(args[0])
|
|
f, err := view.GetFile(ctx, from.URI())
|
|
if err != nil {
|
|
return err
|
|
}
|
|
tok := f.GetToken(ctx)
|
|
pos := tok.Pos(from.Start().Offset())
|
|
if !pos.IsValid() {
|
|
return fmt.Errorf("invalid position %v", from)
|
|
}
|
|
ident, err := source.Identifier(ctx, view, f, pos)
|
|
if err != nil {
|
|
return fmt.Errorf("%v: %v", from, err)
|
|
}
|
|
if ident == nil {
|
|
return fmt.Errorf("%v: not an identifier", from)
|
|
}
|
|
var result interface{}
|
|
switch d.query.Emulate {
|
|
case "":
|
|
result, err = buildDefinition(ctx, view, ident)
|
|
case emulateGuru:
|
|
result, err = buildGuruDefinition(ctx, view, ident)
|
|
default:
|
|
return fmt.Errorf("unknown emulation for definition: %s", d.query.Emulate)
|
|
}
|
|
if err != nil {
|
|
return err
|
|
}
|
|
if d.query.JSON {
|
|
enc := json.NewEncoder(os.Stdout)
|
|
enc.SetIndent("", "\t")
|
|
return enc.Encode(result)
|
|
}
|
|
switch d := result.(type) {
|
|
case *Definition:
|
|
fmt.Printf("%v: defined here as %s", d.Span, d.Description)
|
|
case *guru.Definition:
|
|
fmt.Printf("%s: defined here as %s", d.ObjPos, d.Desc)
|
|
default:
|
|
return fmt.Errorf("no printer for type %T", result)
|
|
}
|
|
return nil
|
|
}
|
|
|
|
func buildDefinition(ctx context.Context, view source.View, ident *source.IdentifierInfo) (*Definition, error) {
|
|
content, err := ident.Hover(ctx, nil)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
spn, err := ident.Declaration.Range.Span()
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
return &Definition{
|
|
Span: spn,
|
|
Description: content,
|
|
}, nil
|
|
}
|
|
|
|
func buildGuruDefinition(ctx context.Context, view source.View, ident *source.IdentifierInfo) (*guru.Definition, error) {
|
|
spn, err := ident.Declaration.Range.Span()
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
pkg := ident.File.GetPackage(ctx)
|
|
// guru does not support ranges
|
|
if !spn.IsPoint() {
|
|
spn = span.New(spn.URI(), spn.Start(), spn.Start())
|
|
}
|
|
// Behavior that attempts to match the expected output for guru. For an example
|
|
// of the format, see the associated definition tests.
|
|
buf := &bytes.Buffer{}
|
|
q := types.RelativeTo(pkg.GetTypes())
|
|
qualifyName := ident.Declaration.Object.Pkg() != pkg.GetTypes()
|
|
name := ident.Name
|
|
var suffix interface{}
|
|
switch obj := ident.Declaration.Object.(type) {
|
|
case *types.TypeName:
|
|
fmt.Fprint(buf, "type")
|
|
case *types.Var:
|
|
if obj.IsField() {
|
|
qualifyName = false
|
|
fmt.Fprint(buf, "field")
|
|
suffix = obj.Type()
|
|
} else {
|
|
fmt.Fprint(buf, "var")
|
|
}
|
|
case *types.Func:
|
|
fmt.Fprint(buf, "func")
|
|
typ := obj.Type()
|
|
if obj.Type() != nil {
|
|
if sig, ok := typ.(*types.Signature); ok {
|
|
buf := &bytes.Buffer{}
|
|
if recv := sig.Recv(); recv != nil {
|
|
if named, ok := recv.Type().(*types.Named); ok {
|
|
fmt.Fprintf(buf, "(%s).%s", named.Obj().Name(), name)
|
|
}
|
|
}
|
|
if buf.Len() == 0 {
|
|
buf.WriteString(name)
|
|
}
|
|
types.WriteSignature(buf, sig, q)
|
|
name = buf.String()
|
|
}
|
|
}
|
|
default:
|
|
fmt.Fprintf(buf, "unknown [%T]", obj)
|
|
}
|
|
fmt.Fprint(buf, " ")
|
|
if qualifyName {
|
|
fmt.Fprintf(buf, "%s.", ident.Declaration.Object.Pkg().Path())
|
|
}
|
|
fmt.Fprint(buf, name)
|
|
if suffix != nil {
|
|
fmt.Fprint(buf, " ")
|
|
fmt.Fprint(buf, suffix)
|
|
}
|
|
return &guru.Definition{
|
|
ObjPos: fmt.Sprint(spn),
|
|
Desc: buf.String(),
|
|
}, nil
|
|
}
|