1
0
mirror of https://github.com/golang/go synced 2024-09-29 23:14:29 -06:00
go/misc/cgo
Ian Lance Taylor 9d669ed47a misc/cgo/errors: use expected column numbers
The test was using the wrong column numbers, and was erroneously
passing because there happened to be line numbers that matched those
column numbers. Change the test harness to require the expected line
number for the ERROR HERE regexp case, so that this doesn't happen again.

Also rename a couple of variables in the test to avoid useless
redeclaration errors.

Fixes #46534

Change-Id: I2fcbf5e379c346de5346035c73d174a3980c0927
Reviewed-on: https://go-review.googlesource.com/c/go/+/324970
Trust: Ian Lance Taylor <iant@golang.org>
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
2021-06-05 04:40:03 +00:00
..
errors misc/cgo/errors: use expected column numbers 2021-06-05 04:40:03 +00:00
fortran misc/cgo/fortran: avoid writing to $PWD 2019-11-20 22:37:23 +00:00
gmp all: make copyright headers consistent with one space after period 2016-05-02 13:43:18 +00:00
life all: update references to symbols moved from io/ioutil to io 2021-04-05 17:51:15 +00:00
nocgo cmd/ld: really import runtime/cgo for external link 2014-05-20 21:36:50 -07:00
stdio all: update references to symbols moved from io/ioutil to io 2021-04-05 17:51:15 +00:00
test syscall: some containers may fail syscall.TestSetuidEtc 2021-05-17 17:46:08 +00:00
testasan misc: log 'ok' from 'go run' tests on success 2019-11-25 16:43:27 +00:00
testcarchive all: simplify the spelling of Linux 2021-04-13 13:56:21 +00:00
testcshared all: update references to symbols moved from io/ioutil to io 2021-04-05 17:51:15 +00:00
testgodefs all: update references to symbols moved from io/ioutil to io 2021-04-05 17:51:15 +00:00
testplugin misc/cgo/testplugin: skip TestIssue25756pie on darwin/arm64 builder 2021-05-20 01:22:28 +00:00
testsanitizers all: update references to symbols moved from io/ioutil to io 2021-04-05 17:51:15 +00:00
testshared all: update references to symbols moved from io/ioutil to io 2021-04-05 17:51:15 +00:00
testsigfwd misc: log 'ok' from 'go run' tests on success 2019-11-25 16:43:27 +00:00
testso misc/cgo/testso, misc/cgo/testsovar: fix for Windows 2021-04-23 21:48:41 +00:00
testsovar misc/cgo/testso, misc/cgo/testsovar: fix for Windows 2021-04-23 21:48:41 +00:00
testtls all: make copyright headers consistent with one space after period 2016-05-02 13:43:18 +00:00