2e07ff3543
This CL first removes the base.ShortPathConservative function. It had two classes of uses. The first was in opening files where the paths end up in error messages. In all those cases, the non-shortened paths are used to open the files, and ShortPath is only used for the error messages. The second is in base.RelPaths. RelPaths will now call ShortPath for each of the paths passed in instead of calling RelConservative and then doing the same check as ShortPath to see if the path is shorter. To avoid the possibility of incorrect relative paths ending up in error messages (that might have command lines suggested for users to run), and to avoid the possibility of incorrect relative paths appearing in the output of base.RelPaths, base.ShortPaths always does an os.SameFile check to make sure that the relative path its providing is actually correct. Since this makes ShortPath slower than just manipulating paths (because we need to stat the files), we need to be continue to enforce that ShortPath is only called for error messages (with the exception of base.RelPaths and its callers). This is a simpler way of solving the problem that base.ShortPaths intended to solve. For #68383 Change-Id: I474f464f51a9acb2250069dea3054b55d95a4ab4 Reviewed-on: https://go-review.googlesource.com/c/go/+/630276 LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Sam Thanawalla <samthanawalla@google.com> |
||
|---|---|---|
| .github | ||
| api | ||
| doc | ||
| lib | ||
| misc | ||
| src | ||
| test | ||
| .gitattributes | ||
| .gitignore | ||
| codereview.cfg | ||
| CONTRIBUTING.md | ||
| go.env | ||
| LICENSE | ||
| PATENTS | ||
| README.md | ||
| SECURITY.md | ||
The Go Programming Language
Go is an open source programming language that makes it easy to build simple, reliable, and efficient software.
Gopher image by Renee French, licensed under Creative Commons 4.0 Attribution license.
Our canonical Git repository is located at https://go.googlesource.com/go. There is a mirror of the repository at https://github.com/golang/go.
Unless otherwise noted, the Go source files are distributed under the BSD-style license found in the LICENSE file.
Download and Install
Binary Distributions
Official binary distributions are available at https://go.dev/dl/.
After downloading a binary release, visit https://go.dev/doc/install for installation instructions.
Install From Source
If a binary distribution is not available for your combination of operating system and architecture, visit https://go.dev/doc/install/source for source installation instructions.
Contributing
Go is the work of thousands of contributors. We appreciate your help!
To contribute, please read the contribution guidelines at https://go.dev/doc/contribute.
Note that the Go project uses the issue tracker for bug reports and proposals only. See https://go.dev/wiki/Questions for a list of places to ask questions about the Go language.