1
0
mirror of https://github.com/golang/go synced 2024-11-18 05:04:47 -07:00
go/internal/lsp
Heschi Kreinick 2db8f0ff89 internal/lsp/cache: fix -mod=mod for workspace module setups
When we're in workspace module mode, there may not be a go.mod at the
root of the workspace, so checking modURI != "" doesn't tell us whether
module mode is on. Add a flag to workspaceMode which is exactly that.

There are probably many more places that should be updated, but since
the design is in flux I don't want to cause more churn than necessary.
This is enough to unblock -mod=readonly by default.

(I missed this in CL 253799 because I was running the wrong Go Version.)

Change-Id: I718ee44c7a2547c90f9d62393aba390c9b4b0f46
Reviewed-on: https://go-review.googlesource.com/c/tools/+/254756
Trust: Heschi Kreinick <heschi@google.com>
Run-TryBot: Heschi Kreinick <heschi@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Rebecca Stambler <rstambler@golang.org>
2020-09-15 17:38:23 +00:00
..
analysis internal/lsp/analysis: update fillreturns title 2020-09-08 15:52:18 +00:00
browser
cache internal/lsp/cache: fix -mod=mod for workspace module setups 2020-09-15 17:38:23 +00:00
cmd gopls/doc: generate settings JSON, docs 2020-09-09 20:53:33 +00:00
debug internal/lsp: fix builds and tests for go1.12+ 2020-08-27 14:30:46 +00:00
diff internal/testenv: check that external 'diff' tool is the GNU version 2020-05-08 20:46:49 +00:00
fake internal/lsp/cache: automatically construct the workspace module 2020-09-11 04:00:25 +00:00
fuzzy internal/lsp/fuzzy: fix return value on no match 2020-08-28 15:37:48 +00:00
helper
lsprpc internal/lsp/lsprpc: make the LSP forwarder exit error clearer 2020-09-01 17:31:45 +00:00
mod gopls/doc: generate settings JSON, docs 2020-09-09 20:53:33 +00:00
protocol internal/lsp/protocol: add support for upcoming LSP 3.16 2020-09-11 12:00:08 +00:00
snippet
source internal/lsp/source: fix panic in addFieldItems 2020-09-14 15:58:11 +00:00
testdata internal/lsp: break up fillstruct testdata to make it more manageable 2020-09-08 20:59:11 +00:00
tests internal/lsp: handle staticcheck in didChangeConfiguration 2020-09-13 03:21:22 +00:00
call_hierarchy.go internal/lsp: release resources for call hierarchy file requests 2020-08-07 21:04:51 +00:00
code_action.go internal/lsp: handle staticcheck in code actions 2020-09-14 16:17:55 +00:00
code_lens.go gopls/doc: generate settings JSON, docs 2020-09-09 20:53:33 +00:00
command.go internal/lsp: use -json for module upgrades 2020-09-01 17:31:32 +00:00
completion_test.go gopls/doc: generate settings JSON, docs 2020-09-09 20:53:33 +00:00
completion.go internal/lsp: add more tests for package completion 2020-09-09 17:18:21 +00:00
definition.go internal/lsp/cache: ref-count snapshots 2020-08-03 22:08:54 +00:00
diagnostics.go internal/lsp: add support for RelatedInformation in diagnostics 2020-09-04 18:57:47 +00:00
folding_range.go internal/lsp/cache: ref-count snapshots 2020-08-03 22:08:54 +00:00
format.go internal/lsp/cache: ref-count snapshots 2020-08-03 22:08:54 +00:00
general.go internal/lsp: run gopls as long as there is one folder with a file URI 2020-09-02 01:26:52 +00:00
highlight.go internal/lsp/cache: ref-count snapshots 2020-08-03 22:08:54 +00:00
hover.go internal/lsp/cache: ref-count snapshots 2020-08-03 22:08:54 +00:00
implementation.go internal/lsp/cache: ref-count snapshots 2020-08-03 22:08:54 +00:00
link.go internal/lsp/cache: don't always type check in default mode 2020-08-19 19:22:15 +00:00
lsp_test.go internal/lsp: clean up some of the mod code lens code 2020-09-02 16:06:48 +00:00
progress_test.go internal/lsp: improvements for command messages 2020-08-21 20:07:30 +00:00
progress.go internal/lsp: improvements for command messages 2020-08-21 20:07:30 +00:00
references.go internal/lsp/cache: ref-count snapshots 2020-08-03 22:08:54 +00:00
rename.go internal/lsp/cache: ref-count snapshots 2020-08-03 22:08:54 +00:00
reset_golden.sh
server_gen.go internal/lsp/protocol: add support for upcoming LSP 3.16 2020-09-11 12:00:08 +00:00
server.go internal/lsp/protocol: add support for upcoming LSP 3.16 2020-09-11 12:00:08 +00:00
signature_help.go internal/lsp/cache: ref-count snapshots 2020-08-03 22:08:54 +00:00
symbols.go internal/lsp/cache: ref-count snapshots 2020-08-03 22:08:54 +00:00
text_synchronization.go internal/lsp: check file kind before showing warning 2020-09-15 03:16:44 +00:00
workspace_symbol.go internal/lsp/source: add a new symbolStyle configuration option 2020-06-26 17:13:37 +00:00
workspace.go internal/memoize: switch from GC-driven to explicit deletion 2020-08-10 19:02:17 +00:00