mirror of
https://github.com/golang/go
synced 2024-11-19 00:54:42 -07:00
2b48cfca08
errchk is itself a FAIL: it doesn't exit non-zero on error! R=golang-dev, iant CC=golang-dev https://golang.org/cl/9842044
68 lines
1.6 KiB
Go
68 lines
1.6 KiB
Go
// Copyright 2013 The Go Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
package main_test
|
|
|
|
import (
|
|
"os"
|
|
"os/exec"
|
|
"path/filepath"
|
|
"runtime"
|
|
"testing"
|
|
)
|
|
|
|
const (
|
|
dataDir = "testdata"
|
|
binary = "testvet"
|
|
)
|
|
|
|
// Run this shell script, but do it in Go so it can be run by "go test".
|
|
// go build -o testvet
|
|
// $(GOROOT)/test/errchk ./testvet -printfuncs='Warn:1,Warnf:1' testdata/*.go testdata/*.s
|
|
// rm testvet
|
|
//
|
|
func TestVet(t *testing.T) {
|
|
// Windows systems can't be guaranteed to have Perl and so can't run errchk.
|
|
if runtime.GOOS == "windows" {
|
|
t.Skip("skipping test; no Perl on Windows")
|
|
}
|
|
|
|
// go build
|
|
cmd := exec.Command("go", "build", "-o", binary)
|
|
run(cmd, t)
|
|
|
|
// defer removal of vet
|
|
defer os.Remove(binary)
|
|
|
|
// errchk ./testvet
|
|
gos, err := filepath.Glob(filepath.Join(dataDir, "*.go"))
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
asms, err := filepath.Glob(filepath.Join(dataDir, "*.s"))
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
files := append(gos, asms...)
|
|
errchk := filepath.Join(runtime.GOROOT(), "test", "errchk")
|
|
flags := []string{
|
|
binary,
|
|
"-printfuncs=Warn:1,Warnf:1",
|
|
}
|
|
cmd = exec.Command(errchk, append(flags, files...)...)
|
|
if !run(cmd, t) {
|
|
t.Fatal("vet command failed")
|
|
}
|
|
}
|
|
|
|
func run(c *exec.Cmd, t *testing.T) bool {
|
|
output, err := c.CombinedOutput()
|
|
os.Stderr.Write(output)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
// Errchk delights by not returning non-zero status if it finds errors, so we look at the output.
|
|
return c.ProcessState.Success() && len(output) == 0
|
|
}
|