1
0
mirror of https://github.com/golang/go synced 2024-11-19 02:24:41 -07:00
go/internal/lsp/source
Rohan Challa 55b754b4e0 internal/lsp: fix active param in signature help
This change adjusts where the start and end of the arguments list are when determining which parameter is the active paramter. Rather than use the first and last argument's position, we will use the start and ending parentheses.

Fixes golang/go#37271

Change-Id: I70bc5c8b4bdb5242fc35a20e63b9a8860cb1d6bd
Reviewed-on: https://go-review.googlesource.com/c/tools/+/221817
Run-TryBot: Rohan Challa <rohan@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Rebecca Stambler <rstambler@golang.org>
2020-03-03 19:47:17 +00:00
..
comment_test.go internal/lsp: convert comments to markdown before sending to client 2019-10-04 18:35:38 +00:00
comment.go internal/lsp: convert comments to markdown before sending to client 2019-10-04 18:35:38 +00:00
completion_builtin.go internal/lsp/source: untangle completion type comparison 2020-02-24 18:12:40 +00:00
completion_format.go internal/span,lsp: disambiguate URIs, DocumentURIs, and paths 2020-02-14 22:51:03 +00:00
completion_keywords.go internal/lsp/source: improve completions at file scope 2020-02-20 22:48:06 +00:00
completion_labels.go internal/lsp: sort by label after score 2019-12-30 21:11:21 +00:00
completion_literal.go internal/lsp/source: untangle completion type comparison 2020-02-24 18:12:40 +00:00
completion_snippet.go internal/lsp: merge completion options into source.Options 2020-01-13 20:09:44 +00:00
completion.go internal/lsp/source: fix completion crash with untyped assignee 2020-03-02 21:29:26 +00:00
deep_completion.go internal/lsp/source: improve completion involving multiple return values 2020-02-06 05:07:08 +00:00
diagnostics.go internal/lsp: fix concurrent map read/write for missingmodules 2020-03-03 19:46:16 +00:00
folding_range.go internal/lsp/cache: add file contents to ParseGoHandle 2020-02-13 05:05:14 +00:00
format_test.go internal/lsp/source: trim file very carefully 2020-01-17 20:34:13 +00:00
format.go internal/lsp: fix diagnostics not clearing when creating new files 2020-02-13 21:50:53 +00:00
highlight.go internal/lsp/cache: add file contents to ParseGoHandle 2020-02-13 05:05:14 +00:00
hover.go internal/lsp: support textDocument/hover for .mod extension 2020-02-26 15:59:49 +00:00
identifier.go internal/lsp/cache: add file contents to ParseGoHandle 2020-02-13 05:05:14 +00:00
implementation.go internal/lsp/source: support inverse "implementations" 2020-03-02 21:28:54 +00:00
options.go internal/lsp: add codelens for go.mod dependency upgrades 2020-02-14 14:15:08 +00:00
references.go internal/lsp: don't return references for builtins 2020-02-06 19:49:06 +00:00
rename_check.go internal/lsp: improve literal func completion candidates 2019-11-07 21:18:00 +00:00
rename.go internal/lsp: permit renaming symbols declared in other packages 2020-01-27 18:56:10 +00:00
signature_help.go internal/lsp: fix active param in signature help 2020-03-03 19:47:17 +00:00
source_test.go internal/lsp: add an upgrade all dependencies codelens 2020-03-02 21:30:18 +00:00
symbols.go internal/lsp/cache: add file contents to ParseGoHandle 2020-02-13 05:05:14 +00:00
util.go internal/lsp/source: untangle completion type comparison 2020-02-24 18:12:40 +00:00
view.go internal/lsp: support textDocument/hover for .mod extension 2020-02-26 15:59:49 +00:00
workspace_symbol.go internal/lsp/source: limit WorkspaceSymbols results 2020-02-25 21:59:15 +00:00