1
0
mirror of https://github.com/golang/go synced 2024-11-18 10:54:40 -07:00
go/internal/lsp
Rebecca Stambler 2ad651e9e2 internal/lsp: handle bad formatting with CRLF line endings
The importPrefix logic is complicated by Windows line endings, since
go/ast isn't aware of different line endings in comment text. I made a
few changes to the way that import prefixes are computed to handle this.

Specifically, for comments, we try to make sure the range ends on a full
line as much as possible, because that addresses the line ending issue.

Fixes golang/go#40355

Change-Id: I84c1cfa0d0bae532e52ed181e8a5383157feef24
Reviewed-on: https://go-review.googlesource.com/c/tools/+/244897
Run-TryBot: Rebecca Stambler <rstambler@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Heschi Kreinick <heschi@google.com>
2020-07-28 16:05:17 +00:00
..
analysis internal/lsp: allow narrower scope for convenience CodeActions 2020-07-27 23:36:28 +00:00
browser
cache internal/lsp: correctly marshal arguments for upgrade code lens 2020-07-27 21:52:59 +00:00
cmd internal/lsp: move undeclaredname suggested fix out of analysis 2020-07-23 23:54:27 +00:00
debug internal/lsp/lsprpc: improvements to daemon logging 2020-07-16 19:33:22 +00:00
diff internal/testenv: check that external 'diff' tool is the GNU version 2020-05-08 20:46:49 +00:00
fake internal/lsp: correctly invalidate metadata for batched changes 2020-07-27 19:55:46 +00:00
fuzzy internal/lsp: fix errors found by staticcheck 2020-03-19 19:20:54 +00:00
helper internal/lsp: change to helper.go to output a formatted file 2020-01-31 20:35:38 +00:00
lsprpc internal/lsp/fake: move to a struct for configuring the sandbox 2020-07-23 23:36:26 +00:00
mod internal/lsp: correctly marshal arguments for upgrade code lens 2020-07-27 21:52:59 +00:00
protocol internal/lsp: update code for LSP protocol 2020-07-28 15:42:44 +00:00
regtest internal/lsp: correctly marshal arguments for upgrade code lens 2020-07-27 21:52:59 +00:00
snippet
source internal/lsp: handle bad formatting with CRLF line endings 2020-07-28 16:05:17 +00:00
testdata internal/lsp: support return statements in extract function 2020-07-28 16:04:03 +00:00
tests internal/lsp: support refactor.extract through commands 2020-07-27 19:25:51 +00:00
code_action.go internal/lsp: allow narrower scope for convenience CodeActions 2020-07-27 23:36:28 +00:00
code_lens.go internal/lsp: change the way that we pass arguments to command 2020-07-21 16:30:27 +00:00
command.go internal/lsp: correctly marshal arguments for upgrade code lens 2020-07-27 21:52:59 +00:00
completion_test.go internal/lsp/source: offer smart "append()" completions 2020-05-20 22:05:37 +00:00
completion.go internal/lsp: remove VS Code-specific completion hack 2020-06-30 15:48:51 +00:00
definition.go internal/lsp: read files eagerly 2020-06-11 22:11:59 +00:00
diagnostics.go internal/lsp: treat the module root as the workspace root, if available 2020-07-23 21:33:49 +00:00
folding_range.go internal/lsp: read files eagerly 2020-06-11 22:11:59 +00:00
format.go internal/lsp: read files eagerly 2020-06-11 22:11:59 +00:00
general.go internal/lsp: fix GlobPattern for watching files 2020-07-25 20:09:36 +00:00
highlight.go internal/lsp: read files eagerly 2020-06-11 22:11:59 +00:00
hover.go internal/lsp: read files eagerly 2020-06-11 22:11:59 +00:00
implementation.go internal/lsp: read files eagerly 2020-06-11 22:11:59 +00:00
link.go internal/lsp: add an importShortcut configuration 2020-07-15 23:00:36 +00:00
lsp_test.go internal/lsp: support refactor.extract through commands 2020-07-27 19:25:51 +00:00
progress.go internal/lsp: change the way that we pass arguments to command 2020-07-21 16:30:27 +00:00
references.go internal/lsp: read files eagerly 2020-06-11 22:11:59 +00:00
rename.go internal/lsp: read files eagerly 2020-06-11 22:11:59 +00:00
reset_golden.sh
server_gen.go internal/lsp: update code for LSP protocol 2020-07-28 15:42:44 +00:00
server.go internal/lsp: change the way that we pass arguments to command 2020-07-21 16:30:27 +00:00
signature_help.go internal/lsp: read files eagerly 2020-06-11 22:11:59 +00:00
symbols.go internal/lsp: read files eagerly 2020-06-11 22:11:59 +00:00
text_synchronization.go internal/lsp: don't keep track of closed overlays 2020-07-16 17:49:00 +00:00
workspace_symbol.go internal/lsp/source: add a new symbolStyle configuration option 2020-06-26 17:13:37 +00:00
workspace.go gopls, internal/lsp: support an extra formatting hook for gofumpt 2020-07-13 21:42:47 +00:00