1
0
mirror of https://github.com/golang/go synced 2024-09-29 22:14:29 -06:00
go/src
Alexander Yastrebov 291a32aa4b net/http: fix request canceler leak on connection close
Due to a race condition persistConn could be closed without removing request canceler.

Note that without the fix test occasionally passes and to demonstrate the issue it has to be run multiple times, e.g. using -count=10.

Fixes #61708

Change-Id: I9029d7d65cf602dd29ee1b2a87a77a73e99d9c92
GitHub-Last-Rev: 6b31f9826d
GitHub-Pull-Request: golang/go#61745
Reviewed-on: https://go-review.googlesource.com/c/go/+/515796
Reviewed-by: Bryan Mills <bcmills@google.com>
Reviewed-by: Damien Neil <dneil@google.com>
Run-TryBot: Bryan Mills <bcmills@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
2023-08-22 22:22:23 +00:00
..
archive archive/tar: correct value passed to Uname method 2023-08-10 14:37:50 +00:00
arena
bufio bufio: clarify the maximum token size 2023-08-16 02:07:18 +00:00
builtin
bytes bytes: remove builders check from compare test 2023-07-13 23:11:42 +00:00
cmd cmd/go: retry ETXTBSY errors when running test binaries 2023-08-22 22:09:34 +00:00
cmp
compress
container
context context: fix synchronization in ExampleAfterFunc_cond 2023-08-21 20:24:28 +00:00
crypto crypto/internal/bigmod: provide assembly addMulVVW* for riscv64 2023-08-15 07:52:41 +00:00
database/sql database/sql: use reflect.TypeFor for known types 2023-08-08 20:57:57 +00:00
debug debug/buildinfo: read full data segment to lookup buildinfo magic 2023-07-31 18:36:20 +00:00
embed
encoding encoding/csv: correct Column docs 2023-08-19 23:05:33 +00:00
errors errors: optimize Is and As by reusing reflection of target 2023-08-18 23:40:44 +00:00
expvar expvar: emit valid JSON strings 2023-08-19 23:26:49 +00:00
flag
fmt fmt: amend comment for getField 2023-08-17 16:33:59 +00:00
go go/types, types2: disable interface inference for versions before Go 1.21 2023-08-17 23:33:10 +00:00
hash
html text/template, html/template: use reflect.TypeFor for known types 2023-08-01 14:30:25 +00:00
image encoding/xml, image/jpeg, image/png: use the builtin min function 2023-08-07 00:23:29 +00:00
index/suffixarray
internal go/types, types2: disable interface inference for versions before Go 1.21 2023-08-17 23:33:10 +00:00
io io: reduce allocations in Pipe constructor 2023-08-17 16:25:48 +00:00
log log/slog: rename receiver name for the Value struct from a to v 2023-08-17 21:35:14 +00:00
maps maps: remove Keys and Values 2023-07-26 21:40:38 +00:00
math math/big, math/rand: use the built-in max function 2023-08-17 16:42:19 +00:00
mime
net net/http: fix request canceler leak on connection close 2023-08-22 22:22:23 +00:00
os os/exec: don't convert byte slice to string when using verb %s 2023-08-21 23:20:06 +00:00
path path/filepath: don't drop .. elements when cleaning invalid Windows paths 2023-08-08 21:48:12 +00:00
plugin
reflect reflect: update Type.FieldByName documentation 2023-08-02 15:25:06 +00:00
regexp regexp/syntax: use more compact Regexp.String output 2023-08-16 16:02:30 +00:00
runtime runtime/cgo: get getstackbound for set_stacklo 2023-08-22 22:06:46 +00:00
slices slices: simplify Clone a bit 2023-08-20 04:12:09 +00:00
sort sort: use the builtin min function 2023-08-07 18:49:55 +00:00
strconv strconv: rely on utf8.AppendRune 2023-08-17 05:23:49 +00:00
strings strings: use the builtin max function 2023-08-07 18:49:51 +00:00
sync sync: document why copyChecker checks the condition twice 2023-08-16 15:36:31 +00:00
syscall syscall: add support for openbsd/ppc64 2023-08-22 03:24:15 +00:00
testdata
testing internal/sysinfo: print cpu type from cpuinfo when internal cpu name is empty on Linux 2023-08-17 21:40:36 +00:00
text text/template: use "IsValid" instead of "!= zero" to compare zero Value 2023-08-03 15:59:13 +00:00
time time: make Duration.String inlineable 2023-08-18 23:45:44 +00:00
unicode
unsafe
vendor all: update vendored dependencies 2023-08-09 21:28:32 +00:00
all.bash
all.bat
all.rc
bootstrap.bash
buildall.bash src/buildall.bash: mention no longer being used by Go build system 2023-07-27 17:32:27 +00:00
clean.bash
clean.bat
clean.rc
cmp.bash cmp.bash: fix comment grammar 2023-07-20 18:03:31 +00:00
go.mod all: update vendored dependencies 2023-08-09 21:28:32 +00:00
go.sum all: update vendored dependencies 2023-08-09 21:28:32 +00:00
make.bash make.bash,bat,rc: use Go 1.20.6 instead of Go 1.17.13 2023-07-24 02:49:20 +00:00
make.bat make.bash,bat,rc: use Go 1.20.6 instead of Go 1.17.13 2023-07-24 02:49:20 +00:00
Make.dist
make.rc make.bash,bat,rc: use Go 1.20.6 instead of Go 1.17.13 2023-07-24 02:49:20 +00:00
race.bash
race.bat
README.vendor src/README.vendor: s/latest/master/ 2023-07-11 21:30:51 +00:00
run.bash
run.bat
run.rc

Vendoring in std and cmd
========================

The Go command maintains copies of external packages needed by the
standard library in the src/vendor and src/cmd/vendor directories.

There are two modules, std and cmd, defined in src/go.mod and
src/cmd/go.mod. When a package outside std or cmd is imported
by a package inside std or cmd, the import path is interpreted
as if it had a "vendor/" prefix. For example, within "crypto/tls",
an import of "golang.org/x/crypto/cryptobyte" resolves to
"vendor/golang.org/x/crypto/cryptobyte". When a package with the
same path is imported from a package outside std or cmd, it will
be resolved normally. Consequently, a binary may be built with two
copies of a package at different versions if the package is
imported normally and vendored by the standard library.

Vendored packages are internally renamed with a "vendor/" prefix
to preserve the invariant that all packages have distinct paths.
This is necessary to avoid compiler and linker conflicts. Adding
a "vendor/" prefix also maintains the invariant that standard
library packages begin with a dotless path element.

The module requirements of std and cmd do not influence version
selection in other modules. They are only considered when running
module commands like 'go get' and 'go mod vendor' from a directory
in GOROOT/src.

Maintaining vendor directories
==============================

Before updating vendor directories, ensure that module mode is enabled.
Make sure that GO111MODULE is not set in the environment, or that it is
set to 'on' or 'auto'.

Requirements may be added, updated, and removed with 'go get'.
The vendor directory may be updated with 'go mod vendor'.
A typical sequence might be:

    cd src
    go get golang.org/x/net@master
    go mod tidy
    go mod vendor

Use caution when passing '-u' to 'go get'. The '-u' flag updates
modules providing all transitively imported packages, not only
the module providing the target package.

Note that 'go mod vendor' only copies packages that are transitively
imported by packages in the current module. If a new package is needed,
it should be imported before running 'go mod vendor'.