mirror of
https://github.com/golang/go
synced 2024-11-14 09:00:21 -07:00
00b773a4a9
Previously, we would recognize &(T{...}) expressions during type
checking, rewrite them into (*T){...}, and then do a lot of extra work
to make sure the user doesn't write (*T){...} themselves and
resynthesizing the OPTRLIT later on.
This CL simply handles &T{...} directly in the straight forward
manner, by changing OADDR directly to OPTRLIT when appropriate.
While here, match go/types's invalid composite literal type error
message.
Passes toolstash-check.
Change-Id: I902b14c7e2cd9fa93e6915dd58272d2352ba38f8
Reviewed-on: https://go-review.googlesource.com/c/go/+/197120
Run-TryBot: Matthew Dempsky <mdempsky@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Robert Griesemer <gri@golang.org>
66 lines
1.5 KiB
Go
66 lines
1.5 KiB
Go
// errorcheck
|
|
|
|
// Copyright 2011 The Go Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
// Verify that illegal composite literals are detected.
|
|
// Does not compile.
|
|
|
|
package main
|
|
|
|
var m map[int][3]int
|
|
|
|
func f() [3]int
|
|
|
|
func fp() *[3]int
|
|
|
|
var mp map[int]*[3]int
|
|
|
|
var (
|
|
_ = [3]int{1, 2, 3}[:] // ERROR "slice of unaddressable value"
|
|
_ = m[0][:] // ERROR "slice of unaddressable value"
|
|
_ = f()[:] // ERROR "slice of unaddressable value"
|
|
|
|
_ = 301[:] // ERROR "cannot slice"
|
|
_ = 3.1[:] // ERROR "cannot slice"
|
|
_ = true[:] // ERROR "cannot slice"
|
|
|
|
// these are okay because they are slicing a pointer to an array
|
|
_ = (&[3]int{1, 2, 3})[:]
|
|
_ = mp[0][:]
|
|
_ = fp()[:]
|
|
)
|
|
|
|
type T struct {
|
|
i int
|
|
f float64
|
|
s string
|
|
next *T
|
|
}
|
|
|
|
type TP *T
|
|
type Ti int
|
|
|
|
var (
|
|
_ = &T{0, 0, "", nil} // ok
|
|
_ = &T{i: 0, f: 0, s: "", next: {}} // ERROR "missing type in composite literal|omit types within composite literal"
|
|
_ = &T{0, 0, "", {}} // ERROR "missing type in composite literal|omit types within composite literal"
|
|
_ = TP{i: 0, f: 0, s: "", next: {}} // ERROR "invalid composite literal type TP"
|
|
_ = &Ti{} // ERROR "invalid composite literal type Ti"
|
|
)
|
|
|
|
type M map[T]T
|
|
|
|
var (
|
|
_ = M{{i:1}: {i:2}}
|
|
_ = M{T{i:1}: {i:2}}
|
|
_ = M{{i:1}: T{i:2}}
|
|
_ = M{T{i:1}: T{i:2}}
|
|
)
|
|
|
|
type S struct { s [1]*M1 }
|
|
type M1 map[S]int
|
|
var _ = M1{{s:[1]*M1{&M1{{}:1}}}:2}
|
|
|