1
0
mirror of https://github.com/golang/go synced 2024-11-18 23:14:43 -07:00
go/internal/lsp/testdata
Muir Manders cf2d1e09c8 internal/lsp/source: offer smart "append()" completions
Assigning a slice to the appendage of itself is common and tedious
enough to warrant a special case completion candidate. We now offer
smarter "append()" candidates:

    var foo []int
    foo = app<> // offer "append(foo, <>)"
    fo<> // offer "foo = append(foo, <>)"

The latter is only offered if the best completion candidate is a
slice. It is inserted as the second-best candidate because it seems
impossible to avoid annoying false positives if it is ranked first.

I added a new debug option to disable literal completions. This was to
clean up some test logic that was disabling snippets for all tests
just to defeat literal completions. My tests were failing mysteriously
due to having snippets disabled, and it was hard to figure out why.

Change-Id: I3e8313e00a1409840cb99d5d71c593435a7aeb71
Reviewed-on: https://go-review.googlesource.com/c/tools/+/221777
Run-TryBot: Muir Manders <muir@mnd.rs>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Rebecca Stambler <rstambler@golang.org>
2020-05-20 22:05:37 +00:00
..
indirect internal/lsp/cmd: improve flexibility of suggested fixes 2020-03-06 14:31:35 +00:00
lsp internal/lsp/source: offer smart "append()" completions 2020-05-20 22:05:37 +00:00
missingdep internal/lsp/cmd: improve flexibility of suggested fixes 2020-03-06 14:31:35 +00:00
missingtwodep internal/lsp/cmd: improve flexibility of suggested fixes 2020-03-06 14:31:35 +00:00
unused internal/lsp/cmd: improve flexibility of suggested fixes 2020-03-06 14:31:35 +00:00
upgradedep gopls: update dependencies in the go.mod 2020-05-18 20:39:08 +00:00