1
0
mirror of https://github.com/golang/go synced 2024-11-19 00:54:42 -07:00
go/src
Jay Conrod 24781a1faf cmd/go: fix link error for -coverpkg in GOPATH mode
If a generated test main package transitively depends on a main
package, the main package will now always be rebuilt as a library and
will not be compiled with '-p main'.

This expands the fix for #30907, which only applied to packages with
the BuildInfo set (main packages built in module mode). Linking
multiple packages with BuildInfo caused link errors, but it appears
these errors apply to some symbols in GOPATH mode.

Fixes #34114

Change-Id: Ic1e53437942269a950dd7e45d163707922c92edd
Reviewed-on: https://go-review.googlesource.com/c/go/+/195279
Run-TryBot: Jay Conrod <jayconrod@google.com>
Reviewed-by: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
2019-09-13 16:25:00 +00:00
..
archive archive/zip: remove unused special case 2019-08-27 17:00:43 +00:00
bufio
builtin
bytes bytes/hash: disable seed test on 32-bit platforms 2019-09-03 19:37:16 +00:00
cmd cmd/go: fix link error for -coverpkg in GOPATH mode 2019-09-13 16:25:00 +00:00
compress compress/lzw: fix comment re high-code invariant 2019-09-12 07:45:53 +00:00
container
context all: remove os.ErrTimeout 2019-08-02 17:57:18 +00:00
crypto src: gofmt -s 2019-09-09 18:57:05 +00:00
database/sql all: fix typos 2019-09-08 17:28:20 +00:00
debug src: gofmt -s 2019-09-09 18:57:05 +00:00
encoding encoding/json: encode nil encoding.TextMarshaler instance as "null" 2019-09-11 18:37:43 +00:00
errors errors: clarify docs for when As returns false 2019-09-06 00:03:32 +00:00
expvar all: change some function documentation to be more idiomatic 2019-07-28 18:09:57 +00:00
flag
fmt doc/go1.13: document fmt's number syntax updates 2019-08-23 23:40:29 +00:00
go go/types: fix iota undefined after ConstDecl inside function in ConstSpec 2019-09-12 04:15:00 +00:00
hash
html html/template: micro optimization for isJSType 2019-08-27 17:41:33 +00:00
image all: fix typos 2019-09-08 17:28:20 +00:00
index/suffixarray
internal reflect: enhance docs for IsZero and IsValid 2019-09-11 00:16:10 +00:00
io io/ioutil: don't check for short write in WriteFile 2019-09-01 02:31:50 +00:00
log log/syslog: skip unsupported tests on iOS 2019-09-07 21:44:30 +00:00
math all: fix typos 2019-09-08 17:28:20 +00:00
mime mime: update type of .js and .mjs files to text/javascript 2019-09-01 10:08:53 +00:00
net all: fix typos 2019-09-08 17:28:20 +00:00
os src: gofmt -s 2019-09-09 18:57:05 +00:00
path path: improve documentation to call out cases where Clean is called 2019-09-09 22:56:39 +00:00
plugin plugin: add freebsd/amd64 plugin support 2019-09-03 14:27:24 +00:00
reflect reflect: fix panic in DeepEqual when checking a cycle 2019-09-11 00:56:01 +00:00
regexp regexp: add example for NumSubexp 2019-09-10 20:33:25 +00:00
runtime cmd/go/internal/renameio,runtime: avoid leaking temp directory in test 2019-09-12 15:52:35 +00:00
sort
strconv strconv: Speed improvement to number parsing 2019-08-28 03:23:59 +00:00
strings strings: clarify usage of Title and ToTitle 2019-07-30 02:52:57 +00:00
sync
syscall syscall: implement rawVforkSyscall for linux/arm64 2019-09-11 07:19:55 +00:00
testdata
testing Revert "cmd/go: move automatic testing.Init call into generated test code" 2019-07-22 21:42:51 +00:00
text text/template: refer to sorted map keys as "ordered" not "comparable" in docs 2019-09-06 21:22:26 +00:00
time time: update TestSub to avoid future regressions 2019-08-16 19:54:57 +00:00
unicode
unsafe
vendor net/http: update bundled golang.org/x/net/http2 to import security fix 2019-08-23 17:03:17 +00:00
all.bash
all.bat
all.rc
bootstrap.bash
buildall.bash
clean.bash
clean.bat
clean.rc
cmp.bash
go.mod net/http: update bundled golang.org/x/net/http2 to import security fix 2019-08-23 17:03:17 +00:00
go.sum net/http: update bundled golang.org/x/net/http2 to import security fix 2019-08-23 17:03:17 +00:00
iostest.bash
make.bash
make.bat
Make.dist
make.rc
naclmake.bash
nacltest.bash
race.bash
race.bat
README.vendor all: update 'go get' command in standard library README.vendor 2019-08-23 21:07:49 +00:00
run.bash
run.bat
run.rc

Vendoring in std and cmd
========================

The Go command maintains copies of external packages needed by the
standard library in the src/vendor and src/cmd/vendor directories.

In GOPATH mode, imports of vendored packages are resolved to these
directories following normal vendor directory logic
(see golang.org/s/go15vendor).

In module mode, std and cmd are modules (defined in src/go.mod and
src/cmd/go.mod). When a package outside std or cmd is imported
by a package inside std or cmd, the import path is interpreted
as if it had a "vendor/" prefix. For example, within "crypto/tls",
an import of "golang.org/x/crypto/cryptobyte" resolves to
"vendor/golang.org/x/crypto/cryptobyte". When a package with the
same path is imported from a package outside std or cmd, it will
be resolved normally. Consequently, a binary may be built with two
copies of a package at different versions if the package is
imported normally and vendored by the standard library.

Vendored packages are internally renamed with a "vendor/" prefix
to preserve the invariant that all packages have distinct paths.
This is necessary to avoid compiler and linker conflicts. Adding
a "vendor/" prefix also maintains the invariant that standard
library packages begin with a dotless path element.

The module requirements of std and cmd do not influence version
selection in other modules. They are only considered when running
module commands like 'go get' and 'go mod vendor' from a directory
in GOROOT/src.

Maintaining vendor directories
==============================

Before updating vendor directories, ensure that module mode is enabled.
Make sure GO111MODULE=off is not set ('on' or 'auto' should work).

Requirements may be added, updated, and removed with 'go get'.
The vendor directory may be updated with 'go mod vendor'.
A typical sequence might be:

    cd src
    go get -d golang.org/x/net@latest
    go mod tidy
    go mod vendor

Use caution when passing '-u' to 'go get'. The '-u' flag updates
modules providing all transitively imported packages, not only
the module providing the target package.

Note that 'go mod vendor' only copies packages that are transitively
imported by packages in the current module. If a new package is needed,
it should be imported before running 'go mod vendor'.