1
0
mirror of https://github.com/golang/go synced 2024-09-29 16:24:28 -06:00
go/misc/cgo
Bryan C. Mills 39a9cb4b5d misc/cgo/testplugin: avoid writing to GOROOT
One of the 'go build' commands executed by this test passed the '-i'
flag, which caused the 'go' command to attempt to install transitive
standard-library dependencies to GOROOT/pkg/$GOOS_$GOARCH_dynlink.

That failed if GOROOT/pkg was not writable (for example, if GOROOT was
owned by the root user, but the user running the test was not root).

As far as I can tell the '-i' flag is not necessary in this test.
Prior to the introduction of the build cache it may have been an
optimization, but now that the build cache is required the '-i' flag
only adds extra work.

Updates #30316

Change-Id: Ib60080a008c1941aa92b5bdd5a194d89fd6202aa
Reviewed-on: https://go-review.googlesource.com/c/go/+/208120
Run-TryBot: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
2019-11-20 22:38:34 +00:00
..
errors cmd/cgo: do not rewrite call if there are more args than parameters 2019-07-12 17:31:29 +00:00
fortran misc/cgo/fortran: avoid writing to $PWD 2019-11-20 22:37:23 +00:00
gmp all: make copyright headers consistent with one space after period 2016-05-02 13:43:18 +00:00
life misc: ensure that test overlay directories are writable 2019-11-11 17:59:46 +00:00
nocgo cmd/ld: really import runtime/cgo for external link 2014-05-20 21:36:50 -07:00
stdio misc: ensure that test overlay directories are writable 2019-11-11 17:59:46 +00:00
test misc: ensure that test overlay directories are writable 2019-11-11 17:59:46 +00:00
testasan runtime: more flexible heap memory mapping on 64-bits 2013-06-12 18:47:16 +04:00
testcarchive misc: ensure that test overlay directories are writable 2019-11-11 17:59:46 +00:00
testcshared cmd/link/internal/ld,misc/cgo/testcshared: don't -fuse-ld=gold on Android 2019-11-14 17:43:48 +00:00
testgodefs misc/cgo/testgodefs: convert test from bash to Go 2019-11-13 20:53:39 +00:00
testplugin misc/cgo/testplugin: avoid writing to GOROOT 2019-11-20 22:38:34 +00:00
testsanitizers runtime: save/restore callee saved registers in arm64's sigtramp 2019-06-03 19:02:11 +00:00
testshared misc: ensure that test overlay directories are writable 2019-11-11 17:59:46 +00:00
testsigfwd misc/cgo/testsigfwd: add missing return statement 2016-08-30 21:44:14 +00:00
testso misc: ensure that test overlay directories are writable 2019-11-11 17:59:46 +00:00
testsovar misc: ensure that test overlay directories are writable 2019-11-11 17:59:46 +00:00
testtls all: make copyright headers consistent with one space after period 2016-05-02 13:43:18 +00:00