1
0
mirror of https://github.com/golang/go synced 2024-09-29 14:24:32 -06:00
go/misc
Bryan C. Mills 39a9cb4b5d misc/cgo/testplugin: avoid writing to GOROOT
One of the 'go build' commands executed by this test passed the '-i'
flag, which caused the 'go' command to attempt to install transitive
standard-library dependencies to GOROOT/pkg/$GOOS_$GOARCH_dynlink.

That failed if GOROOT/pkg was not writable (for example, if GOROOT was
owned by the root user, but the user running the test was not root).

As far as I can tell the '-i' flag is not necessary in this test.
Prior to the introduction of the build cache it may have been an
optimization, but now that the build cache is required the '-i' flag
only adds extra work.

Updates #30316

Change-Id: Ib60080a008c1941aa92b5bdd5a194d89fd6202aa
Reviewed-on: https://go-review.googlesource.com/c/go/+/208120
Run-TryBot: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
2019-11-20 22:38:34 +00:00
..
android misc/android: fix a typo in README 2019-05-17 06:01:17 +00:00
arm
cgo misc/cgo/testplugin: avoid writing to GOROOT 2019-11-20 22:38:34 +00:00
chrome/gophertool misc/chrome/gophertool: replace deprecated tabs.getSelected method 2019-11-18 18:14:37 +00:00
ios misc/ios: bump -mios-version-min 2019-11-05 14:44:56 +00:00
linkcheck
reboot misc: ensure that test overlay directories are writable 2019-11-11 17:59:46 +00:00
swig cmd/go: fix swig support and run swig tests during run.bash 2017-11-16 17:19:19 +00:00
trace all: fix a bunch of misspellings 2019-11-15 21:04:43 +00:00
wasm syscall/js: garbage collect references to JavaScript values 2019-11-04 22:50:43 +00:00
editors
go.mod misc: add go.mod file 2019-02-27 17:47:31 +00:00