Muir Manders 22e91af008 internal/lsp: apply type modifiers to completion candidate ... In situations like: var buf bytes.Buffer var w io.Writer = &b<> if we want to complete to "buf" properly we need to apply the "&" type modifier to buf's type of bytes.Buffer to see that it is assignable to type io.Writer. Previously we applied type modifiers in reverse to the "expected" type (io.Writer in this case), but that is obviously incorrect in this situation since it is nonsensical to dereference (the reverse of "&") io.Writer. Change-Id: Ib7ab5761f625217e023286384c23b8c60e677aac GitHub-Last-Rev: 4be528f2572c9c987334552e3f8a31d4eddce81a GitHub-Pull-Request: golang/tools#121 Reviewed-on: https://go-review.googlesource.com/c/tools/+/182598 Run-TryBot: Rebecca Stambler <rstambler@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>		2019-06-19 20:27:14 +00:00
..
analysis.go	internal/lsp: update analysis runner for new features	2019-06-14 15:20:01 +00:00
completion_format.go	internal/lsp: build the packages config on demand from proper configuration	2019-05-21 17:12:43 +00:00
completion_snippet.go	internal/lsp: build the packages config on demand from proper configuration	2019-05-21 17:12:43 +00:00
completion.go	internal/lsp: apply type modifiers to completion candidate	2019-06-19 20:27:14 +00:00
diagnostics_test.go	internal/span: change URI.Filename so it just returns the filename	2019-06-10 21:39:43 +00:00
diagnostics.go	internal/lsp: add a field on the package to store diagnostics	2019-06-19 16:20:43 +00:00
enums.go	internal/lsp: switch completion item tests to using the enum strings	2019-04-17 17:57:43 +00:00
format.go	internal/lsp: remove source.FileContent	2019-06-06 05:02:23 +00:00
highlight.go	internal/lsp: build the packages config on demand from proper configuration	2019-05-21 17:12:43 +00:00
hover.go	internal/lsp: attach documentation to signature help	2019-06-06 17:46:28 +00:00
identifier.go	internal/lsp: fix references for type switch vars	2019-06-19 18:18:01 +00:00
references.go	internal/lsp: fix references for type switch vars	2019-06-19 18:18:01 +00:00
signature_help.go	internal/lsp: fix some issues with trimming ASTs	2019-06-07 20:08:10 +00:00
source_test.go	internal/span: change URI.Filename so it just returns the filename	2019-06-10 21:39:43 +00:00
symbols.go	internal/lsp: build the packages config on demand from proper configuration	2019-05-21 17:12:43 +00:00
util.go	internal/lsp: suggest completions that satisfy interfaces	2019-06-17 19:08:20 +00:00
view.go	internal/lsp: add a field on the package to store diagnostics	2019-06-19 16:20:43 +00:00