1
0
mirror of https://github.com/golang/go synced 2024-09-30 22:48:32 -06:00
go/internal/lsp/debug
Ian Cottrell 224c947ce5 internal/telemetry: replace TagSet with TagMap and TagPointer
This separates the concerns of tag collections that have to be iterated
and tag collections that need lookup by key.
Also make it so that events just carry a plain slice of tags.
We pass a TagMap down through the exporters and allow it to be
extended on the way.
We no longer need the event.Query method (or the event type)
We now exclusivley use Key as the identity, and no longer have a
common core implementation but just implement it directly in each
type.
This removes some confusion that was causing the same key through
different paths to end up with a different identity.

Change-Id: I61e47adcb397f4ca83dd90342b021dd8e9571ed3
Reviewed-on: https://go-review.googlesource.com/c/tools/+/224278
Run-TryBot: Ian Cottrell <iancottrell@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Emmanuel Odeke <emm.odeke@gmail.com>
2020-03-25 01:00:44 +00:00
..
tag internal/telemetry: switch metrics to use the event system 2020-03-23 14:44:30 +00:00
info.1.11.go internal/lsp/debug: add newlines to debug messages 2019-06-12 17:36:44 +00:00
info.1.12.go internal/lsp/debug: add newlines to debug messages 2019-06-12 17:36:44 +00:00
info.go internal/lsp: print view-specific environment 2020-03-24 20:15:47 +00:00
metrics.go internal/telemetry: replace TagSet with TagMap and TagPointer 2020-03-25 01:00:44 +00:00
rpc.go internal/telemetry: replace TagSet with TagMap and TagPointer 2020-03-25 01:00:44 +00:00
serve_test.go internal/lsp/debug: move all debug state onto the Instance 2020-02-24 22:50:47 +00:00
serve.go internal/telemetry: replace TagSet with TagMap and TagPointer 2020-03-25 01:00:44 +00:00
trace.go internal/telemetry: replace TagSet with TagMap and TagPointer 2020-03-25 01:00:44 +00:00