mirror of
https://github.com/golang/go
synced 2024-11-23 07:10:05 -07:00
6da1661371
We already have and use FixVariadicCall to normalize non-dotted calls to variadic functions elsewhere in the compiler to simplify rewriting of function calls. This CL updates inl.go to use it too. A couple tests need to be updated to (correctly) expect diagnostics about "... argument" instead of a slice literal. This is because inl.go previously failed to set Implicit on the slice literal node. Change-Id: I76bd79b95ae1f16e3b26ff7e9e1c468f538fd1f0 Reviewed-on: https://go-review.googlesource.com/c/go/+/323009 Trust: Matthew Dempsky <mdempsky@google.com> Trust: Dan Scales <danscales@google.com> Run-TryBot: Matthew Dempsky <mdempsky@google.com> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Dan Scales <danscales@google.com>
20 lines
513 B
Go
20 lines
513 B
Go
// errorcheck -0 -m
|
|
|
|
// Copyright 2016 The Go Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
// Test inlining of variadic functions.
|
|
// See issue #18116.
|
|
|
|
package foo
|
|
|
|
func head(xs ...string) string { // ERROR "can inline head" "leaking param: xs to result"
|
|
return xs[0]
|
|
}
|
|
|
|
func f() string { // ERROR "can inline f"
|
|
x := head("hello", "world") // ERROR "inlining call to head" "\.\.\. argument does not escape"
|
|
return x
|
|
}
|