207c53e038
In golang.org/cl/59413, the two-argument behavior of cmd/doc was changed to use findPackage instead of build.Import, meaning that the tool was more consistent and useful. However, it introduced a regression: $ go doc bytes Foo doc: no such package: bytes This is because the directory list search would not find Foo in bytes, and reach the end of the directory list - thus resulting in a "no such package" error, since no directory matched our first argument. Move the "no such package" error out of parseArgs, so that the "loop until something is printed" loop can have control over it. In particular, it is useful to know when we have reached the end of the list without any exact match, yet we did find one package matching "bytes": $ go doc bytes Foo doc: no symbol Foo in package bytes While at it, make the "no such package" error not be fatal so that we may test for it. It is important to have the test, as parseArgs may now return a nil package instead of exiting the entire program, potentially meaning a nil pointer dereference panic. Fixes #22810. Change-Id: I90cc6fd755e2d1675bea6d49a1c13cc18ac9bfb9 Reviewed-on: https://go-review.googlesource.com/78677 Run-TryBot: Daniel Martí <mvdan@mvdan.cc> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Rob Pike <r@golang.org> |
||
|---|---|---|
| .github | ||
| api | ||
| doc | ||
| lib/time | ||
| misc | ||
| src | ||
| test | ||
| .gitattributes | ||
| .gitignore | ||
| AUTHORS | ||
| CONTRIBUTING.md | ||
| CONTRIBUTORS | ||
| favicon.ico | ||
| LICENSE | ||
| PATENTS | ||
| README.md | ||
| robots.txt | ||
The Go Programming Language
Go is an open source programming language that makes it easy to build simple, reliable, and efficient software.
Gopher image by Renee French, licensed under Creative Commons 3.0 Attributions license.
Our canonical Git repository is located at https://go.googlesource.com/go. There is a mirror of the repository at https://github.com/golang/go.
Unless otherwise noted, the Go source files are distributed under the BSD-style license found in the LICENSE file.
Download and Install
Binary Distributions
Official binary distributions are available at https://golang.org/dl/.
After downloading a binary release, visit https://golang.org/doc/install or load doc/install.html in your web browser for installation instructions.
Install From Source
If a binary distribution is not available for your combination of operating system and architecture, visit https://golang.org/doc/install/source or load doc/install-source.html in your web browser for source installation instructions.
Contributing
Go is the work of hundreds of contributors. We appreciate your help!
To contribute, please read the contribution guidelines: https://golang.org/doc/contribute.html
Note that the Go project does not use GitHub pull requests, and that we use the issue tracker for bug reports and proposals only. See https://golang.org/wiki/Questions for a list of places to ask questions about the Go language.