1
0
mirror of https://github.com/golang/go synced 2024-11-18 16:14:46 -07:00
go/internal/lsp/cache
Rob Findley 20370b0cb4 internal/lsp: honor GOPRIVATE in documentLinks and go.mod hovers
Several fixes related to GOPRIVATE handling and links:
 + In Go source, fix links matching GOPRIVATE for external modules.
   Previously, in these cases we'd try to match <mod>@v1.2.3/<suffix>,
   which wasn't the correct input into the GOPRIVATE matching algorithm.
 + Similarly check GOPRIVATE for go.mod require statement hovers.
 + Likewise, for documentLink requests (both mod and source).
 + Move the existing hover regtest to link_test.go, and expand to cover
   all these cases.

Along the way, I encountered a couple apparent bugs, which I fixed:
 + Correctly handle the case where there is only one require in a go.mod
   file. This was exercised by the regtest, so took some debugging.
 + Only format links [like](this) if the requested format is actually
   markdown.

Fixes golang/go#36998

Change-Id: I92011821f646f2a7449dcca619483f83bdeb54b0
Reviewed-on: https://go-review.googlesource.com/c/tools/+/238029
Run-TryBot: Robert Findley <rfindley@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Rebecca Stambler <rstambler@golang.org>
2020-06-18 13:42:42 +00:00
..
analysis.go internal/lsp: fix caching issue with duplicate handles 2020-05-07 19:23:25 +00:00
cache.go internal/lsp/debug: show per-package memory usage 2020-06-12 20:10:52 +00:00
check.go internal/lsp/cache: support minimal module compatibility in GOPATH 2020-06-16 21:57:26 +00:00
error_test.go internal/lsp: refactor error handling code in type-checking 2019-10-21 18:57:46 +00:00
errors.go internal/lsp: read files eagerly 2020-06-11 22:11:59 +00:00
keys.go internal/lsp: decouple client and server debug 2020-06-11 13:49:48 +00:00
load.go internal/lsp: use a new temporary go.mod for every go list call 2020-06-18 02:37:23 +00:00
mod_tidy.go internal/lsp/cache: separate modTidyHandle out of modHandle 2020-06-18 03:14:02 +00:00
mod.go internal/lsp: honor GOPRIVATE in documentLinks and go.mod hovers 2020-06-18 13:42:42 +00:00
os_darwin.go internal/lsp: add a mutex around the view's options 2020-04-02 16:41:49 +00:00
os_windows.go internal/lsp/cache: validate workspace path case 2020-03-27 19:55:53 +00:00
parse.go internal/lsp: read files eagerly 2020-06-11 22:11:59 +00:00
pkg.go internal/lsp: read files eagerly 2020-06-11 22:11:59 +00:00
session.go internal/lsp: cancel the initial workspace load when view shuts down 2020-06-12 18:06:40 +00:00
snapshot.go internal/lsp/cache: separate modTidyHandle out of modHandle 2020-06-18 03:14:02 +00:00
view_test.go internal/lsp/cache: validate workspace path case 2020-03-27 19:55:53 +00:00
view.go internal/lsp: use a new temporary go.mod for every go list call 2020-06-18 02:37:23 +00:00