1
0
mirror of https://github.com/golang/go synced 2024-11-18 16:14:46 -07:00
go/internal/lsp
Rebecca Stambler 1fd976651f internal/lsp: make sure that gofmt -s analyses don't modify AST
The code for `gofmt -s` directly modifies the AST, since the ASTs are
not long-lived. Some of this code made it into our analysis
implementations, causing very strange bugs to manifest. Added a
regression test for this specific case.

Fixes golang/go#38267

Change-Id: I235620adcbf2bbc7027c6d83ff2c7fe74729062e
Reviewed-on: https://go-review.googlesource.com/c/tools/+/227299
Run-TryBot: Rebecca Stambler <rstambler@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Heschi Kreinick <heschi@google.com>
2020-04-06 21:01:14 +00:00
..
analysis internal/lsp: make sure that gofmt -s analyses don't modify AST 2020-04-06 21:01:14 +00:00
browser
cache internal/lsp: temporarily disable type error analyzers by default 2020-04-02 16:54:32 +00:00
cmd internal/jsonrpc2: dont add any handlers by default 2020-04-06 14:44:07 +00:00
debug internal/lsp: make event directly implement TagMap 2020-04-06 17:24:01 +00:00
diff internal/lsp: fix errors found by staticcheck 2020-03-19 19:20:54 +00:00
fake internal/jsonrpc2: dont add any handlers by default 2020-04-06 14:44:07 +00:00
fuzzy internal/lsp: fix errors found by staticcheck 2020-03-19 19:20:54 +00:00
helper internal/lsp: change to helper.go to output a formatted file 2020-01-31 20:35:38 +00:00
lsprpc internal/jsonrpc2: dont add any handlers by default 2020-04-06 14:44:07 +00:00
mod internal/lsp: refactor and propagate errors from code actions 2020-03-31 20:20:46 +00:00
protocol internal/jsonrpc2: dont add any handlers by default 2020-04-06 14:44:07 +00:00
regtest internal/lsp: make sure that gofmt -s analyses don't modify AST 2020-04-06 21:01:14 +00:00
snippet
source internal/lsp: use one context throughout completion 2020-04-06 16:51:37 +00:00
testdata internal/lsp: fix references for transitive dependencies 2020-04-02 20:53:30 +00:00
tests internal/lsp: temporarily disable type error analyzers by default 2020-04-02 16:54:32 +00:00
code_action.go internal/lsp: refactor and propagate errors from code actions 2020-03-31 20:20:46 +00:00
command.go x/tools/gopls: run go generate through CodeLens 2020-03-17 04:34:34 +00:00
completion_test.go internal/span,lsp: disambiguate URIs, DocumentURIs, and paths 2020-02-14 22:51:03 +00:00
completion.go internal/lsp: avoid logging context cancellation 2020-03-31 01:46:33 +00:00
definition.go internal/lsp/source: return location(s) for imported packages 2020-03-09 16:25:02 +00:00
diagnostics.go internal/lsp: add a reg test to test "go mod init" 2020-03-31 02:48:52 +00:00
folding_range.go internal/lsp: check for file URIs on LSP requests 2020-02-14 22:51:26 +00:00
format.go internal/lsp: support textDocument/formatting for .mod extension 2020-03-06 13:51:27 +00:00
general.go internal/lsp: handle non-file:// URIs gracefully 2020-04-02 20:53:07 +00:00
generate.go internal/lsp, go/packages: don't log context cancellation errors 2020-04-03 19:08:13 +00:00
highlight.go internal/lsp: move the telemetry package 2020-03-18 13:22:49 +00:00
hover.go internal/lsp: support textDocument/hover for .mod extension 2020-02-26 15:59:49 +00:00
implementation.go internal/lsp: check for file URIs on LSP requests 2020-02-14 22:51:26 +00:00
link.go internal/lsp: avoid logging context cancellation 2020-03-31 01:46:33 +00:00
lsp_test.go internal/lsp: temporarily disable type error analyzers by default 2020-04-02 16:54:32 +00:00
references.go internal/lsp: refactor references/rename/implementations 2020-03-27 17:09:18 +00:00
rename.go internal/lsp: check for file URIs on LSP requests 2020-02-14 22:51:26 +00:00
reset_golden.sh
server_gen.go x/tools/gopls: add support for $/progress functionality 2020-03-16 21:25:24 +00:00
server.go internal/lsp: stop showing workspace misconfiguration message 2020-03-24 18:23:14 +00:00
signature_help.go internal/telemetry: delete the event.TagOf method 2020-03-18 13:23:15 +00:00
symbols.go internal/lsp: move the telemetry package 2020-03-18 13:22:49 +00:00
text_synchronization.go internal/lsp: fix view rebuilding when go mod init runs 2020-03-30 17:42:33 +00:00
workspace_symbol.go internal/lsp: migrate telemetry to using the event package 2020-03-12 03:59:16 +00:00
workspace.go internal/lsp: generate boilerplate stubs for type Server 2020-01-24 14:41:51 +00:00