1
0
mirror of https://github.com/golang/go synced 2024-11-17 12:54:47 -07:00
go/misc/cgo/testshared
Michael Hudson-Doyle 1ec64e9b63 cmd/compile, runtime: a different approach to duplicate itabs
golang.org/issue/17594 was caused by additab being called more than once for
an itab. golang.org/cl/32131 fixed that by making the itabs local symbols,
but that in turn causes golang.org/issue/18252 because now there are now
multiple itab symbols in a process for a given (type,interface) pair and
different code paths can end up referring to different itabs which breaks
lots of reflection stuff. So this makes itabs global again and just takes
care to only call additab once for each itab.

Fixes #18252

Change-Id: I781a193e2f8dd80af145a3a971f6a25537f633ea
Reviewed-on: https://go-review.googlesource.com/34173
Run-TryBot: Michael Hudson-Doyle <michael.hudson@canonical.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: David Crawshaw <crawshaw@golang.org>
2016-12-19 01:31:59 +00:00
..
src cmd/compile, runtime: a different approach to duplicate itabs 2016-12-19 01:31:59 +00:00
shared_test.go cmd/link: fix -buildmode=pie / -linkshared combination 2016-09-13 02:40:30 +00:00