1
0
mirror of https://github.com/golang/go synced 2024-11-19 00:24:41 -07:00
go/internal/lsp/cache
Rebecca Stambler b2a7f28a18 internal/lsp: do not close over the handle in the memoize function
Closing over the checkPackageHandle creates a cycle that forces the
checkPackageHandle not to be garbage collected until the value is
created. If a value is never created, the handle will not be collected.

Change-Id: I0f94557da917330ebe307a0e843b16ca7382e210
Reviewed-on: https://go-review.googlesource.com/c/tools/+/204079
Run-TryBot: Rebecca Stambler <rstambler@golang.org>
Reviewed-by: Ian Cottrell <iancottrell@google.com>
2019-10-30 00:30:36 +00:00
..
analysis.go internal/lsp: remove the pkg.view field, in preparation for CL 204079 2019-10-29 23:14:01 +00:00
builtin.go internal/lsp: address staticcheck warnings 2019-10-04 02:16:23 +00:00
cache.go internal/lsp: use options hooks to install diff driver 2019-10-11 16:38:31 +00:00
check.go internal/lsp: do not close over the handle in the memoize function 2019-10-30 00:30:36 +00:00
error_test.go internal/lsp: refactor error handling code in type-checking 2019-10-21 18:57:46 +00:00
errors.go internal/lsp: remove the pkg.view field, in preparation for CL 204079 2019-10-29 23:14:01 +00:00
external.go internal/lsp: address staticcheck warnings 2019-10-04 02:16:23 +00:00
file.go internal/lsp: modify approach to watching changed files 2019-10-22 21:33:45 +00:00
gofile.go internal/lsp: type check packages in parallel 2019-10-29 04:13:27 +00:00
load.go internal/lsp: modify approach to watching changed files 2019-10-22 21:33:45 +00:00
parse.go internal/lsp: stop caching diagnostics on the package 2019-10-24 22:03:59 +00:00
pkg.go internal/lsp: remove the pkg.view field, in preparation for CL 204079 2019-10-29 23:14:01 +00:00
session.go internal/lsp: modify approach to watching changed files 2019-10-22 21:33:45 +00:00
snapshot.go internal/lsp: stop caching diagnostics on the package 2019-10-24 22:03:59 +00:00
view.go internal/lsp: remove the pkg.view field, in preparation for CL 204079 2019-10-29 23:14:01 +00:00
watcher.go internal/lsp: modify approach to watching changed files 2019-10-22 21:33:45 +00:00