1e23e48ab9
When falling back to messages for progress reporting, don't try to implement cancellation via ShowMessageCommand dialogs. They are an imperfect solution, as the dialog stays open even after the command completed. Also, among the LSP clients that don't support workDone reporting, I suspect many also don't support ShowMessageCommand (for example, govim), so the audience for this feature is probably quite small. Just remove it, and instead show a (non-cancellable) message. If clients want cancellation, workDone progress support is the way to provide it. Also remove a redundant message on go-generate success, and attach logs when tests fail. Without logs on failure, I find that the test command is not very useful. I tested a bit with very verbose test output, and both VS Code and coc.nvim handled it gracefully. Finally, fix a bug causing benchmarks not to be run. Change-Id: I05422bcefc857c25cd99e643e614a0bc33870586 Reviewed-on: https://go-review.googlesource.com/c/tools/+/249702 Run-TryBot: Robert Findley <rfindley@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Heschi Kreinick <heschi@google.com> |
||
|---|---|---|
| benchmark/parse | ||
| blog | ||
| cmd | ||
| container/intsets | ||
| cover | ||
| go | ||
| godoc | ||
| gopls | ||
| imports | ||
| internal | ||
| playground | ||
| present | ||
| refactor | ||
| txtar | ||
| .gitattributes | ||
| .gitignore | ||
| .prettierrc | ||
| AUTHORS | ||
| codereview.cfg | ||
| CONTRIBUTING.md | ||
| CONTRIBUTORS | ||
| go.mod | ||
| go.sum | ||
| LICENSE | ||
| PATENTS | ||
| README.md | ||
Go Tools
This subrepository holds the source for various packages and tools that support the Go programming language.
Some of the tools, godoc and vet for example, are included in binary Go
distributions.
Others, including the Go guru and the test coverage tool, can be fetched with
go get.
Packages include a type-checker for Go and an implementation of the Static Single Assignment form (SSA) representation for Go programs.
Download/Install
The easiest way to install is to run go get -u golang.org/x/tools/.... You can
also manually git clone the repository to $GOPATH/src/golang.org/x/tools.
JS/CSS Formatting
This repository uses prettier to format JS and CSS files.
The version of prettier used is 1.18.2.
It is encouraged that all JS and CSS code be run through this before submitting a change. However, it is not a strict requirement enforced by CI.
Report Issues / Send Patches
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html.
The main issue tracker for the tools repository is located at https://github.com/golang/go/issues. Prefix your issue with "x/tools/(your subdir):" in the subject line, so it is easy to find.