mirror of
https://github.com/golang/go
synced 2024-11-19 03:34:41 -07:00
9f640c2abb
A DebugRef associates a source expression E with an ssa.Value V, but until now did not record whether V was the value or the address of E. So, we would guess from the "pointerness" of the Value, leading to confusion in some cases, e.g. type N *N var n N n = &n // lvalue and rvalue are both pointers Now we explicitly record 'IsAddress bool' in DebugRef, and plumb this everywhere: through (*Function).ValueForExpr and (*Program).VarValue, all the way to forming the pointer analysis query. Also: - VarValue now treats each reference to a global distinctly, just like it does for other vars. So: var g int func f() { g = 1 // VarValue(g) == Const(1:int), !isAddress print(g) // VarValue(g) == Global(g), isAddress } - DebugRefs are not emitted for references to predeclared identifiers (nil, built-in). - DebugRefs no longer prevent lifting of an Alloc var into a register; now we update or discard the debug info. - TestValueForExpr: improve coverage of ssa.EnclosingFunction by putting expectations in methods and init funcs, not just normal funcs. - oracle: fix golden file broken by recent (*types.Var).IsField change. R=gri CC=golang-dev https://golang.org/cl/16610045
271 lines
6.9 KiB
Go
271 lines
6.9 KiB
Go
// Copyright 2013 The Go Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
package ssa_test
|
|
|
|
// This file defines tests of source-level debugging utilities.
|
|
|
|
import (
|
|
"fmt"
|
|
"go/ast"
|
|
"go/parser"
|
|
"go/token"
|
|
"os"
|
|
"regexp"
|
|
"strings"
|
|
"testing"
|
|
|
|
"code.google.com/p/go.tools/go/exact"
|
|
"code.google.com/p/go.tools/go/types"
|
|
"code.google.com/p/go.tools/importer"
|
|
"code.google.com/p/go.tools/ssa"
|
|
)
|
|
|
|
func TestObjValueLookup(t *testing.T) {
|
|
imp := importer.New(new(importer.Config)) // (uses GCImporter)
|
|
f, err := parser.ParseFile(imp.Fset, "testdata/objlookup.go", nil, parser.ParseComments)
|
|
if err != nil {
|
|
t.Error(err)
|
|
return
|
|
}
|
|
|
|
// Maps each var Ident (represented "name:linenum") to the
|
|
// kind of ssa.Value we expect (represented "Constant", "&Alloc").
|
|
expectations := make(map[string]string)
|
|
|
|
// Find all annotations of form x::BinOp, &y::Alloc, etc.
|
|
re := regexp.MustCompile(`(\b|&)?(\w*)::(\w*)\b`)
|
|
for _, c := range f.Comments {
|
|
text := c.Text()
|
|
pos := imp.Fset.Position(c.Pos())
|
|
for _, m := range re.FindAllStringSubmatch(text, -1) {
|
|
key := fmt.Sprintf("%s:%d", m[2], pos.Line)
|
|
value := m[1] + m[3]
|
|
expectations[key] = value
|
|
}
|
|
}
|
|
|
|
mainInfo := imp.CreatePackage("main", f)
|
|
|
|
prog := ssa.NewProgram(imp.Fset, 0 /*|ssa.LogFunctions*/)
|
|
if err := prog.CreatePackages(imp); err != nil {
|
|
t.Error(err)
|
|
return
|
|
}
|
|
mainPkg := prog.Package(mainInfo.Pkg)
|
|
mainPkg.SetDebugMode(true)
|
|
mainPkg.Build()
|
|
|
|
// Gather all idents and objects in file.
|
|
objs := make(map[types.Object]bool)
|
|
var ids []*ast.Ident
|
|
ast.Inspect(f, func(n ast.Node) bool {
|
|
if id, ok := n.(*ast.Ident); ok {
|
|
ids = append(ids, id)
|
|
if obj := mainInfo.ObjectOf(id); obj != nil {
|
|
objs[obj] = true
|
|
}
|
|
}
|
|
return true
|
|
})
|
|
|
|
// Check invariants for func and const objects.
|
|
for obj := range objs {
|
|
switch obj := obj.(type) {
|
|
case *types.Func:
|
|
checkFuncValue(t, prog, obj)
|
|
|
|
case *types.Const:
|
|
checkConstValue(t, prog, obj)
|
|
}
|
|
}
|
|
|
|
// Check invariants for var objects.
|
|
// The result varies based on the specific Ident.
|
|
for _, id := range ids {
|
|
if id.Name == "_" {
|
|
continue
|
|
}
|
|
if obj, ok := mainInfo.ObjectOf(id).(*types.Var); ok {
|
|
ref, _ := importer.PathEnclosingInterval(f, id.Pos(), id.Pos())
|
|
pos := imp.Fset.Position(id.Pos())
|
|
exp := expectations[fmt.Sprintf("%s:%d", id.Name, pos.Line)]
|
|
if exp == "" {
|
|
t.Errorf("%s: no expectation for var ident %s ", pos, id.Name)
|
|
continue
|
|
}
|
|
wantAddr := false
|
|
if exp[0] == '&' {
|
|
wantAddr = true
|
|
exp = exp[1:]
|
|
}
|
|
checkVarValue(t, prog, mainPkg, ref, obj, exp, wantAddr)
|
|
}
|
|
}
|
|
}
|
|
|
|
func checkFuncValue(t *testing.T, prog *ssa.Program, obj *types.Func) {
|
|
fn := prog.FuncValue(obj)
|
|
// fmt.Printf("FuncValue(%s) = %s\n", obj, fn) // debugging
|
|
if fn == nil {
|
|
t.Errorf("FuncValue(%s) == nil", obj)
|
|
return
|
|
}
|
|
if fnobj := fn.Object(); fnobj != obj {
|
|
t.Errorf("FuncValue(%s).Object() == %s; value was %s",
|
|
obj, fnobj, fn.Name())
|
|
return
|
|
}
|
|
if !types.IsIdentical(fn.Type(), obj.Type()) {
|
|
t.Errorf("FuncValue(%s).Type() == %s", obj, fn.Type())
|
|
return
|
|
}
|
|
}
|
|
|
|
func checkConstValue(t *testing.T, prog *ssa.Program, obj *types.Const) {
|
|
c := prog.ConstValue(obj)
|
|
// fmt.Printf("ConstValue(%s) = %s\n", obj, c) // debugging
|
|
if c == nil {
|
|
t.Errorf("ConstValue(%s) == nil", obj)
|
|
return
|
|
}
|
|
if !types.IsIdentical(c.Type(), obj.Type()) {
|
|
t.Errorf("ConstValue(%s).Type() == %s", obj, c.Type())
|
|
return
|
|
}
|
|
if obj.Name() != "nil" {
|
|
if !exact.Compare(c.Value, token.EQL, obj.Val()) {
|
|
t.Errorf("ConstValue(%s).Value (%s) != %s",
|
|
obj, c.Value, obj.Val())
|
|
return
|
|
}
|
|
}
|
|
}
|
|
|
|
func checkVarValue(t *testing.T, prog *ssa.Program, pkg *ssa.Package, ref []ast.Node, obj *types.Var, expKind string, wantAddr bool) {
|
|
// The prefix of all assertions messages.
|
|
prefix := fmt.Sprintf("VarValue(%s @ L%d)",
|
|
obj, prog.Fset.Position(ref[0].Pos()).Line)
|
|
|
|
v, gotAddr := prog.VarValue(obj, pkg, ref)
|
|
|
|
// Kind is the concrete type of the ssa Value.
|
|
gotKind := "nil"
|
|
if v != nil {
|
|
gotKind = fmt.Sprintf("%T", v)[len("*ssa."):]
|
|
}
|
|
|
|
// fmt.Printf("%s = %v (kind %q; expect %q) wantAddr=%t gotAddr=%t\n", prefix, v, gotKind, expKind, wantAddr, gotAddr) // debugging
|
|
|
|
// Check the kinds match.
|
|
// "nil" indicates expected failure (e.g. optimized away).
|
|
if expKind != gotKind {
|
|
t.Errorf("%s concrete type == %s, want %s", prefix, gotKind, expKind)
|
|
}
|
|
|
|
// Check the types match.
|
|
// If wantAddr, the expected type is the object's address.
|
|
if v != nil {
|
|
expType := obj.Type()
|
|
if wantAddr {
|
|
expType = types.NewPointer(expType)
|
|
if !gotAddr {
|
|
t.Errorf("%s: got value, want address", prefix)
|
|
}
|
|
} else if gotAddr {
|
|
t.Errorf("%s: got address, want value", prefix)
|
|
}
|
|
if !types.IsIdentical(v.Type(), expType) {
|
|
t.Errorf("%s.Type() == %s, want %s", prefix, v.Type(), expType)
|
|
}
|
|
}
|
|
}
|
|
|
|
// Ensure that, in debug mode, we can determine the ssa.Value
|
|
// corresponding to every ast.Expr.
|
|
func TestValueForExpr(t *testing.T) {
|
|
imp := importer.New(new(importer.Config)) // (uses GCImporter)
|
|
f, err := parser.ParseFile(imp.Fset, "testdata/valueforexpr.go", nil, parser.ParseComments)
|
|
if err != nil {
|
|
t.Error(err)
|
|
return
|
|
}
|
|
|
|
mainInfo := imp.CreatePackage("main", f)
|
|
|
|
prog := ssa.NewProgram(imp.Fset, 0)
|
|
if err := prog.CreatePackages(imp); err != nil {
|
|
t.Error(err)
|
|
return
|
|
}
|
|
mainPkg := prog.Package(mainInfo.Pkg)
|
|
mainPkg.SetDebugMode(true)
|
|
mainPkg.Build()
|
|
|
|
if false {
|
|
// debugging
|
|
for _, mem := range mainPkg.Members {
|
|
if fn, ok := mem.(*ssa.Function); ok {
|
|
fn.DumpTo(os.Stderr)
|
|
}
|
|
}
|
|
}
|
|
|
|
// Find the actual AST node for each canonical position.
|
|
parenExprByPos := make(map[token.Pos]*ast.ParenExpr)
|
|
ast.Inspect(f, func(n ast.Node) bool {
|
|
if n != nil {
|
|
if e, ok := n.(*ast.ParenExpr); ok {
|
|
parenExprByPos[e.Pos()] = e
|
|
}
|
|
}
|
|
return true
|
|
})
|
|
|
|
// Find all annotations of form /*@kind*/.
|
|
for _, c := range f.Comments {
|
|
text := strings.TrimSpace(c.Text())
|
|
if text == "" || text[0] != '@' {
|
|
continue
|
|
}
|
|
text = text[1:]
|
|
pos := c.End() + 1
|
|
position := imp.Fset.Position(pos)
|
|
var e ast.Expr
|
|
if target := parenExprByPos[pos]; target == nil {
|
|
t.Errorf("%s: annotation doesn't precede ParenExpr: %q", position, text)
|
|
continue
|
|
} else {
|
|
e = target.X
|
|
}
|
|
|
|
path, _ := importer.PathEnclosingInterval(f, pos, pos)
|
|
if path == nil {
|
|
t.Errorf("%s: can't find AST path from root to comment: %s", position, text)
|
|
continue
|
|
}
|
|
|
|
fn := ssa.EnclosingFunction(mainPkg, path)
|
|
if fn == nil {
|
|
t.Errorf("%s: can't find enclosing function", position)
|
|
continue
|
|
}
|
|
|
|
v, gotAddr := fn.ValueForExpr(e) // (may be nil)
|
|
got := strings.TrimPrefix(fmt.Sprintf("%T", v), "*ssa.")
|
|
if want := text; got != want {
|
|
t.Errorf("%s: got value %q, want %q", position, got, want)
|
|
}
|
|
if v != nil {
|
|
T := v.Type()
|
|
if gotAddr {
|
|
T = T.Underlying().(*types.Pointer).Elem() // deref
|
|
}
|
|
if !types.IsIdentical(T, mainInfo.TypeOf(e)) {
|
|
t.Errorf("%s: got type %s, want %s", position, mainInfo.TypeOf(e), T)
|
|
}
|
|
}
|
|
}
|
|
}
|