1
0
mirror of https://github.com/golang/go synced 2024-11-19 17:04:41 -07:00
go/src
Hana Kim 1d8fc211f9 cmd/trace: change span id computation for trace view use
golang.org/cl/102697 attempted to fix the span presentation by utilizing
the position of the span in the span slices of a task. But it is
not complete either.

First, id=0 is omitted in json encoding and the trace viewer silently
drops entries with the missing id field, so we must avoid zero-value id.
Second, it is possible that a goroutine handles multiple tasks. Then,
id collisions will happen.

This takes a simpler approach - have a counter that increments for every
emitSpan call, and use the value as the id value.

Change-Id: Idaa9505634acf6d327c6f00af32d8260955b85e1
Reviewed-on: https://go-review.googlesource.com/106755
Reviewed-by: Heschi Kreinick <heschi@google.com>
Run-TryBot: Hyang-Ah Hana Kim <hyangah@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
2018-04-13 16:18:30 +00:00
..
archive go/printer, gofmt: tuned table alignment for better results 2018-04-04 13:39:34 -07:00
bufio bufio: document ReadFrom/WriteTo calls to underlying methods 2018-03-28 22:21:52 +00:00
builtin
bytes internal/bytealg: move short string Index implementations into bytealg 2018-03-04 19:49:44 +00:00
cmd cmd/trace: change span id computation for trace view use 2018-04-13 16:18:30 +00:00
compress compress/gzip: do not count header bytes written in Write 2018-04-02 20:18:14 +00:00
container container/heap: fix comments style 2018-04-11 20:11:09 +00:00
context
crypto crypto/x509: don't return nil, nil from SystemCertPool 2018-04-13 00:52:47 +00:00
database/sql database/sql: remove a couple redundancies 2018-04-12 19:23:46 +00:00
debug debug/elf: add missing EM_AARCH64 to machineStrings 2018-04-10 14:30:45 +00:00
encoding encoding/json: remove unnecessary else conditions 2018-04-09 19:28:23 +00:00
errors
expvar all: use strings.Builder instead of bytes.Buffer where appropriate 2018-03-26 23:05:53 +00:00
flag flag: correct zero values when printing defaults 2018-04-01 20:17:22 +00:00
fmt fmt: document the behaviour of %p on slices 2018-03-30 00:19:36 +00:00
go go/printer, gofmt: handle raw string literals containing newlines better 2018-04-11 22:03:18 +00:00
hash crypto: remove hand encoded amd64 instructions 2018-03-01 19:20:53 +00:00
html text/template: copy Decl field when copying PipeNode 2018-04-10 14:26:58 +00:00
image all: fix non-standard "DO NOT EDIT" comments for generated files 2018-03-10 17:50:11 +00:00
index/suffixarray
internal os: use poller when NewFile is called with a blocking descriptor. 2018-04-11 17:39:11 +00:00
io io/ioutil: change TempFile prefix to a pattern 2018-04-12 20:00:25 +00:00
log
math math/big: clean up z.div(z, x, y) calls 2018-04-05 22:02:33 +00:00
mime all: use strings.Builder instead of bytes.Buffer where appropriate 2018-03-26 23:05:53 +00:00
net net: mark tests with retry as parallel 2018-04-12 21:33:25 +00:00
os os: allocate buffer lazily in Expand 2018-04-12 22:18:18 +00:00
path path/filepath: change example to print the correct path on failure 2018-03-26 17:40:01 +00:00
plugin
reflect reflect: sort exported methods first 2018-03-15 21:56:08 +00:00
regexp regexp: use sync.Pool to cache regexp.machine objects 2018-04-03 16:03:19 +00:00
runtime runtime: document that LockOSThread in init locks to thread 2018-04-13 03:15:02 +00:00
sort sort: fix typo, was a mixup between identifiers 'unsorted' and 'data' 2018-03-19 13:09:29 +00:00
strconv strconv: make code formatting more consistent in doc.go 2018-03-19 12:53:16 +00:00
strings strings: fix flaky TestBuilderGrow test 2018-04-03 00:11:46 +00:00
sync cmd/internal/obj/arm: add DMB instruction 2018-03-27 19:54:44 +00:00
syscall os: document that Chown with -1 means to leave values unchanged, like POSIX 2018-04-11 23:06:44 +00:00
testing testing: fix testing flags link 2018-03-30 23:34:47 +00:00
text text/template: copy Decl field when copying PipeNode 2018-04-10 14:26:58 +00:00
time time: document that going to sleep may stop the monotonic clock 2018-04-13 00:50:22 +00:00
unicode
unsafe unsafe: fix reference to string header 2018-02-26 18:35:46 +00:00
vendor/golang_org/x net/http: replace SOCKS client implementation 2018-04-06 23:03:17 +00:00
all.bash
all.bat
all.rc
androidtest.bash androidtest.bash: don't require GOARCH set 2018-03-07 14:01:43 +00:00
bootstrap.bash
buildall.bash
clean.bash
clean.bat
clean.rc
cmp.bash
iostest.bash iostest.bash: don't build std library twice 2018-03-06 16:08:20 +00:00
make.bash
make.bat build: small cleanup in error message in make.bat 2018-02-26 10:27:14 +00:00
Make.dist
make.rc
naclmake.bash
nacltest.bash
race.bash
race.bat
run.bash src/run.bash: remove some trailing whitespace 2018-04-01 16:12:47 +00:00
run.bat
run.rc