mirror of
https://github.com/golang/go
synced 2024-11-25 12:27:57 -07:00
ec4e8517cd
golang.org/cl/109517 optimized the compiler to avoid the allocation for make in append(x, make([]T, y)...). This was only implemented for the case that y has type int. This change extends the optimization to trigger for all integer types where the value is known at compile time to fit into an int. name old time/op new time/op delta ExtendInt-12 106ns ± 4% 106ns ± 0% ~ (p=0.351 n=10+6) ExtendUint64-12 1.03µs ± 5% 0.10µs ± 4% -90.01% (p=0.000 n=9+10) name old alloc/op new alloc/op delta ExtendInt-12 0.00B 0.00B ~ (all equal) ExtendUint64-12 13.6kB ± 0% 0.0kB -100.00% (p=0.000 n=10+10) name old allocs/op new allocs/op delta ExtendInt-12 0.00 0.00 ~ (all equal) ExtendUint64-12 1.00 ± 0% 0.00 -100.00% (p=0.000 n=10+10) Updates #29785 Change-Id: Ief7760097c285abd591712da98c5b02bc3961fcd Reviewed-on: https://go-review.googlesource.com/c/go/+/182559 Run-TryBot: Cuong Manh Le <cuong.manhle.vn@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Keith Randall <khr@golang.org>
86 lines
2.9 KiB
Go
86 lines
2.9 KiB
Go
// run
|
|
|
|
// Copyright 2013 The Go Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
package main
|
|
|
|
import (
|
|
"strings"
|
|
"unsafe"
|
|
)
|
|
|
|
type T []int
|
|
|
|
func main() {
|
|
n := -1
|
|
shouldPanic("len out of range", func() { _ = make(T, n) })
|
|
shouldPanic("cap out of range", func() { _ = make(T, 0, n) })
|
|
shouldPanic("len out of range", func() { _ = make(T, int64(n)) })
|
|
shouldPanic("cap out of range", func() { _ = make(T, 0, int64(n)) })
|
|
testMakeInAppend(n)
|
|
|
|
var t *byte
|
|
if unsafe.Sizeof(t) == 8 {
|
|
// Test mem > maxAlloc
|
|
var n2 int64 = 1 << 59
|
|
shouldPanic("len out of range", func() { _ = make(T, int(n2)) })
|
|
shouldPanic("cap out of range", func() { _ = make(T, 0, int(n2)) })
|
|
testMakeInAppend(int(n2))
|
|
// Test elem.size*cap overflow
|
|
n2 = 1<<63 - 1
|
|
shouldPanic("len out of range", func() { _ = make(T, int(n2)) })
|
|
shouldPanic("cap out of range", func() { _ = make(T, 0, int(n2)) })
|
|
testMakeInAppend(int(n2))
|
|
var x uint64 = 1<<64 - 1
|
|
shouldPanic("len out of range", func() { _ = make([]byte, x) })
|
|
shouldPanic("cap out of range", func() { _ = make(T, 0, x) })
|
|
testMakeInAppend(int(x))
|
|
} else {
|
|
n = 1<<31 - 1
|
|
shouldPanic("len out of range", func() { _ = make(T, n) })
|
|
shouldPanic("cap out of range", func() { _ = make(T, 0, n) })
|
|
shouldPanic("len out of range", func() { _ = make(T, int64(n)) })
|
|
shouldPanic("cap out of range", func() { _ = make(T, 0, int64(n)) })
|
|
testMakeInAppend(n)
|
|
var x uint64 = 1<<32 - 1
|
|
shouldPanic("len out of range", func() { _ = make([]byte, x) })
|
|
shouldPanic("cap out of range", func() { _ = make(T, 0, x) })
|
|
testMakeInAppend(int(x))
|
|
}
|
|
}
|
|
|
|
func shouldPanic(str string, f func()) {
|
|
defer func() {
|
|
err := recover()
|
|
if err == nil {
|
|
panic("did not panic")
|
|
}
|
|
s := err.(error).Error()
|
|
if !strings.Contains(s, str) {
|
|
panic("got panic " + s + ", want " + str)
|
|
}
|
|
}()
|
|
|
|
f()
|
|
}
|
|
|
|
// Test make in append panics since the gc compiler optimizes makes in appends.
|
|
func testMakeInAppend(n int) {
|
|
lengths := []int{0, 1}
|
|
for _, length := range lengths {
|
|
t := make(T, length)
|
|
shouldPanic("len out of range", func() { _ = append(t, make(T, n)...) })
|
|
shouldPanic("cap out of range", func() { _ = append(t, make(T, 0, n)...) })
|
|
shouldPanic("len out of range", func() { _ = append(t, make(T, int64(n))...) })
|
|
shouldPanic("cap out of range", func() { _ = append(t, make(T, 0, int64(n))...) })
|
|
shouldPanic("len out of range", func() { _ = append(t, make(T, uint64(n))...) })
|
|
shouldPanic("cap out of range", func() { _ = append(t, make(T, 0, uint64(n))...) })
|
|
shouldPanic("len out of range", func() { _ = append(t, make(T, int(n))...) })
|
|
shouldPanic("cap out of range", func() { _ = append(t, make(T, 0, int(n))...) })
|
|
shouldPanic("len out of range", func() { _ = append(t, make(T, uint(n))...) })
|
|
shouldPanic("cap out of range", func() { _ = append(t, make(T, 0, uint(n))...) })
|
|
}
|
|
}
|