mirror of
https://github.com/golang/go
synced 2024-11-25 12:47:56 -07:00
9dc3b8b722
First the insidious bug:
var n uintptr
for n := elemPtrs; n > 120; n -= 120 {
prog = append(prog, 120)
prog = append(prog, mask[:15]...)
mask = mask[15:]
}
prog = append(prog, byte(n))
prog = append(prog, mask[:(n+7)/8]...)
The := breaks this code, because the n after the loop is always 0!
We also do need to handle field padding correctly. In particular
the old padding code doesn't correctly handle fields that are not
a multiple of a pointer in size.
Fixes #30606.
Change-Id: Ifcab9494dc25c20116753c5d7e0145d6c2053ed8
Reviewed-on: https://go-review.googlesource.com/c/go/+/165860
Run-TryBot: Keith Randall <khr@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
52 lines
1.5 KiB
Go
52 lines
1.5 KiB
Go
// run
|
|
|
|
// Copyright 2019 The Go Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
package main
|
|
|
|
import "reflect"
|
|
|
|
func main() {}
|
|
|
|
func typ(x interface{}) reflect.Type { return reflect.ValueOf(x).Type() }
|
|
|
|
var byteType = typ((byte)(0))
|
|
var ptrType = typ((*byte)(nil))
|
|
|
|
// Arrays of pointers. There are two size thresholds.
|
|
// Bit masks are chunked in groups of 120 pointers.
|
|
// Array types with >16384 pointers have a GC program instead of a bitmask.
|
|
var smallPtrType = reflect.ArrayOf(100, ptrType)
|
|
var mediumPtrType = reflect.ArrayOf(1000, ptrType)
|
|
var bigPtrType = reflect.ArrayOf(16385, ptrType)
|
|
|
|
var x0 = reflect.New(reflect.StructOf([]reflect.StructField{
|
|
{Name: "F1", Type: byteType},
|
|
{Name: "F2", Type: bigPtrType},
|
|
}))
|
|
var x1 = reflect.New(reflect.StructOf([]reflect.StructField{
|
|
{Name: "F1", Type: smallPtrType},
|
|
{Name: "F2", Type: bigPtrType},
|
|
}))
|
|
var x2 = reflect.New(reflect.StructOf([]reflect.StructField{
|
|
{Name: "F1", Type: mediumPtrType},
|
|
{Name: "F2", Type: bigPtrType},
|
|
}))
|
|
var x3 = reflect.New(reflect.StructOf([]reflect.StructField{
|
|
{Name: "F1", Type: ptrType},
|
|
{Name: "F2", Type: byteType},
|
|
{Name: "F3", Type: bigPtrType},
|
|
}))
|
|
var x4 = reflect.New(reflect.StructOf([]reflect.StructField{
|
|
{Name: "F1", Type: ptrType},
|
|
{Name: "F2", Type: smallPtrType},
|
|
{Name: "F3", Type: bigPtrType},
|
|
}))
|
|
var x5 = reflect.New(reflect.StructOf([]reflect.StructField{
|
|
{Name: "F1", Type: ptrType},
|
|
{Name: "F2", Type: mediumPtrType},
|
|
{Name: "F3", Type: bigPtrType},
|
|
}))
|