Pontus Leitzler 1c0c6cf43e x/tools/internal/lsp/source: avoid panic in failing Highlight test ... When testing Highlight the highlight count is checked against expected number of highlights. If it doesn't match t.Errorf(...) is called and the test continues. A few lines below the test ranges over results using the index for both result and expected result leading to a panic if there are less then expected highlights. This change fails fast with t.Fatalf(...) instead to avoid the panic. Change-Id: I33d0973f3145c307d9084d037ffbb73b244a3acb Reviewed-on: https://go-review.googlesource.com/c/tools/+/236099 Reviewed-by: Rebecca Stambler <rstambler@golang.org> Run-TryBot: Rebecca Stambler <rstambler@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>		2020-06-03 17:03:22 +00:00
..
analysis	internal/lsp: add type error fixes to existing diagnostics	2020-04-08 01:45:16 +00:00
browser	internal/lsp: add version and bug commands	2019-05-11 04:16:02 +00:00
cache	internal/lsp: change exit handling	2020-06-03 13:14:19 +00:00
cmd	internal/lsp: change logging stream to be a framer	2020-06-03 13:12:46 +00:00
debug	internal/lsp: fix typo in code comment	2020-05-30 23:37:09 +00:00
diff	internal/testenv: check that external 'diff' tool is the GNU version	2020-05-08 20:46:49 +00:00
fake	internal/jsonrpc2: add the ability to close connections	2020-06-03 13:11:45 +00:00
fuzzy	internal/lsp: fix errors found by staticcheck	2020-03-19 19:20:54 +00:00
helper	internal/lsp: change to helper.go to output a formatted file	2020-01-31 20:35:38 +00:00
lsprpc	internal/lsp: change exit handling	2020-06-03 13:14:19 +00:00
mod	internal/lsp: support configurable codeLens	2020-05-08 18:47:35 +00:00
protocol	internal/lsp: change exit handling	2020-06-03 13:14:19 +00:00
regtest	internal/lsp/regtest: print completed work when a regtest fails	2020-06-03 13:19:21 +00:00
snippet	all: fix broken links to LSP specification	2019-10-02 18:32:53 +00:00
source	x/tools/internal/lsp/source: avoid panic in failing Highlight test	2020-06-03 17:03:22 +00:00
testdata	internal/lsp/source: fix cached package name matching	2020-05-27 17:50:42 +00:00
tests	all: consolidate cgo requirement checks	2020-05-18 17:24:58 +00:00
code_action.go	internal/lsp: don't offer suggested fixes for generated files	2020-05-01 06:56:59 +00:00
command.go	internal/lsp: fix a few staticcheck issues	2020-05-29 17:23:31 +00:00
completion_test.go	internal/lsp/source: offer smart "append()" completions	2020-05-20 22:05:37 +00:00
completion.go	internal/telemetry: renaming to internal/event	2020-04-23 17:20:48 +00:00
definition.go	internal/lsp/source: return location(s) for imported packages	2020-03-09 16:25:02 +00:00
diagnostics.go	internal/lsp: avoid showing no-GOPATH-nor-module message so much	2020-05-02 20:28:11 +00:00
folding_range.go	internal/lsp: check for file URIs on LSP requests	2020-02-14 22:51:26 +00:00
format.go	internal/lsp: support textDocument/formatting for .mod extension	2020-03-06 13:51:27 +00:00
general.go	internal/lsp: change exit handling	2020-06-03 13:14:19 +00:00
generate.go	internal/lsp: add run test code lens	2020-05-12 13:19:52 +00:00
highlight.go	internal/telemetry: renaming to internal/event	2020-04-23 17:20:48 +00:00
hover.go	internal/lsp: support textDocument/hover for .mod extension	2020-02-26 15:59:49 +00:00
implementation.go	internal/lsp: check for file URIs on LSP requests	2020-02-14 22:51:26 +00:00
link.go	internal/telemetry: renaming to internal/event	2020-04-23 17:20:48 +00:00
lsp_test.go	internal/lsp: add config option for SymbolMatch	2020-05-11 19:58:58 +00:00
progress.go	internal/lsp: factor out progress reporting to a new WorkDone handle	2020-04-28 20:46:18 +00:00
references.go	internal/lsp: refactor references/rename/implementations	2020-03-27 17:09:18 +00:00
rename.go	internal/lsp: check for file URIs on LSP requests	2020-02-14 22:51:26 +00:00
reset_golden.sh	internal/lsp: fix regeneration of golden files	2019-09-25 13:16:59 +00:00
server_gen.go	x/tools/gopls: add support for $/progress functionality	2020-03-16 21:25:24 +00:00
server.go	internal/lsp: factor out progress reporting to a new WorkDone handle	2020-04-28 20:46:18 +00:00
signature_help.go	internal/event: extract keys to their own package	2020-04-23 18:13:43 +00:00
symbols.go	internal/event: renaming the main event API functions	2020-04-23 17:21:36 +00:00
text_synchronization.go	internal/lsp: lift up workdone instrumentation to didModifyFiles	2020-06-03 13:18:45 +00:00
workspace_symbol.go	internal/lsp: add config option for SymbolMatch	2020-05-11 19:58:58 +00:00
workspace.go	internal/lsp: generate boilerplate stubs for type Server	2020-01-24 14:41:51 +00:00