mirror of
https://github.com/golang/go
synced 2024-09-29 23:24:29 -06:00
b44e73eacb
When test/run script was removed, these two tests were changed to be executed by test/run.go. Because errchk does not exit with non-zero status on errors, they were silently failing for a while. This change makes 2 things: 1. Compile tested packages in GOROOT/test to match older runner script behavior (strictly required only in bug345, optional in bug248) 2. Check command output with "(?m)^BUG" regexp. It approximates older `grep -q '^BUG' that was used before. See referenced issue for detailed explanation. Fixes #24629 Change-Id: Ie888dcdb4e25cdbb19d434bbc5cb03eb633e9ee8 Reviewed-on: https://go-review.googlesource.com/104095 Run-TryBot: Iskander Sharipov <iskander.sharipov@intel.com> Reviewed-by: Emmanuel Odeke <emm.odeke@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org>
55 lines
1.2 KiB
Go
55 lines
1.2 KiB
Go
// +build !nacl,!plan9,!windows
|
|
// run
|
|
|
|
// Copyright 2009 The Go Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
package main
|
|
|
|
import (
|
|
"fmt"
|
|
"os"
|
|
"os/exec"
|
|
"path/filepath"
|
|
"regexp"
|
|
)
|
|
|
|
func main() {
|
|
// TODO: If we get rid of errchk, re-enable this test on Windows.
|
|
errchk, err := filepath.Abs("errchk")
|
|
check(err)
|
|
|
|
bugDir := filepath.Join(".", "fixedbugs", "bug248.dir")
|
|
run("go", "tool", "compile", filepath.Join(bugDir, "bug0.go"))
|
|
run("go", "tool", "compile", filepath.Join(bugDir, "bug1.go"))
|
|
run("go", "tool", "compile", filepath.Join(bugDir, "bug2.go"))
|
|
run(errchk, "go", "tool", "compile", "-e", filepath.Join(bugDir, "bug3.go"))
|
|
run("go", "tool", "link", "bug2.o")
|
|
run(fmt.Sprintf(".%ca.out", filepath.Separator))
|
|
|
|
os.Remove("bug0.o")
|
|
os.Remove("bug1.o")
|
|
os.Remove("bug2.o")
|
|
os.Remove("a.out")
|
|
}
|
|
|
|
var bugRE = regexp.MustCompile(`(?m)^BUG`)
|
|
|
|
func run(name string, args ...string) {
|
|
cmd := exec.Command(name, args...)
|
|
out, err := cmd.CombinedOutput()
|
|
if bugRE.Match(out) || err != nil {
|
|
fmt.Println(string(out))
|
|
fmt.Println(err)
|
|
os.Exit(1)
|
|
}
|
|
}
|
|
|
|
func check(err error) {
|
|
if err != nil {
|
|
fmt.Println(err)
|
|
os.Exit(1)
|
|
}
|
|
}
|