mirror of
https://github.com/golang/go
synced 2024-11-24 18:20:02 -07:00
ddb5a42b25
Agressively mark all LHS variables in assignments as used if there is any error in the (entire) assignment. This reduces the number of spurious "declared but not used" errors in programs that are invalid in the first place. This behavior is closer to the behavior of the compiler's original type checker (types1) and lets us remove lines of the form "_ = variable" just to satisfy test cases. It also makes more important errors visible by not crowding them out. Remove the Checker.useLHS function and use Checker.use instead: useLHS didn't evaluate top-level variables, but we actually want them to be evaluated in an error scenario so that they are getting used (and thus we don't get the "declared but not used" error). Fixes #42937. Change-Id: Idda460f6b81c66735bf9fd597c54188949bf12b8 Reviewed-on: https://go-review.googlesource.com/c/go/+/351730 Trust: Robert Griesemer <gri@golang.org> Run-TryBot: Robert Griesemer <gri@golang.org> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Robert Findley <rfindley@google.com>
38 lines
758 B
Go
38 lines
758 B
Go
// errorcheck
|
|
|
|
// Copyright 2009 The Go Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
// Test that interface{M()} = *interface{M()} produces a compiler error.
|
|
// Does not compile.
|
|
|
|
package main
|
|
|
|
type Inst interface {
|
|
Next() *Inst
|
|
}
|
|
|
|
type Regexp struct {
|
|
code []Inst
|
|
start Inst
|
|
}
|
|
|
|
type Start struct {
|
|
foo *Inst
|
|
}
|
|
|
|
func (start *Start) Next() *Inst { return nil }
|
|
|
|
func AddInst(Inst) *Inst {
|
|
print("ok in addinst\n")
|
|
return nil
|
|
}
|
|
|
|
func main() {
|
|
print("call addinst\n")
|
|
var x Inst = AddInst(new(Start)) // ERROR "pointer to interface|incompatible type"
|
|
print("return from addinst\n")
|
|
var y *Inst = new(Start) // ERROR "pointer to interface|incompatible type"
|
|
}
|