18c2033ba5
The "block" helpers in TestBlockProfile previously slept for an arbitrary duration and assumed that that duration was long enough for the parent goroutine to have registered as blocking. However — especially on slow or overloaded builders — the current arbitrary duration is sometimes not quite long enough. Rather than increasing the duration to a different arbitrary value (which would make the test slower but not actually eliminate the possibility of flakes!), we can use the runtime's own accounting to detect when the goroutine is actually blocked: we obtain a goroutine dump from the runtime, and assume that blocking has been registered in the profile only if the runtime shows the test goroutine in the appropriate blocked state. That not only makes the test more reliable, but also makes it significantly lower-latency when run on a fast machine. Fixes #6999 Fixes #37844 Change-Id: I465ed2afd406fd2b621419e1f06925f283525f25 Reviewed-on: https://go-review.googlesource.com/c/go/+/384534 Trust: Bryan Mills <bcmills@google.com> Trust: Benny Siegert <bsiegert@gmail.com> Run-TryBot: Bryan Mills <bcmills@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Ian Lance Taylor <iant@golang.org> |
||
|---|---|---|
| .github | ||
| api | ||
| doc | ||
| lib/time | ||
| misc | ||
| src | ||
| test | ||
| .gitattributes | ||
| .gitignore | ||
| AUTHORS | ||
| codereview.cfg | ||
| CONTRIBUTING.md | ||
| CONTRIBUTORS | ||
| LICENSE | ||
| PATENTS | ||
| README.md | ||
| SECURITY.md | ||
The Go Programming Language
Go is an open source programming language that makes it easy to build simple, reliable, and efficient software.
Gopher image by Renee French, licensed under Creative Commons 3.0 Attributions license.
Our canonical Git repository is located at https://go.googlesource.com/go. There is a mirror of the repository at https://github.com/golang/go.
Unless otherwise noted, the Go source files are distributed under the BSD-style license found in the LICENSE file.
Download and Install
Binary Distributions
Official binary distributions are available at https://golang.org/dl/.
After downloading a binary release, visit https://golang.org/doc/install for installation instructions.
Install From Source
If a binary distribution is not available for your combination of operating system and architecture, visit https://golang.org/doc/install/source for source installation instructions.
Contributing
Go is the work of thousands of contributors. We appreciate your help!
To contribute, please read the contribution guidelines at https://golang.org/doc/contribute.
Note that the Go project uses the issue tracker for bug reports and proposals only. See https://golang.org/wiki/Questions for a list of places to ask questions about the Go language.