1
0
mirror of https://github.com/golang/go synced 2024-09-23 19:20:13 -06:00
go/misc/cgo/errors
Ian Lance Taylor 9d669ed47a misc/cgo/errors: use expected column numbers
The test was using the wrong column numbers, and was erroneously
passing because there happened to be line numbers that matched those
column numbers. Change the test harness to require the expected line
number for the ERROR HERE regexp case, so that this doesn't happen again.

Also rename a couple of variables in the test to avoid useless
redeclaration errors.

Fixes #46534

Change-Id: I2fcbf5e379c346de5346035c73d174a3980c0927
Reviewed-on: https://go-review.googlesource.com/c/go/+/324970
Trust: Ian Lance Taylor <iant@golang.org>
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
2021-06-05 04:40:03 +00:00
..
testdata misc/cgo/errors: use expected column numbers 2021-06-05 04:40:03 +00:00
argposition_test.go cmd/cgo: pass end position info for C function arguments. 2021-04-05 19:29:17 +00:00
badsym_test.go all: update references to symbols moved from io/ioutil to io 2021-04-05 17:51:15 +00:00
errors_test.go misc/cgo/errors: use expected column numbers 2021-06-05 04:40:03 +00:00
ptr_test.go all: update references to symbols moved from io/ioutil to io 2021-04-05 17:51:15 +00:00