Ian Cottrell 18395615f2 internal/telemetry: pack strings efficiently into tags ... TagOfString() deconstructs a string into length and data pointer using the unsafe package, and then stores the length into Tag.packed and the pointer into Tag.untyped, which it can do without allocations. Tag.UnpackString can reconstruct a string on access also using the unsafe package to rebuild the string header. This makes tag significantly smaller, which in turn makes things a faster name old time/op new time/op delta /Baseline-8 160ns ± 6% 158ns ± 8% ~ /StdLog-8 7.50µs ± 8% 7.47µs ±20% ~ /LogNoExporter-8 1.13µs ± 7% 1.04µs ± 2% -8.08% /TraceNoExporter-8 3.61µs ±15% 2.96µs ± 5% -18.08% /StatsNoExporter-8 1.65µs ± 7% 1.39µs ± 7% -16.14% /LogNoop-8 4.43µs ±14% 4.05µs ± 7% ~ /TraceNoop-8 10.9µs ± 5% 10.1µs ± 8% ~ /StatsNoop-8 8.08µs ± 3% 7.42µs ±13% ~ /Log-8 16.2µs ±14% 13.4µs ± 3% -17.10% /Trace-8 61.7µs ±22% 53.6µs ± 7% ~ /Stats-8 11.3µs ±10% 9.5µs ± 4% -15.56% name old alloc/op new alloc/op delta /Baseline-8 0.00B 0.00B ~ /StdLog-8 552B ± 0% 552B ± 0% ~ /LogNoExporter-8 0.00B 0.00B ~ /TraceNoExporter-8 3.58kB ± 0% 2.82kB ± 0% -21.43% /StatsNoExporter-8 0.00B 0.00B ~ /LogNoop-8 3.58kB ± 0% 2.82kB ± 0% -21.43% /TraceNoop-8 11.5kB ± 0% 9.2kB ± 0% -20.00% /StatsNoop-8 7.17kB ± 0% 5.63kB ± 0% -21.43% /Log-8 3.58kB ± 0% 2.82kB ± 0% -21.43% /Trace-8 27.9kB ± 0% 23.6kB ± 0% -15.60% /Stats-8 7.17kB ± 0% 5.63kB ± 0% -21.43% name old allocs/op new allocs/op delta /Baseline-8 0.00 0.00 ~ /StdLog-8 30.0 ± 0% 30.0 ± 0% ~ /LogNoExporter-8 0.00 0.00 ~ /TraceNoExporter-8 16.0 ± 0% 16.0 ± 0% ~ /StatsNoExporter-8 0.00 0.00 ~ /LogNoop-8 16.0 ± 0% 16.0 ± 0% ~ /TraceNoop-8 64.0 ± 0% 64.0 ± 0% ~ /StatsNoop-8 32.0 ± 0% 32.0 ± 0% ~ /Log-8 16.0 ± 0% 16.0 ± 0% ~ /Trace-8 384 ± 0% 384 ± 0% ~ /Stats-8 32.0 ± 0% 32.0 ± 0% ~ Change-Id: If5c369f138b60435f1aa74120aa3c1b68baae402 Reviewed-on: https://go-review.googlesource.com/c/tools/+/228234 Run-TryBot: Ian Cottrell <iancottrell@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Emmanuel Odeke <emm.odeke@gmail.com>		2020-04-16 04:05:44 +00:00
..
analysisinternal	internal/lsp: add goreturns like functionality as quickfix	2020-04-01 19:27:44 +00:00
apidiff	all: fix more typos	2019-09-11 15:13:14 +00:00
fastwalk	internal/fastwalk: fix checkptr failure on Darwin	2020-02-27 19:33:42 +00:00
gocommand	internal/lsp/cache: add concurrency error check for go cmds	2020-04-08 03:22:09 +00:00
gopathwalk	internal: rationalize debug logging	2020-03-03 16:59:18 +00:00
imports	internal/lsp/cache: add concurrency error check for go cmds	2020-04-08 03:22:09 +00:00
jsonrpc2	internal/jsonrpc2: simplify request even futher	2020-04-14 21:18:25 +00:00
lsp	internal/lsp: fix erroneous documentation for struct fields	2020-04-15 03:45:06 +00:00
memoize	internal/lsp/debug: serve cache entry counts	2020-02-03 22:21:18 +00:00
packagesinternal	internal/lsp/cache: add concurrency error check for go cmds	2020-04-08 03:22:09 +00:00
proxydir	internal/proxydir: add an internal package for file-based proxies	2020-04-13 22:35:07 +00:00
span	internal/span: handle URI escaping better	2020-02-18 20:59:02 +00:00
telemetry	internal/telemetry: pack strings efficiently into tags	2020-04-16 04:05:44 +00:00
testenv	internal/testenv: reject the resolved 'go' command if it does not match runtime.GOROOT	2019-11-11 19:22:22 +00:00
tool	internal/tool: avoid editorialization	2020-03-05 14:01:59 +00:00
xcontext	internal/lsp: stop making background contexts everywhere	2019-07-11 16:38:52 +00:00