mirror of
https://github.com/golang/go
synced 2024-11-18 18:44:42 -07:00
9f89edcd96
In general, a conversion to interface type may require values to be boxed, which in turn necessitates escape analysis to determine whether the boxed representation can be stack allocated. However, esc.go used to unconditionally print escape analysis decisions about OCONVIFACE, even for conversions that don't require boxing (e.g., pointers, channels, maps, functions). For test compatibility with esc.go, escape.go similarly printed these useless diagnostics. This CL removes the diagnostics, and updates test expectations accordingly. Change-Id: I97c57a4a08e44d265bba516c78426ff4f2bf1e12 Reviewed-on: https://go-review.googlesource.com/c/go/+/192697 Run-TryBot: Matthew Dempsky <mdempsky@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Cherry Zhang <cherryyz@google.com>
167 lines
4.0 KiB
Go
167 lines
4.0 KiB
Go
// errorcheck -0 -m -l
|
|
|
|
// Copyright 2015 The Go Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
// Test escape analysis for closure arguments.
|
|
|
|
package escape
|
|
|
|
var sink interface{}
|
|
|
|
func ClosureCallArgs0() {
|
|
x := 0
|
|
func(p *int) { // ERROR "p does not escape" "func literal does not escape"
|
|
*p = 1
|
|
}(&x)
|
|
}
|
|
|
|
func ClosureCallArgs1() {
|
|
x := 0
|
|
for {
|
|
func(p *int) { // ERROR "p does not escape" "func literal does not escape"
|
|
*p = 1
|
|
}(&x)
|
|
}
|
|
}
|
|
|
|
func ClosureCallArgs2() {
|
|
for {
|
|
x := 0
|
|
func(p *int) { // ERROR "p does not escape" "func literal does not escape"
|
|
*p = 1
|
|
}(&x)
|
|
}
|
|
}
|
|
|
|
func ClosureCallArgs3() {
|
|
x := 0 // ERROR "moved to heap: x"
|
|
func(p *int) { // ERROR "leaking param: p" "func literal does not escape"
|
|
sink = p
|
|
}(&x)
|
|
}
|
|
|
|
func ClosureCallArgs4() {
|
|
x := 0
|
|
_ = func(p *int) *int { // ERROR "leaking param: p to result ~r1" "func literal does not escape"
|
|
return p
|
|
}(&x)
|
|
}
|
|
|
|
func ClosureCallArgs5() {
|
|
x := 0 // ERROR "moved to heap: x"
|
|
// TODO(mdempsky): We get "leaking param: p" here because the new escape analysis pass
|
|
// can tell that p flows directly to sink, but it's a little weird. Re-evaluate.
|
|
sink = func(p *int) *int { // ERROR "leaking param: p" "func literal does not escape"
|
|
return p
|
|
}(&x)
|
|
}
|
|
|
|
func ClosureCallArgs6() {
|
|
x := 0 // ERROR "moved to heap: x"
|
|
func(p *int) { // ERROR "moved to heap: p" "func literal does not escape"
|
|
sink = &p
|
|
}(&x)
|
|
}
|
|
|
|
func ClosureCallArgs7() {
|
|
var pp *int
|
|
for {
|
|
x := 0 // ERROR "moved to heap: x"
|
|
func(p *int) { // ERROR "leaking param: p" "func literal does not escape"
|
|
pp = p
|
|
}(&x)
|
|
}
|
|
_ = pp
|
|
}
|
|
|
|
func ClosureCallArgs8() {
|
|
x := 0
|
|
defer func(p *int) { // ERROR "p does not escape" "func literal does not escape"
|
|
*p = 1
|
|
}(&x)
|
|
}
|
|
|
|
func ClosureCallArgs9() {
|
|
// BAD: x should not leak
|
|
x := 0 // ERROR "moved to heap: x"
|
|
for {
|
|
defer func(p *int) { // ERROR "func literal escapes to heap" "p does not escape"
|
|
*p = 1
|
|
}(&x)
|
|
}
|
|
}
|
|
|
|
func ClosureCallArgs10() {
|
|
for {
|
|
x := 0 // ERROR "moved to heap: x"
|
|
defer func(p *int) { // ERROR "func literal escapes to heap" "p does not escape"
|
|
*p = 1
|
|
}(&x)
|
|
}
|
|
}
|
|
|
|
func ClosureCallArgs11() {
|
|
x := 0 // ERROR "moved to heap: x"
|
|
defer func(p *int) { // ERROR "leaking param: p" "func literal does not escape"
|
|
sink = p
|
|
}(&x)
|
|
}
|
|
|
|
func ClosureCallArgs12() {
|
|
x := 0
|
|
defer func(p *int) *int { // ERROR "leaking param: p to result ~r1" "func literal does not escape"
|
|
return p
|
|
}(&x)
|
|
}
|
|
|
|
func ClosureCallArgs13() {
|
|
x := 0 // ERROR "moved to heap: x"
|
|
defer func(p *int) { // ERROR "moved to heap: p" "func literal does not escape"
|
|
sink = &p
|
|
}(&x)
|
|
}
|
|
|
|
func ClosureCallArgs14() {
|
|
x := 0
|
|
p := &x
|
|
_ = func(p **int) *int { // ERROR "leaking param: p to result ~r1 level=1" "func literal does not escape"
|
|
return *p
|
|
}(&p)
|
|
}
|
|
|
|
func ClosureCallArgs15() {
|
|
x := 0 // ERROR "moved to heap: x"
|
|
p := &x
|
|
sink = func(p **int) *int { // ERROR "leaking param content: p" "func literal does not escape"
|
|
return *p
|
|
}(&p)
|
|
}
|
|
|
|
func ClosureLeak1(s string) string { // ERROR "ClosureLeak1 s does not escape"
|
|
t := s + "YYYY" // ERROR "escapes to heap"
|
|
return ClosureLeak1a(t) // ERROR "ClosureLeak1 ... argument does not escape"
|
|
}
|
|
|
|
// See #14409 -- returning part of captured var leaks it.
|
|
func ClosureLeak1a(a ...string) string { // ERROR "leaking param: a to result ~r1 level=1$"
|
|
return func() string { // ERROR "ClosureLeak1a func literal does not escape"
|
|
return a[0]
|
|
}()
|
|
}
|
|
|
|
func ClosureLeak2(s string) string { // ERROR "ClosureLeak2 s does not escape"
|
|
t := s + "YYYY" // ERROR "escapes to heap"
|
|
c := ClosureLeak2a(t) // ERROR "ClosureLeak2 ... argument does not escape"
|
|
return c
|
|
}
|
|
func ClosureLeak2a(a ...string) string { // ERROR "leaking param content: a"
|
|
return ClosureLeak2b(func() string { // ERROR "ClosureLeak2a func literal does not escape"
|
|
return a[0]
|
|
})
|
|
}
|
|
func ClosureLeak2b(f func() string) string { // ERROR "ClosureLeak2b f does not escape"
|
|
return f()
|
|
}
|