1
0
mirror of https://github.com/golang/go synced 2024-11-18 19:54:44 -07:00
go/internal/lsp/cache
Rebecca Stambler 145a1e401f internal/lsp/cache: detach context before invalidation
In one of my previous refactoring changes, I lost the fact that the
context should be detached before invalidating a file's contents. If
this function is canceled, we will be in a bad state.

Also, small change to return ctx.Err() instead of a custom error message
from (*packageHandle).check.

Change-Id: I19e513e09e438feee105fdd89cb7364a0c3c5e7f
Reviewed-on: https://go-review.googlesource.com/c/tools/+/212104
Run-TryBot: Rebecca Stambler <rstambler@golang.org>
Reviewed-by: Heschi Kreinick <heschi@google.com>
2019-12-19 21:23:07 +00:00
..
analysis.go internal/lsp/cache: move overlay and debug handling into separate files 2019-12-18 19:17:43 +00:00
builtin.go internal/lsp/cache: move overlay and debug handling into separate files 2019-12-18 19:17:43 +00:00
cache.go internal/lsp: return snapshots from text modifications 2019-12-18 22:53:40 +00:00
check.go internal/lsp/cache: detach context before invalidation 2019-12-19 21:23:07 +00:00
debug.go internal/lsp/cache: consolidate function to update overlays 2019-12-19 21:06:08 +00:00
error_test.go internal/lsp: refactor error handling code in type-checking 2019-10-21 18:57:46 +00:00
errors.go internal/lsp/cache: move overlay and debug handling into separate files 2019-12-18 19:17:43 +00:00
external.go internal/lsp: use versioned URIs in rename and code actions 2019-11-13 05:52:40 +00:00
file.go internal/lsp: eliminate source.File type and move GetFile to snapshot 2019-12-19 20:51:25 +00:00
load.go internal/lsp: put verbose go/packages output behind verboseOutput flag 2019-12-19 19:20:50 +00:00
modfiles.go internal/lsp: add gopls setting to disable use of -modfile flag behavior 2019-12-19 18:11:24 +00:00
overlay.go internal/lsp/cache: consolidate function to update overlays 2019-12-19 21:06:08 +00:00
parse_mod.go internal/lsp: create parseModHandle for storing go.mod data 2019-12-13 22:03:54 +00:00
parse.go internal/lsp: create parseModHandle for storing go.mod data 2019-12-13 22:03:54 +00:00
pkg.go internal/lsp: set version correctly after textDocument/didOpen 2019-11-25 19:35:51 +00:00
session.go internal/lsp/cache: consolidate function to update overlays 2019-12-19 21:06:08 +00:00
snapshot.go internal/lsp: eliminate source.File type and move GetFile to snapshot 2019-12-19 20:51:25 +00:00
view.go internal/lsp/cache: detach context before invalidation 2019-12-19 21:23:07 +00:00