1
0
mirror of https://github.com/golang/go synced 2024-11-19 07:04:43 -07:00
go/src/database/sql
Tamir Duberstein 7162c4d05c database/sql/driver: remove string exclusion
The exclusion of string from IsScanValue prevents driver authors from
writing their drivers in such a way that would allow users to
distinguish between strings and byte arrays returned from a database.
Such drivers are possible today, but require their authors to deviate
from the guidance provided by the standard library.

This exclusion has been in place since the birth of this package in
https://github.com/golang/go/commit/357f2cb1a385f4d1418e48856f9abe0cce,
but the fakedb implementation shipped in the same commit violates the
exclusion!

Strictly speaking this is a breaking change, but it increases the set
of permissible Scan types, and should not cause breakage in practice.

No test changes are necessary because fakedb already exercises this.

Fixes #6497.

Change-Id: I69dbd3a59d90464bcae8c852d7ec6c97bfd120f8
Reviewed-on: https://go-review.googlesource.com/19439
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
2016-03-23 02:42:31 +00:00
..
driver database/sql/driver: remove string exclusion 2016-03-23 02:42:31 +00:00
convert_test.go database/sql: implement Scan of time.Time, document, clarify Scan error text 2016-01-27 07:37:17 +00:00
convert.go all: single space after period. 2016-03-02 00:13:47 +00:00
doc.txt
example_test.go
fakedb_test.go all: delete dead test code 2016-03-21 07:10:08 +00:00
sql_test.go all: single space after period. 2016-03-02 00:13:47 +00:00
sql.go all: single space after period. 2016-03-02 00:13:47 +00:00