Rob Findley bc073721ad internal/lsp/cache: include session IDs in some cache keys ... When caching file data specific to a session (anything with a Version or tied to a view), we now need to be more careful about the existence of multiple sessions. This change fixes a few places where we appear to cache session data without explicitly referring to the session. In principal this could cause data corruption in multi-session gopls instances, but I have not been able to force this to occur in either manual or automated testing. Also fix a data race to the unsaved overlays: https://storage.googleapis.com/go-build-log/588ee798/linux-amd64-race_d0762522.log Updates golang/go#34111 Change-Id: I47117da1aba1afc2e211785544ad3f8b3416d15d Reviewed-on: https://go-review.googlesource.com/c/tools/+/222059 Run-TryBot: Robert Findley <rfindley@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Rohan Challa <rohan@golang.org>		2020-03-05 20:50:14 +00:00
..
comment_test.go	internal/lsp: convert comments to markdown before sending to client	2019-10-04 18:35:38 +00:00
comment.go	internal/lsp: convert comments to markdown before sending to client	2019-10-04 18:35:38 +00:00
completion_builtin.go	internal/lsp/source: untangle completion type comparison	2020-02-24 18:12:40 +00:00
completion_format.go	internal/span,lsp: disambiguate URIs, DocumentURIs, and paths	2020-02-14 22:51:03 +00:00
completion_keywords.go	internal/lsp/source: improve completions at file scope	2020-02-20 22:48:06 +00:00
completion_labels.go	internal/lsp: sort by label after score	2019-12-30 21:11:21 +00:00
completion_literal.go	internal/lsp/source: untangle completion type comparison	2020-02-24 18:12:40 +00:00
completion_snippet.go	internal/lsp: merge completion options into source.Options	2020-01-13 20:09:44 +00:00
completion.go	internal/lsp/source: fix completion crash with untyped assignee	2020-03-02 21:29:26 +00:00
deep_completion.go	internal/lsp/source: improve completion involving multiple return values	2020-02-06 05:07:08 +00:00
diagnostics.go	internal/lsp: fix concurrent map read/write for missingmodules	2020-03-03 19:46:16 +00:00
folding_range.go	internal/lsp/cache: add file contents to ParseGoHandle	2020-02-13 05:05:14 +00:00
format_test.go	internal/lsp/source: trim file very carefully	2020-01-17 20:34:13 +00:00
format.go	internal/lsp: fix diagnostics not clearing when creating new files	2020-02-13 21:50:53 +00:00
highlight.go	internal/lsp/cache: add file contents to ParseGoHandle	2020-02-13 05:05:14 +00:00
hover.go	internal/lsp: support textDocument/hover for .mod extension	2020-02-26 15:59:49 +00:00
identifier.go	internal/lsp/cache: add file contents to ParseGoHandle	2020-02-13 05:05:14 +00:00
implementation.go	internal/lsp/source: support inverse "implementations"	2020-03-02 21:28:54 +00:00
options.go	internal/lsp: add codelens for go.mod dependency upgrades	2020-02-14 14:15:08 +00:00
references.go	internal/lsp: don't return references for builtins	2020-02-06 19:49:06 +00:00
rename_check.go	internal/lsp: improve literal func completion candidates	2019-11-07 21:18:00 +00:00
rename.go	internal/lsp: permit renaming symbols declared in other packages	2020-01-27 18:56:10 +00:00
signature_help.go	internal/lsp: fix active param in signature help	2020-03-03 19:47:17 +00:00
source_test.go	internal/lsp: move the debug.Instance onto the Context	2020-03-03 22:54:53 +00:00
symbols.go	internal/lsp/cache: add file contents to ParseGoHandle	2020-02-13 05:05:14 +00:00
util.go	internal/lsp/source: untangle completion type comparison	2020-02-24 18:12:40 +00:00
view.go	internal/lsp/cache: include session IDs in some cache keys	2020-03-05 20:50:14 +00:00
workspace_symbol.go	internal/lsp/source: use logical filenames for workspace symbols	2020-03-04 19:39:43 +00:00