Rob Findley de023d59a5 internal/lsp/protocol: unmarshal to pointers when dispatching requests ... With #34111, we are forwarding the LSP from one gopls instance to another. This exposed an asymmetry in our LSP dispatching: for both ClientDispatcher and ServerDispatcher, we unmarshal to non-nil response structs. This means that when forwarding the LSP, we translate empty JSON responses (corresponding to nil values) into the non-nil zero value. This causes problems for some editors, as reported in #37570. Fix it by instead unmarshaling to a pointer. This is, of course, a somewhat dangerous change. I fixed the one NPE that occurred in tests, and have done some mild manual testing. I wouldn't be surprised if we discover more NPEs later on, but I still think this is the right change to make. Updates golang/go#34111 Fixes golang/go#37570 Change-Id: Ie69e92d2821c829cdfc4f4ab303679a725f1f859 Reviewed-on: https://go-review.googlesource.com/c/tools/+/222058 Reviewed-by: Peter Weinberger <pjw@google.com> Reviewed-by: Rebecca Stambler <rstambler@golang.org> Run-TryBot: Robert Findley <rfindley@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org>		2020-03-05 22:45:36 +00:00
..
test	internal/lsp/protocol: unmarshal to pointers when dispatching requests	2020-03-05 22:45:36 +00:00
capabilities_test.go	internal/lsp: move the debug.Instance onto the Context	2020-03-03 22:54:53 +00:00
check.go	internal/span,lsp: disambiguate URIs, DocumentURIs, and paths	2020-02-14 22:51:03 +00:00
cmd_test.go	internal/lsp: move the debug.Instance onto the Context	2020-03-03 22:54:53 +00:00
cmd.go	internal/lsp: move the debug.Instance onto the Context	2020-03-03 22:54:53 +00:00
definition.go	internal/lsp: check for file URIs on LSP requests	2020-02-14 22:51:26 +00:00
export_test.go	internal/lsp: refactor query definition test to allow adding a new test	2019-03-18 20:06:54 +00:00
folding_range.go	internal/span,lsp: disambiguate URIs, DocumentURIs, and paths	2020-02-14 22:51:03 +00:00
format.go	internal/lsp: address staticcheck warnings	2019-10-04 02:16:23 +00:00
highlight.go	internal/lsp: add control flow highlighting for functions	2019-12-02 19:01:20 +00:00
implementation.go	internal/lsp: check for file URIs on LSP requests	2020-02-14 22:51:26 +00:00
imports.go	internal/lsp: check for file URIs on LSP requests	2020-02-14 22:51:26 +00:00
info.go	tools/internal/lsp/cmd: fix documentation	2019-12-30 18:10:14 +00:00
links.go	internal/span,lsp: disambiguate URIs, DocumentURIs, and paths	2020-02-14 22:51:03 +00:00
prepare_rename.go	internal/lsp/protocol: unmarshal to pointers when dispatching requests	2020-03-05 22:45:36 +00:00
query.go	internal/lsp: improve link in documentation on hover	2019-12-12 22:39:21 +00:00
references.go	internal/lsp: check for file URIs on LSP requests	2020-02-14 22:51:26 +00:00
rename.go	internal/lsp: check for file URIs on LSP requests	2020-02-14 22:51:26 +00:00
serve_test.go	internal/lsp/lsprpc: automatically resolve and start the remote gopls	2020-02-24 22:51:55 +00:00
serve.go	internal/lsp: move the debug.Instance onto the Context	2020-03-03 22:54:53 +00:00
signature.go	internal/lsp/protocol: unmarshal to pointers when dispatching requests	2020-03-05 22:45:36 +00:00
suggested_fix.go	internal/lsp: check for file URIs on LSP requests	2020-02-14 22:51:26 +00:00
symbols.go	internal/span,lsp: disambiguate URIs, DocumentURIs, and paths	2020-02-14 22:51:03 +00:00