1
0
mirror of https://github.com/golang/go synced 2024-11-18 10:54:40 -07:00
go/internal/lsp
Rebecca Stambler 125cc70a40 internal/lsp: add new go.mod requires to files with unused require
This change addresses an underlying issue with the go.mod code, which is
that it was modifying go.mod files without cloning them. This could've
resulted in some ugly race conditions.

We also handle the fact that new dependencies weren't being added
cleanly to files that already had unused dependencies.

Fixes golang/go#39041

Change-Id: I96ee0052d8d29a25e24f0bda9688e780a0fa7442
Reviewed-on: https://go-review.googlesource.com/c/tools/+/241443
Run-TryBot: Rebecca Stambler <rstambler@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Heschi Kreinick <heschi@google.com>
2020-07-10 04:15:23 +00:00
..
analysis internal/lsp: extract highlighted selection to variable 2020-07-07 21:12:28 +00:00
browser
cache internal/lsp: add new go.mod requires to files with unused require 2020-07-10 04:15:23 +00:00
cmd internal/lsp: extract highlighted selection to variable 2020-07-07 21:12:28 +00:00
debug internal/lsp/debug: save per-package stats in memory debug files 2020-06-19 18:00:37 +00:00
diff internal/testenv: check that external 'diff' tool is the GNU version 2020-05-08 20:46:49 +00:00
fake internal/lsp/regtest: use a common directory for regtest sandboxes 2020-07-09 18:15:24 +00:00
fuzzy internal/lsp: fix errors found by staticcheck 2020-03-19 19:20:54 +00:00
helper internal/lsp: change to helper.go to output a formatted file 2020-01-31 20:35:38 +00:00
lsprpc internal/lsp/regtest: use a common directory for regtest sandboxes 2020-07-09 18:15:24 +00:00
mod internal/lsp: add new go.mod requires to files with unused require 2020-07-10 04:15:23 +00:00
protocol internal/lsp: bring lsp protocol stubs up to date 2020-06-11 18:15:06 +00:00
regtest internal/lsp: add new go.mod requires to files with unused require 2020-07-10 04:15:23 +00:00
snippet
source internal/lsp: fix rename with Windows line endings 2020-07-10 04:00:52 +00:00
testdata internal/lsp: fix rename with Windows line endings 2020-07-10 04:00:52 +00:00
tests internal/lsp: fix rename with Windows line endings 2020-07-10 04:00:52 +00:00
code_action.go internal/lsp: check if analysis enabled in convenience fixes 2020-07-08 18:02:25 +00:00
command.go internal/lsp: don't use -modfile for go mod commands 2020-06-22 20:30:43 +00:00
completion_test.go internal/lsp/source: offer smart "append()" completions 2020-05-20 22:05:37 +00:00
completion.go internal/lsp: remove VS Code-specific completion hack 2020-06-30 15:48:51 +00:00
definition.go internal/lsp: read files eagerly 2020-06-11 22:11:59 +00:00
diagnostics.go internal/lsp: don't use -modfile for go mod commands 2020-06-22 20:30:43 +00:00
folding_range.go internal/lsp: read files eagerly 2020-06-11 22:11:59 +00:00
format.go internal/lsp: read files eagerly 2020-06-11 22:11:59 +00:00
general.go internal/lsp/regtest: await IWL before running tests 2020-07-08 00:37:08 +00:00
generate.go internal/lsp: un-export (*snapshot).Config to limit it to cache 2020-06-15 22:28:25 +00:00
highlight.go internal/lsp: read files eagerly 2020-06-11 22:11:59 +00:00
hover.go internal/lsp: read files eagerly 2020-06-11 22:11:59 +00:00
implementation.go internal/lsp: read files eagerly 2020-06-11 22:11:59 +00:00
link.go internal/lsp: refactor various module-specific handles in cache 2020-06-23 18:31:46 +00:00
lsp_test.go internal/lsp: fix rename with Windows line endings 2020-07-10 04:00:52 +00:00
progress.go internal/lsp: factor out progress reporting to a new WorkDone handle 2020-04-28 20:46:18 +00:00
references.go internal/lsp: read files eagerly 2020-06-11 22:11:59 +00:00
rename.go internal/lsp: read files eagerly 2020-06-11 22:11:59 +00:00
reset_golden.sh
server_gen.go x/tools/gopls: add support for $/progress functionality 2020-03-16 21:25:24 +00:00
server.go internal/lsp: read files eagerly 2020-06-11 22:11:59 +00:00
signature_help.go internal/lsp: read files eagerly 2020-06-11 22:11:59 +00:00
symbols.go internal/lsp: read files eagerly 2020-06-11 22:11:59 +00:00
text_synchronization.go internal/lsp/regtest: await IWL before running tests 2020-07-08 00:37:08 +00:00
workspace_symbol.go internal/lsp/source: add a new symbolStyle configuration option 2020-06-26 17:13:37 +00:00
workspace.go internal/lsp: support opening single files 2020-07-01 22:10:12 +00:00