1
0
mirror of https://github.com/golang/go synced 2024-10-01 04:18:33 -06:00
go/internal/lsp/source
Rebecca Stambler 11affa06ff internal/lsp: show errors when the user is in the wrong directory
If we encounter `go list` errors when loading a user's package, we
should try to see if they've encountered any of our common error cases.
They are: 1) a user has GO111MODULE=off, but is outside of their GOPATH,
and 2) a user is in module mode but doesn't have a go.mod file.

Fortunately, go/packages does a great job handling edge cases so gopls
will work well for most of them. The main issue will be unresolved
imports. These show up in DepErrors in `go list`, so go/packages doesn't
propagate them through to the list of errors. This will require changes
to go/packages.

Updates golang/go#31668

Change-Id: Ibd5253b33b38caffeaad54a403c74c0b861fcc14
Reviewed-on: https://go-review.googlesource.com/c/tools/+/194018
Run-TryBot: Rebecca Stambler <rstambler@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Ian Cottrell <iancottrell@google.com>
2019-09-17 21:41:55 +00:00
..
analysis.go go/analysis: handle common nil pointers 2019-08-24 21:01:00 +00:00
completion_format.go internal/lsp: distinguish parse errors from actual errors 2019-09-17 21:21:32 +00:00
completion_snippet.go internal/lsp: simplify snippet config/generation 2019-09-10 04:45:52 +00:00
completion.go internal/lsp: distinguish parse errors from actual errors 2019-09-17 21:21:32 +00:00
deep_completion.go internal/lsp: tighten up completion budget check 2019-09-17 02:32:08 +00:00
diagnostics_test.go internal/span: change URI.Filename so it just returns the filename 2019-06-10 21:39:43 +00:00
diagnostics.go internal/lsp: show errors when the user is in the wrong directory 2019-09-17 21:41:55 +00:00
enums.go internal/lsp: switch to using protocol positions for document symbols 2019-09-06 18:11:17 +00:00
errors.go internal/lsp: show errors when the user is in the wrong directory 2019-09-17 21:41:55 +00:00
folding_range.go internal/lsp: distinguish parse errors from actual errors 2019-09-17 21:21:32 +00:00
format.go internal/lsp: show errors when the user is in the wrong directory 2019-09-17 21:41:55 +00:00
highlight.go internal/lsp: distinguish parse errors from actual errors 2019-09-17 21:21:32 +00:00
hover.go internal/lsp: remove the GetToken and GetAST functions 2019-09-09 18:10:35 +00:00
identifier.go internal/lsp: distinguish parse errors from actual errors 2019-09-17 21:21:32 +00:00
imports_test.go internal/lsp: abstract the diff library so it can be substituted 2019-08-20 03:37:07 +00:00
imports.go internal/lsp: abstract the diff library so it can be substituted 2019-08-20 03:37:07 +00:00
options.go internal/lsp: tighten up completion budget check 2019-09-17 02:32:08 +00:00
references.go internal/lsp: remove helpers for getting packages 2019-09-17 16:23:42 +00:00
rename_check.go internal/lsp: use memoize package to cache source.Packages 2019-08-13 21:41:43 +00:00
rename.go internal/lsp: distinguish parse errors from actual errors 2019-09-17 21:21:32 +00:00
signature_help.go internal/lsp: distinguish parse errors from actual errors 2019-09-17 21:21:32 +00:00
source_test.go internal/lsp: show errors when the user is in the wrong directory 2019-09-17 21:41:55 +00:00
suggested_fix.go internal/lsp: distinguish parse errors from actual errors 2019-09-17 21:21:32 +00:00
symbols.go internal/lsp: distinguish parse errors from actual errors 2019-09-17 21:21:32 +00:00
util.go internal/lsp: distinguish parse errors from actual errors 2019-09-17 21:21:32 +00:00
view.go internal/lsp: distinguish parse errors from actual errors 2019-09-17 21:21:32 +00:00