mirror of
https://github.com/golang/go
synced 2024-11-26 10:28:19 -07:00
1992893307
Dim performance has regressed by 14% vs 1.9 on amd64. Current pure go version of Dim is faster and, what is even more important for performance, is inlinable, so instead of tweaking asm implementation, just remove it. I had to update BenchmarkDim, because it was simply reloading constant(answer) in a loop. Perf data below: name old time/op new time/op delta Dim-6 6.79ns ± 0% 1.60ns ± 1% -76.39% (p=0.000 n=7+10) If I modify benchmark to be the same as in this CL results are even better: name old time/op new time/op delta Dim-6 10.2ns ± 0% 1.6ns ± 1% -84.27% (p=0.000 n=8+10) Updates #21913 Change-Id: I00e23c8affc293531e1d9f0e0e49f3a525634f53 Reviewed-on: https://go-review.googlesource.com/80695 Run-TryBot: Ilya Tocar <ilya.tocar@intel.com> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org> Reviewed-by: Ian Lance Taylor <iant@golang.org> Reviewed-by: Cherry Zhang <cherryyz@google.com>
82 lines
1.5 KiB
Go
82 lines
1.5 KiB
Go
// Copyright 2010 The Go Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
package math
|
|
|
|
// Dim returns the maximum of x-y or 0.
|
|
//
|
|
// Special cases are:
|
|
// Dim(+Inf, +Inf) = NaN
|
|
// Dim(-Inf, -Inf) = NaN
|
|
// Dim(x, NaN) = Dim(NaN, x) = NaN
|
|
func Dim(x, y float64) float64 {
|
|
// The special cases result in NaN after the subtraction:
|
|
// +Inf - +Inf = NaN
|
|
// -Inf - -Inf = NaN
|
|
// NaN - y = NaN
|
|
// x - NaN = NaN
|
|
v := x - y
|
|
if v <= 0 {
|
|
// v is negative or 0
|
|
return 0
|
|
}
|
|
// v is positive or NaN
|
|
return v
|
|
}
|
|
|
|
// Max returns the larger of x or y.
|
|
//
|
|
// Special cases are:
|
|
// Max(x, +Inf) = Max(+Inf, x) = +Inf
|
|
// Max(x, NaN) = Max(NaN, x) = NaN
|
|
// Max(+0, ±0) = Max(±0, +0) = +0
|
|
// Max(-0, -0) = -0
|
|
func Max(x, y float64) float64
|
|
|
|
func max(x, y float64) float64 {
|
|
// special cases
|
|
switch {
|
|
case IsInf(x, 1) || IsInf(y, 1):
|
|
return Inf(1)
|
|
case IsNaN(x) || IsNaN(y):
|
|
return NaN()
|
|
case x == 0 && x == y:
|
|
if Signbit(x) {
|
|
return y
|
|
}
|
|
return x
|
|
}
|
|
if x > y {
|
|
return x
|
|
}
|
|
return y
|
|
}
|
|
|
|
// Min returns the smaller of x or y.
|
|
//
|
|
// Special cases are:
|
|
// Min(x, -Inf) = Min(-Inf, x) = -Inf
|
|
// Min(x, NaN) = Min(NaN, x) = NaN
|
|
// Min(-0, ±0) = Min(±0, -0) = -0
|
|
func Min(x, y float64) float64
|
|
|
|
func min(x, y float64) float64 {
|
|
// special cases
|
|
switch {
|
|
case IsInf(x, -1) || IsInf(y, -1):
|
|
return Inf(-1)
|
|
case IsNaN(x) || IsNaN(y):
|
|
return NaN()
|
|
case x == 0 && x == y:
|
|
if Signbit(x) {
|
|
return x
|
|
}
|
|
return y
|
|
}
|
|
if x < y {
|
|
return x
|
|
}
|
|
return y
|
|
}
|