1
0
mirror of https://github.com/golang/go synced 2024-11-18 23:05:06 -07:00
go/internal/lsp/cache
Rebecca Stambler 3d51b05cfb internal/lsp: don't use overlays from the session in the snapshot
Hold the session's overlay mutex the whole time we compute new overlays,
and then pass these overlays directly into clone. This avoids us calling
s.session.GetFile, which can return overlays that the snapshot doesn't
yet "know" about.

Change-Id: I1a10c78e26f8fec64550bfe0a97b5975ea8f976b
Reviewed-on: https://go-review.googlesource.com/c/tools/+/218321
Run-TryBot: Rebecca Stambler <rstambler@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Heschi Kreinick <heschi@google.com>
2020-02-07 19:21:16 +00:00
..
analysis.go internal/lsp: determine parse mode based on workspace packages 2020-02-04 23:03:16 +00:00
cache.go internal/lsp/debug: serve cache entry counts 2020-02-03 22:21:18 +00:00
check.go internal/lsp/cache: don't type check types.Unsafe 2020-02-07 18:36:39 +00:00
debug.go internal/lsp/cache: add Env to debugView 2020-01-31 20:48:24 +00:00
error_test.go internal/lsp: refactor error handling code in type-checking 2019-10-21 18:57:46 +00:00
errors.go internal/lsp: don't show list errors unless necessary 2020-01-27 19:59:09 +00:00
external.go internal/lsp: check that a file handle is unmodified before read 2020-01-23 20:52:07 +00:00
load.go internal/lsp: build overlays through the snapshot 2020-02-07 18:37:49 +00:00
mod_tidy.go internal/lsp: build overlays through the snapshot 2020-02-07 18:37:49 +00:00
parse.go internal/lsp/source: improve completion after accidental keywords 2020-02-06 05:08:22 +00:00
pkg.go internal/lsp: determine parse mode based on workspace packages 2020-02-04 23:03:16 +00:00
session.go internal/lsp: don't use overlays from the session in the snapshot 2020-02-07 19:21:16 +00:00
snapshot.go internal/lsp: don't use overlays from the session in the snapshot 2020-02-07 19:21:16 +00:00
view.go internal/lsp: don't use overlays from the session in the snapshot 2020-02-07 19:21:16 +00:00