mirror of
https://github.com/golang/go
synced 2024-11-18 12:24:48 -07:00
a16954b8a7
The pointer checking code needs to know the exact type of the parameter expected by the C function, so that it can use a type assertion to convert the empty interface returned by cgoCheckPointer to the correct type. Previously this was done by using a type conversion, but that meant that the code accepted arguments that were convertible to the parameter type, rather than arguments that were assignable as in a normal function call. In other words, some code that should not have passed type checking was accepted. This CL changes cgo to always use a function literal for pointer checking. Now the argument is passed to the function literal, which has the correct argument type, so type checking is performed just as for a function call as it should be. Since we now always use a function literal, simplify the checking code to run as a statement by itself. It now no longer needs to return a value, and we no longer need a type assertion. This does have the cost of introducing another function call into any call to a C function that requires pointer checking, but the cost of the additional call should be minimal compared to the cost of pointer checking. Fixes #16591. Change-Id: I220165564cf69db9fd5f746532d7f977a5b2c989 Reviewed-on: https://go-review.googlesource.com/31233 Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Matthew Dempsky <mdempsky@google.com>
64 lines
1.4 KiB
Bash
Executable File
64 lines
1.4 KiB
Bash
Executable File
#!/usr/bin/env bash
|
|
|
|
# Copyright 2013 The Go Authors. All rights reserved.
|
|
# Use of this source code is governed by a BSD-style
|
|
# license that can be found in the LICENSE file.
|
|
|
|
check() {
|
|
file=$1
|
|
line=$(grep -n 'ERROR HERE' $file | sed 's/:.*//')
|
|
if [ "$line" = "" ]; then
|
|
echo 1>&2 misc/cgo/errors/test.bash: BUG: cannot find ERROR HERE in $file
|
|
exit 1
|
|
fi
|
|
expect $file $file:$line:
|
|
}
|
|
|
|
expect() {
|
|
file=$1
|
|
shift
|
|
if go build $file >errs 2>&1; then
|
|
echo 1>&2 misc/cgo/errors/test.bash: BUG: expected cgo to fail on $file but it succeeded
|
|
exit 1
|
|
fi
|
|
if ! test -s errs; then
|
|
echo 1>&2 misc/cgo/errors/test.bash: BUG: expected error output for $file but saw none
|
|
exit 1
|
|
fi
|
|
for error; do
|
|
if ! fgrep $error errs >/dev/null 2>&1; then
|
|
echo 1>&2 misc/cgo/errors/test.bash: BUG: expected error output for $file to contain \"$error\" but saw:
|
|
cat 1>&2 errs
|
|
exit 1
|
|
fi
|
|
done
|
|
}
|
|
|
|
check err1.go
|
|
check err2.go
|
|
check err3.go
|
|
check issue7757.go
|
|
check issue8442.go
|
|
check issue11097a.go
|
|
check issue11097b.go
|
|
expect issue13129.go C.ushort
|
|
check issue13423.go
|
|
expect issue13635.go C.uchar C.schar C.ushort C.uint C.ulong C.longlong C.ulonglong C.complexfloat C.complexdouble
|
|
check issue13830.go
|
|
check issue16116.go
|
|
check issue16591.go
|
|
|
|
if ! go build issue14669.go; then
|
|
exit 1
|
|
fi
|
|
if ! CGO_CFLAGS="-O" go build issue14669.go; then
|
|
exit 1
|
|
fi
|
|
|
|
if ! go run ptr.go; then
|
|
exit 1
|
|
fi
|
|
|
|
rm -rf errs _obj
|
|
exit 0
|